* [PATCH] ARM: s3c24xx: demote kerneldoc comment
@ 2020-08-02 20:36 Krzysztof Kozlowski
2020-08-02 20:42 ` Randy Dunlap
0 siblings, 1 reply; 2+ messages in thread
From: Krzysztof Kozlowski @ 2020-08-02 20:36 UTC (permalink / raw)
To: Kukjin Kim, Krzysztof Kozlowski, Russell King, linux-arm-kernel,
linux-samsung-soc, linux-kernel
Remove kerneldoc annotation to fix warning:
arch/arm/mach-s3c24xx/mach-h1940.c:185: warning:
cannot understand function prototype: 'struct s3c2410fb_display h1940_lcd __initdata = '
Signed-off-by: Krzysztof Kozlowski <krzk@kernel.org>
---
arch/arm/mach-s3c24xx/mach-h1940.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/arch/arm/mach-s3c24xx/mach-h1940.c b/arch/arm/mach-s3c24xx/mach-h1940.c
index 89528bea89f1..c09f61d35d57 100644
--- a/arch/arm/mach-s3c24xx/mach-h1940.c
+++ b/arch/arm/mach-s3c24xx/mach-h1940.c
@@ -179,9 +179,9 @@ static struct s3c2410_ts_mach_info h1940_ts_cfg __initdata = {
.cfg_gpio = s3c24xx_ts_cfg_gpio,
};
-/**
+/*
* Set lcd on or off
- **/
+ */
static struct s3c2410fb_display h1940_lcd __initdata = {
.lcdcon5= S3C2410_LCDCON5_FRM565 | \
S3C2410_LCDCON5_INVVLINE | \
--
2.17.1
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] ARM: s3c24xx: demote kerneldoc comment
2020-08-02 20:36 [PATCH] ARM: s3c24xx: demote kerneldoc comment Krzysztof Kozlowski
@ 2020-08-02 20:42 ` Randy Dunlap
0 siblings, 0 replies; 2+ messages in thread
From: Randy Dunlap @ 2020-08-02 20:42 UTC (permalink / raw)
To: Krzysztof Kozlowski, Kukjin Kim, Russell King, linux-arm-kernel,
linux-samsung-soc, linux-kernel
On 8/2/20 1:36 PM, Krzysztof Kozlowski wrote:
> Remove kerneldoc annotation to fix warning:
>
> arch/arm/mach-s3c24xx/mach-h1940.c:185: warning:
> cannot understand function prototype: 'struct s3c2410fb_display h1940_lcd __initdata = '
>
> Signed-off-by: Krzysztof Kozlowski <krzk@kernel.org>
> ---
> arch/arm/mach-s3c24xx/mach-h1940.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/arch/arm/mach-s3c24xx/mach-h1940.c b/arch/arm/mach-s3c24xx/mach-h1940.c
> index 89528bea89f1..c09f61d35d57 100644
> --- a/arch/arm/mach-s3c24xx/mach-h1940.c
> +++ b/arch/arm/mach-s3c24xx/mach-h1940.c
> @@ -179,9 +179,9 @@ static struct s3c2410_ts_mach_info h1940_ts_cfg __initdata = {
> .cfg_gpio = s3c24xx_ts_cfg_gpio,
> };
>
> -/**
> +/*
> * Set lcd on or off
> - **/
> + */
Yes, that's not kernel-doc notation, so demote it.
Acked-by: Randy Dunlap <rdunlap@infradead.org>
OTOH, we could also add "__initdata" to something that can be
handled by scripts/kernel-doc if it's needed, but it doesn't seem to
be needed just yet.
> static struct s3c2410fb_display h1940_lcd __initdata = {
> .lcdcon5= S3C2410_LCDCON5_FRM565 | \
> S3C2410_LCDCON5_INVVLINE | \
>
thanks.
--
~Randy
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2020-08-02 20:44 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2020-08-02 20:36 [PATCH] ARM: s3c24xx: demote kerneldoc comment Krzysztof Kozlowski
2020-08-02 20:42 ` Randy Dunlap
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox