From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-11.5 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH, MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED, USER_AGENT_SANE_2 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 2E67AC433DF for ; Mon, 3 Aug 2020 06:48:24 +0000 (UTC) Received: from merlin.infradead.org (merlin.infradead.org [205.233.59.134]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id EDFC720738 for ; Mon, 3 Aug 2020 06:48:23 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="DrU5Aj8p" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org EDFC720738 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=bootlin.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=merlin.20170209; h=Sender:Content-Transfer-Encoding: Content-Type:Cc:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To:Message-ID: Subject:To:From:Date:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=9NGNS3B/C60dcjATNA7sVKRjSoi+U/krr1EHH7pb+Iw=; b=DrU5Aj8prea+8iFsknlBx6z1k fNcz1puKaduPATaCkH/NIsJHAsy2X/1rndm+MeZUX2jTd+xHF/i7TzuWEeKg/fpbqCO0vQcI0aY6U owN4IlRkQIpHHR8ppO8nUi2MMTptVt9ruX3jgEcnSHAJfHfELCrWqYDdGhkG3cP0yiTn0QpNM2Vsw fMyNn66xLDWjIRQ57OCJ8/QBdNRyygWO1IjwPxiB1AYWocfOrPhJAQVAxVaDpDvR66PFFY4Olnb+z YrxRAjqKvxg9skMIamsPnv84hYoeYMR7is4uGkI4uikvdDW0ehTGMO9dED7p5U3sHmfw3+WgiDDXr joDNzN7VA==; Received: from localhost ([::1] helo=merlin.infradead.org) by merlin.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1k2UFK-0002aA-Nr; Mon, 03 Aug 2020 06:46:54 +0000 Received: from relay9-d.mail.gandi.net ([217.70.183.199]) by merlin.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1k2UFI-0002ZY-FR; Mon, 03 Aug 2020 06:46:53 +0000 X-Originating-IP: 91.224.148.103 Received: from xps13 (unknown [91.224.148.103]) (Authenticated sender: miquel.raynal@bootlin.com) by relay9-d.mail.gandi.net (Postfix) with ESMTPSA id AB251FF804; Mon, 3 Aug 2020 06:46:46 +0000 (UTC) Date: Mon, 3 Aug 2020 08:46:45 +0200 From: Miquel Raynal To: Colin King Subject: Re: [PATCH][next] drm/rockchip: lvds: ensure ret is assigned before checking for an error Message-ID: <20200803084645.442b5178@xps13> In-Reply-To: <20200714190003.744069-1-colin.king@canonical.com> References: <20200714190003.744069-1-colin.king@canonical.com> Organization: Bootlin X-Mailer: Claws Mail 3.17.4 (GTK+ 2.24.32; x86_64-pc-linux-gnu) MIME-Version: 1.0 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20200803_024652_609617_6F228CDD X-CRM114-Status: GOOD ( 17.81 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Heiko =?UTF-8?B?U3TDvGJuZXI=?= , David Airlie , kernel-janitors@vger.kernel.org, Sandy Huang , dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org, linux-rockchip@lists.infradead.org, Daniel Vetter , linux-arm-kernel@lists.infradead.org Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org SGVsbG8sCgpDb2xpbiBLaW5nIDxjb2xpbi5raW5nQGNhbm9uaWNhbC5jb20+IHdyb3RlIG9uIFR1 ZSwgMTQgSnVsIDIwMjAKMjA6MDA6MDMgKzAxMDA6Cgo+IEZyb206IENvbGluIElhbiBLaW5nIDxj b2xpbi5raW5nQGNhbm9uaWNhbC5jb20+Cj4gCj4gQ3VycmVudGx5IHRoZXJlIGFyZSB0d28gcGxh Y2VzIHdoZXJlIHRoZSByZXR1cm4gc3RhdHVzIGluIHJldCBpcyBiZWluZwo+IGNoZWNrZWQgZm9y IGFuIGVycm9yIGhvd2V2ZXIgdGhlIGFzc2lnbm1lbnQgb2YgcmV0IGhhcyBiZWVuIG9taXR0ZWQK PiBtYWtpbmcgdGhlIGNoZWNrcyByZWR1bmRhbnQuICBGaXggdGhpcyBieSBhZGRpbmcgaW4gdGhl IG1pc3NpbmcgYXNzaWdubWVudHMKPiBvZiByZXQuCj4gCj4gQWRkcmVzc2VzLUNvdmVyaXR5OiAo IkxvZ2ljYWxseSBkZWFkIGNvZGUiKQo+IEZpeGVzOiBjY2ExNzA1YzNkODkgKCJkcm0vcm9ja2No aXA6IGx2ZHM6IEFkZCBQWDMwIHN1cHBvcnQiKQo+IFNpZ25lZC1vZmYtYnk6IENvbGluIElhbiBL aW5nIDxjb2xpbi5raW5nQGNhbm9uaWNhbC5jb20+Cj4gLS0tCj4gIGRyaXZlcnMvZ3B1L2RybS9y b2NrY2hpcC9yb2NrY2hpcF9sdmRzLmMgfCA0ICsrLS0KPiAgMSBmaWxlIGNoYW5nZWQsIDIgaW5z ZXJ0aW9ucygrKSwgMiBkZWxldGlvbnMoLSkKPiAKPiBkaWZmIC0tZ2l0IGEvZHJpdmVycy9ncHUv ZHJtL3JvY2tjaGlwL3JvY2tjaGlwX2x2ZHMuYyBiL2RyaXZlcnMvZ3B1L2RybS9yb2NrY2hpcC9y b2NrY2hpcF9sdmRzLmMKPiBpbmRleCA2M2Y5Njc5MDJjMmQuLmI0NWM2MThiOTc5MyAxMDA2NDQK PiAtLS0gYS9kcml2ZXJzL2dwdS9kcm0vcm9ja2NoaXAvcm9ja2NoaXBfbHZkcy5jCj4gKysrIGIv ZHJpdmVycy9ncHUvZHJtL3JvY2tjaGlwL3JvY2tjaGlwX2x2ZHMuYwo+IEBAIC00OTksMTEgKzQ5 OSwxMSBAQCBzdGF0aWMgaW50IHB4MzBfbHZkc19wcm9iZShzdHJ1Y3QgcGxhdGZvcm1fZGV2aWNl ICpwZGV2LAo+ICAJaWYgKElTX0VSUihsdmRzLT5kcGh5KSkKPiAgCQlyZXR1cm4gUFRSX0VSUihs dmRzLT5kcGh5KTsKPiAgCj4gLQlwaHlfaW5pdChsdmRzLT5kcGh5KTsKPiArCXJldCA9IHBoeV9p bml0KGx2ZHMtPmRwaHkpOwo+ICAJaWYgKHJldCkKPiAgCQlyZXR1cm4gcmV0Owo+ICAKPiAtCXBo eV9zZXRfbW9kZShsdmRzLT5kcGh5LCBQSFlfTU9ERV9MVkRTKTsKPiArCXJldCA9IHBoeV9zZXRf bW9kZShsdmRzLT5kcGh5LCBQSFlfTU9ERV9MVkRTKTsKPiAgCWlmIChyZXQpCj4gIAkJcmV0dXJu IHJldDsKPiAgCgpJIHRob3VnaHQgSSAob3IgSGVpa28pIGFscmVhZHkgc2VudCBhIHBhdGNoIGZv ciB0aGF0IGJ1dCBhcHBhcmVudGx5Cm5vdC4uLgoKUmV2aWV3ZWQtYnk6IE1pcXVlbCBSYXluYWwg PG1pcXVlbC5yYXluYWxAYm9vdGxpbi5jb20+CgpUaGFua3MsCk1pcXXDqGwKCl9fX19fX19fX19f X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fCmxpbnV4LWFybS1rZXJuZWwgbWFp bGluZyBsaXN0CmxpbnV4LWFybS1rZXJuZWxAbGlzdHMuaW5mcmFkZWFkLm9yZwpodHRwOi8vbGlz dHMuaW5mcmFkZWFkLm9yZy9tYWlsbWFuL2xpc3RpbmZvL2xpbnV4LWFybS1rZXJuZWwK