From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.5 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id EC151C433E0 for ; Mon, 3 Aug 2020 11:55:07 +0000 (UTC) Received: from merlin.infradead.org (merlin.infradead.org [205.233.59.134]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id B69302076C for ; Mon, 3 Aug 2020 11:55:07 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="nAO/5WBH" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org B69302076C Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=arm.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=merlin.20170209; h=Sender:Content-Transfer-Encoding: Content-Type:Cc:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References:Message-ID: Subject:To:From:Date:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=5P1Ry9aN/l6E2/kd2wJLKvg1Qu6b16plvUFonqr/pXc=; b=nAO/5WBHoazBC0o17l+1tkv30 n0YRR/8z1fnzX7zXTviYai4Hgr9SCspq6JBIVDE6oIhB4VgfRk0+EUyBVKHF5Yrf4Y101fWA3pXXI HvdXJw/IoeYmw+jz1N3Ie4pX0OK59p2vVjT1bhcEBeu8ZGfp3lXyKPxNDHVG81FAX7DglXY2pK4u0 frxISQt9qRlztaTLonAuUXLhATHd52TB/GR9bgMomgDWvA6wjGK1YvztR5l+jta4EI6SC0SlgPbjP Rd5uqMeMt55rWjX+Z2tvlamRWX6X4HVrzy+q757ukRKaKMT7nC1GPf1p22k2SaK2oxTHW04MeFkFV QPLSiACjQ==; Received: from localhost ([::1] helo=merlin.infradead.org) by merlin.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1k2Z2N-0000hM-K0; Mon, 03 Aug 2020 11:53:51 +0000 Received: from mail.kernel.org ([198.145.29.99]) by merlin.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1k2Z2L-0000gl-Ho for linux-arm-kernel@lists.infradead.org; Mon, 03 Aug 2020 11:53:50 +0000 Received: from gaia (unknown [95.146.230.158]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id E1E2220775; Mon, 3 Aug 2020 11:53:46 +0000 (UTC) Date: Mon, 3 Aug 2020 12:53:45 +0100 From: Catalin Marinas To: Pingfan Liu Subject: Re: [PATCH] arm64/fixmap: make notes of fixed_addresses more precisely Message-ID: <20200803115344.GC6132@gaia> References: <1594388602-17790-1-git-send-email-kernelfans@gmail.com> <20200730110937.GH25149@gaia> <20200731121334.GC29569@gaia> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.10.1 (2018-07-13) X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20200803_075349_648258_9F44F8FE X-CRM114-Status: GOOD ( 15.09 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Will Deacon , linux-arm-kernel@lists.infradead.org Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Mon, Aug 03, 2020 at 10:07:16AM +0800, Pingfan Liu wrote: > What about description like: > diff --git a/arch/arm64/include/asm/fixmap.h b/arch/arm64/include/asm/fixmap.h > index f987b8a..4335800 100644 > --- a/arch/arm64/include/asm/fixmap.h > +++ b/arch/arm64/include/asm/fixmap.h > @@ -28,10 +28,9 @@ > * compile time, but to set the physical address only > * in the boot process. > * > - * These 'compile-time allocated' memory buffers are > - * page-sized. Use set_fixmap(idx,phys) to associate > - * physical memory with fixmap indices. > - * > + * Each enum increment in these 'compile-time allocated' > + * memory buffers is page-sized. Use set_fixmap(idx,phys) > + * to associate physical memory with a fixmap index. > */ It looks fine. Please send it as a separate patch. Thanks. -- Catalin _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel