From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-4.0 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS, URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 0C0CFC433E0 for ; Mon, 3 Aug 2020 17:00:36 +0000 (UTC) Received: from merlin.infradead.org (merlin.infradead.org [205.233.59.134]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id CECE620678 for ; Mon, 3 Aug 2020 17:00:35 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="q6qyd5Zh"; dkim=fail reason="signature verification failed" (1024-bit key) header.d=kernel.org header.i=@kernel.org header.b="zDNggJHg" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org CECE620678 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=kernel.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=merlin.20170209; h=Sender:Content-Type:Cc: List-Subscribe:List-Help:List-Post:List-Archive:List-Unsubscribe:List-Id: In-Reply-To:MIME-Version:References:Message-ID:Subject:To:From:Date:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=fggk2qpEkThoYIslnkKLgp8b8bjXcHYgBciQT/z27a8=; b=q6qyd5ZhvaM1Q8reOHje8VSvg fX5Gn5A4P7iCqG0V0ggqzZUfZySBJvbao1mnjZXc5vPLie9JgPLJ1W/IUWUgsbpHLo/FunQ/yEmH6 3S1Es5I19yqdfd4z6/MkYuHymkq7UGygS/6l5y4QMGCXid+uFL5hgoBvGLD4/W/l+maTqCJnZoUWP 3KSXQ5JFc7Uj4+vUmNuuL6ZVSPr/7P8+euR8OnpsOgDJImNyDiUtrpbKF3tOJ0C/oC6EFyuaW32dY WyXDuj+IbpLf8PLHwr/J0y2DLknfXdtLjBryAnk/mM+5ei8jig3D1cz+rourgHgIMo4GSRC+sWxKl eNEGbwsgw==; Received: from localhost ([::1] helo=merlin.infradead.org) by merlin.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1k2do0-000408-BO; Mon, 03 Aug 2020 16:59:20 +0000 Received: from mail.kernel.org ([198.145.29.99]) by merlin.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1k2dny-0003zN-Dm for linux-arm-kernel@lists.infradead.org; Mon, 03 Aug 2020 16:59:19 +0000 Received: from localhost (router.4pisysteme.de [80.79.225.122]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 78B0622B40; Mon, 3 Aug 2020 16:59:15 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1596473955; bh=DqVTfmEqV/Cd46vTFRwbyJjRVKLkVy4VzmMDGHxdDeQ=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=zDNggJHg+wW8HizMOFqed5jrz1O7yhNyHY66jfbF9gNNWuCWCccP0bQ7aQf5QBrcu Jjfz5XlzXoL0va1gSo7csbJ4QcLDkQmSBicLlb/dw5sDtKa+xk6RNSklE2k9m1k4rT zRy7bO1p/sStqAO69VEyefPafi1GDw2c58jJN2I0= Date: Mon, 3 Aug 2020 18:59:14 +0200 From: To: Subject: Re: Re: [RFC PATCH 3/4] i2c: core: treat EPROBE_DEFER when acquiring SCL/SDA GPIOs Message-ID: <20200803165914.GB1094@kunai> Mail-Followup-To: , , , , , , , , , , , References: <20200619141904.910889-1-codrin.ciubotariu@microchip.com> <20200619141904.910889-4-codrin.ciubotariu@microchip.com> <20200802170500.GB10193@kunai> <15a449fa-d649-846a-e6f2-1540f9581846@microchip.com> MIME-Version: 1.0 In-Reply-To: <15a449fa-d649-846a-e6f2-1540f9581846@microchip.com> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20200803_125918_597197_25110F32 X-CRM114-Status: GOOD ( 18.49 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: devicetree@vger.kernel.org, alexandre.belloni@bootlin.com, kamel.bouhara@bootlin.com, linux-kernel@vger.kernel.org, Ludovic.Desroches@microchip.com, robh+dt@kernel.org, linux-i2c@vger.kernel.org, linux@armlinux.org.uk, linux-arm-kernel@lists.infradead.org Content-Type: multipart/mixed; boundary="===============5938302896617549926==" Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org --===============5938302896617549926== Content-Type: multipart/signed; micalg=pgp-sha512; protocol="application/pgp-signature"; boundary="H1spWtNR+x+ondvy" Content-Disposition: inline --H1spWtNR+x+ondvy Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable > > This is correct but I think the code flow is/was confusing. Can you drop > > this 'return' and use 'else if' for the next code block? I think this is > > more readable. >=20 > Ok, it makes sense. Should I make a separate patch for this only? I am fine if this is included in this change. > One more question, should we keep: > if (!bri->set_sda && !bri->get_sda) { > err_str =3D "either get_sda() or set_sda() needed"; > goto err; > } > ? > Without {get/set}_sda we won't be able to generate stop commands and=20 > possibly check if the bus is free, but we can still generate the SCL=20 > clock pulses. My gut feeling says we need to keep it. I can't recall the reason now and want to send out this answer ASAP. Anyhow, this definately would be a seperate patch. If you really want to, send a patch, and then I have to think why we still need it ;) > Ok. Perhaps I should also move the debug print with the registered=20 > adapter after calling i2c_init_recovery(). Yes, makes sense. > Do you want me to integrate this patch in the previous one? Nope, please keep it seperate. --H1spWtNR+x+ondvy Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQIzBAABCgAdFiEEOZGx6rniZ1Gk92RdFA3kzBSgKbYFAl8oQmIACgkQFA3kzBSg KbZAwBAAppfK0ya+k9k/yXUrX5Y6knQZb/OpTwELmfjUaWHzhPRzFDfJrjuDb1QM /ZL+DKK8/NsKLsWv1RSjd5BydPiToyQG+vcKGSBzcxLrXogzuqR4SP81uuwxUBzb uKyCjQoJg+wYR4wbjAInYtSaygqXfyjkhtJOjtBnn9eXxu0Z/3HojJhTfpREwoss oIO86EySSKGJ1U5u7uSJD0ghSVjzGgWjilAmXV+JwcKHkl/dRl88ztiri+qzVScw apychYdxxB2CjTrgS8oV1A1rv3fiPhBOvLs2a6yQ57K5MzY6wdzcb6phrwSA9iFm aNsmVLOtRiVVCe832EgYmyVMb2PPuuWcwo88jNJ1bawIlLHctqdjngeg/nG/oiRv bhoy5sy5/Lg5nce7bpWUGovkwr/vCyhe3B6gGX4VmUgHu7ElKhy4Tc0azte5lD3H nR49oIvZUertN6pX8kx2dZTq6h/Lsc4aFxVoc3tWDFQVaG82L5HohwDW69c8n8QO 1Bwi70uJGjaeGQ2+RVqz8M37Qz3Rk7sfs3N+/a8pxHOY9MrlOANNE3jIN/MSbdc9 n2WUkMP4EPDjBAHyzcmNj7Xx93rt/2cQvfANgnO5N+Z+m7ut0zZnxlVtg3YkhtpH y1VJXkPg7BCvFCn6xKDa9Dpb7fOGgUVUGdX4yqDXCRbuW5m5Sl0= =42Sy -----END PGP SIGNATURE----- --H1spWtNR+x+ondvy-- --===============5938302896617549926== Content-Type: text/plain; charset="us-ascii" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Content-Disposition: inline _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel --===============5938302896617549926==--