From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-13.0 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_GIT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id D415BC433E0 for ; Mon, 3 Aug 2020 19:32:58 +0000 (UTC) Received: from merlin.infradead.org (merlin.infradead.org [205.233.59.134]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 4831122B45 for ; Mon, 3 Aug 2020 19:32:58 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="XEQcYl+T" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 4831122B45 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=kernel.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=merlin.20170209; h=Sender:Content-Transfer-Encoding: Content-Type:Cc:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To:Message-Id:Date: Subject:To:From:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=fANNJH2zgsrT6v9ynKZYwpVldxJwGbZMvaP3ak3LVNQ=; b=XEQcYl+TvqDO3bj/vs87nX+tI yWQyjV6t4wVw2vUjk5oySaGgx5e1QpgLsJeq3Rxa8GwurGV5N5HJ3mGmxYRfJWxpB4DmDeDI0BlKE 1bjpMrGe1xiS/25ylELI+pIGDJGLw16gNQooO3INvhvlJ2rXIB9LVcuGTf181JOcRne0xOy+RnE2i 9EAT0Dw4zDm+XRYHH4UO8jeBD/4v+TyxnmkadjVADer4iLYt0LUgqob/Zb6wQnQW4sRgyIL62d9Io /gIJ0q7+WYBo5n0BxqEt8ZTVw4PiTo1zDccFNvj9WrKut9lhf69n46v08rSu5HA0JbmW8AZoXF1Cw 84MBZ/M5Q==; Received: from localhost ([::1] helo=merlin.infradead.org) by merlin.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1k2gBM-0003Gn-3u; Mon, 03 Aug 2020 19:31:36 +0000 Received: from mail-io1-f68.google.com ([209.85.166.68]) by merlin.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1k2gBI-0003FB-FM for linux-arm-kernel@lists.infradead.org; Mon, 03 Aug 2020 19:31:33 +0000 Received: by mail-io1-f68.google.com with SMTP id u126so2453646iod.12 for ; Mon, 03 Aug 2020 12:31:31 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=j63V9CdXPRw65XqqzN2bqRvwfPF7ISjBsKgk8HEVQnE=; b=DyYFyeBjU7gQd+K48+VyC52EOGy8KuLIVoUQRoIJWsQMmh1mC3xwljko1talNGdjbZ mSbt6IpOMwFNo16lTpL68Hhg2K6MQDA1aBv2nv51Eufd2imFitkG+tX1I6ShJvXgOthz Oc3utagFUBkFm/xfoHAYiATULU1m3QExghOaYFSilNQfz8tFp81dvaDmji3QHHFqVLVb ZFSLIttfYi6OYJMEaBm3GfjoXun4CNnX3dXv92Rq4YRLNIzPjvA59qjgtI8S+f5WpIUF Vh9WDq498a9krNmMaDTTSRc7OgrVVqSZ67AEf4OqbIFpyr7tNRn6s9iqvuUBEpy79T2O LkpA== X-Gm-Message-State: AOAM531jloyFwzwNrnNYFvpzmZrIBRl/BYXiBfZ7L8I3LK72pkJDlRn8 hKM5rBwsPnDGQS4Ojm4G7A== X-Google-Smtp-Source: ABdhPJxcA0fkFnLT4iFQRI78IP34MbLmhHo68FNBp3OoOx6jxY6MQ5Iy9duqqKv1rn2pJ2OFbmGHtg== X-Received: by 2002:a5e:dd02:: with SMTP id t2mr1413126iop.90.1596483090665; Mon, 03 Aug 2020 12:31:30 -0700 (PDT) Received: from xps15.herring.priv ([64.188.179.252]) by smtp.googlemail.com with ESMTPSA id j79sm11254738ilg.42.2020.08.03.12.31.29 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 03 Aug 2020 12:31:30 -0700 (PDT) From: Rob Herring To: Catalin Marinas , Will Deacon , Marc Zyngier Subject: [PATCH v4 1/3] KVM: arm64: Print warning when cpu erratum can cause guests to deadlock Date: Mon, 3 Aug 2020 13:31:25 -0600 Message-Id: <20200803193127.3012242-2-robh@kernel.org> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20200803193127.3012242-1-robh@kernel.org> References: <20200803193127.3012242-1-robh@kernel.org> MIME-Version: 1.0 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20200803_153132_544434_6567EFF4 X-CRM114-Status: GOOD ( 13.50 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: linux-arm-kernel@lists.infradead.org, Suzuki K Poulose , James Morse , Andrew Scull , kvmarm@lists.cs.columbia.edu, Julien Thierry Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org If guests don't have certain CPU erratum workarounds implemented, then there is a possibility a guest can deadlock the system. IOW, only trusted guests should be used on systems with the erratum. This is the case for Cortex-A57 erratum 832075. Cc: Marc Zyngier Cc: James Morse Cc: Julien Thierry Cc: Suzuki K Poulose Cc: Catalin Marinas Cc: Will Deacon Cc: kvmarm@lists.cs.columbia.edu Signed-off-by: Rob Herring --- v4: - Use cpus_have_final_cap instead of cpus_have_const_cap v3: - s/work-arounds/workarounds/ --- arch/arm64/kvm/arm.c | 4 ++++ 1 file changed, 4 insertions(+) diff --git a/arch/arm64/kvm/arm.c b/arch/arm64/kvm/arm.c index 90cb90561446..cbc8365307f2 100644 --- a/arch/arm64/kvm/arm.c +++ b/arch/arm64/kvm/arm.c @@ -1653,6 +1653,10 @@ int kvm_arch_init(void *opaque) return -ENODEV; } + if (cpus_have_final_cap(ARM64_WORKAROUND_DEVICE_LOAD_ACQUIRE)) + kvm_info("Guests without required CPU erratum workarounds can deadlock system!\n" \ + "Only trusted guests should be used on this system.\n"); + for_each_online_cpu(cpu) { smp_call_function_single(cpu, check_kvm_target_cpu, &ret, 1); if (ret < 0) { -- 2.25.1 _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel