From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-11.5 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH, MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED, USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 492B0C433E0 for ; Tue, 4 Aug 2020 00:39:18 +0000 (UTC) Received: from merlin.infradead.org (merlin.infradead.org [205.233.59.134]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 3D0DB2076C for ; Tue, 4 Aug 2020 00:39:18 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="HktA6CI0"; dkim=fail reason="signature verification failed" (1024-bit key) header.d=mg.codeaurora.org header.i=@mg.codeaurora.org header.b="NomZq6Nj" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 3D0DB2076C Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=codeaurora.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=merlin.20170209; h=Sender:Content-Transfer-Encoding: Content-Type:Cc:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References:Message-ID: Subject:To:From:Date:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=aQXbjE79SsXmN4nX8j4mSQZ7Go9el0tcFQ6JgtVuiDU=; b=HktA6CI0OraMZEBbnmGi+MhKn v9T8fQJ4Z0wZ2JisIIne/d8SuGxVIteVjQytldFAp6w9ijY7KPNmjZSs9sDZ0kEK0qxS4VHoDeTR1 VS74z46uCjW9RYFt0jDJrvNaYEFix6e55GDEtSYQcJGhdI9FbRlFIPGbto2Klodp83wytx+Y+70np WudXzE/qIoBswpk0YGyiRLpLcsQcDyoYFmr3mco3XBm7J95i8V4/EvIYvCsEaITVmYOscIFcfkexb m18b5+4hQYZlK+WVowUiSSCjso/cSibCI8MQ4lEiRqtT/5eiBItKziLAXC/lzTM+bj2iW0KHNh5EL Roh+Ui7HQ==; Received: from localhost ([::1] helo=merlin.infradead.org) by merlin.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1k2kxk-0006oh-Qx; Tue, 04 Aug 2020 00:37:52 +0000 Received: from m43-7.mailgun.net ([69.72.43.7]) by merlin.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1k2kxh-0006oJ-B2 for linux-arm-kernel@lists.infradead.org; Tue, 04 Aug 2020 00:37:50 +0000 DKIM-Signature: a=rsa-sha256; v=1; c=relaxed/relaxed; d=mg.codeaurora.org; q=dns/txt; s=smtp; t=1596501468; h=In-Reply-To: Content-Type: MIME-Version: References: Message-ID: Subject: Cc: To: From: Date: Sender; bh=GwtT7ytiQnI6agZ2in3lk9v8ogA4cBzaZO2e2Nk5XQQ=; b=NomZq6NjZr+FW71kiVsmIqlcoDP7SgTIiZPgx2mrSBxWnR4Wt4zvZSlcPReyE64a3veamBBP nmO4pIjF0JF3sKsFTgAMqle2ej0U4MqJg3ULGBxrMS1JZ6adbti5V1PoLEkQVp1+WCO9gWD1 YIdfM7b+zPi7bZdrQzeW0BU1frs= X-Mailgun-Sending-Ip: 69.72.43.7 X-Mailgun-Sid: WyJiYzAxZiIsICJsaW51eC1hcm0ta2VybmVsQGxpc3RzLmluZnJhZGVhZC5vcmciLCAiYmU5ZTRhIl0= Received: from smtp.codeaurora.org (ec2-35-166-182-171.us-west-2.compute.amazonaws.com [35.166.182.171]) by smtp-out-n14.prod.us-east-1.postgun.com with SMTP id 5f28addb2c24b37bbe0f2b13 (version=TLS1.2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256); Tue, 04 Aug 2020 00:37:47 GMT Received: by smtp.codeaurora.org (Postfix, from userid 1001) id F225BC433A0; Tue, 4 Aug 2020 00:37:46 +0000 (UTC) Received: from codeaurora.org (unknown [180.166.53.21]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) (Authenticated sender: tingwei) by smtp.codeaurora.org (Postfix) with ESMTPSA id DFDB1C433C9; Tue, 4 Aug 2020 00:37:42 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 smtp.codeaurora.org DFDB1C433C9 Authentication-Results: aws-us-west-2-caf-mail-1.web.codeaurora.org; dmarc=none (p=none dis=none) header.from=codeaurora.org Authentication-Results: aws-us-west-2-caf-mail-1.web.codeaurora.org; spf=none smtp.mailfrom=tingweiz@codeaurora.org Date: Tue, 4 Aug 2020 08:37:33 +0800 From: Tingwei Zhang To: Mike Leach Subject: Re: [PATCH v6 24/25] coresight: catu: allow catu drivers to be built as modules Message-ID: <20200804003733.GA1542@codeaurora.org> References: <20200731064012.8076-1-tingwei@codeaurora.org> <20200731064012.8076-25-tingwei@codeaurora.org> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.5.24 (2015-08-30) X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20200803_203749_648279_58977DF0 X-CRM114-Status: GOOD ( 30.82 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: tsoni@codeaurora.org, Sai Prakash Ranjan , Kim Phillips , Mathieu Poirier , Suzuki K Poulose , Alexander Shishkin , Greg Kroah-Hartman , Coresight ML , Randy Dunlap , Mian Yousaf Kaukab , Russell King , Mao Jinlong , Tingwei Zhang , Leo Yan , linux-arm-kernel Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org Hi Mike, On Tue, Aug 04, 2020 at 01:12:23AM +0800, Mike Leach wrote: > On Fri, 31 Jul 2020 at 07:42, Tingwei Zhang wrote: > > > > Allow to build coresight-catu as modules, for ease of development. > > - Kconfig becomes a tristate, to allow =m > > - add catu_remove functions, for module unload > > - add a MODULE_DEVICE_TABLE for autoloading on boot > > > > Signed-off-by: Tingwei Zhang > > --- > > drivers/hwtracing/coresight/Kconfig | 5 ++++- > > drivers/hwtracing/coresight/coresight-catu.c | 15 +++++++++++++++ > > 2 files changed, 19 insertions(+), 1 deletion(-) > > > > diff --git a/drivers/hwtracing/coresight/Kconfig > > b/drivers/hwtracing/coresight/Kconfig > > index b04aae2ceecc..dfe407cde262 100644 > > --- a/drivers/hwtracing/coresight/Kconfig > > +++ b/drivers/hwtracing/coresight/Kconfig > > @@ -42,7 +42,7 @@ config CORESIGHT_LINK_AND_SINK_TMC > > module will be called coresight-tmc. > > > > config CORESIGHT_CATU > > - bool "Coresight Address Translation Unit (CATU) driver" > > + tristate "Coresight Address Translation Unit (CATU) driver" > > depends on CORESIGHT_LINK_AND_SINK_TMC > > help > > Enable support for the Coresight Address Translation Unit > > (CATU). > > @@ -52,6 +52,9 @@ config CORESIGHT_CATU > > by looking up the provided table. CATU can also be used in > > pass-through > > mode where the address is not translated. > > > > + To compile this driver as a module, choose M here: the > > + module will be called coresight-catu. > > + > > config CORESIGHT_SINK_TPIU > > tristate "Coresight generic TPIU driver" > > depends on CORESIGHT_LINKS_AND_SINKS > > diff --git a/drivers/hwtracing/coresight/coresight-catu.c > > b/drivers/hwtracing/coresight/coresight-catu.c > > index 47696a7d24a7..7428cbe67921 100644 > > --- a/drivers/hwtracing/coresight/coresight-catu.c > > +++ b/drivers/hwtracing/coresight/coresight-catu.c > > @@ -567,11 +567,21 @@ static int catu_probe(struct amba_device *adev, > > const struct amba_id *id) > > return ret; > > } > > > > +static int __exit catu_remove(struct amba_device *adev) > > +{ > > + struct catu_drvdata *drvdata = dev_get_drvdata(&adev->dev); > > + > > + coresight_unregister(drvdata->csdev); > > + return 0; > > +} > > + > > static struct amba_id catu_ids[] = { > > CS_AMBA_ID(0x000bb9ee), > > {}, > > }; > > > > +MODULE_DEVICE_TABLE(amba, catu_ids); > > + > > static struct amba_driver catu_driver = { > > .drv = { > > .name = "coresight-catu", > > @@ -579,6 +589,7 @@ static struct amba_driver catu_driver = { > > .suppress_bind_attrs = true, > > }, > > .probe = catu_probe, > > + .remove = catu_remove, > > .id_table = catu_ids, > > }; > > > > @@ -601,3 +612,7 @@ static void __exit catu_exit(void) > > > > module_init(catu_init); > > module_exit(catu_exit); > > + > > +MODULE_AUTHOR("Suzuki K Poulose "); > > +MODULE_DESCRIPTION("Arm CoreSight Replicator Driver"); > > Name here should be the "CATU" not replicator > I'll address it in v7. Thanks, Tingwei > > +MODULE_LICENSE("GPL v2"); > > -- > > The Qualcomm Innovation Center, Inc. is a member of the Code Aurora Forum, > > a Linux Foundation Collaborative Project > > > > With the above change > > Reviewed by: Mike Leach > > > -- > Mike Leach > Principal Engineer, ARM Ltd. > Manchester Design Centre. UK _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel