From: Sudeep Holla <sudeep.holla@arm.com>
To: Jason Liu <jason.hui.liu@nxp.com>
Cc: catalin.marinas@arm.com, linux-kernel@vger.kernel.org,
ashal@kernel.org, maz@kernel.org, will@kernel.org,
linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH 1/1] arm64: kexec: no need to do irq_chip->irq_mask if it already masked
Date: Tue, 4 Aug 2020 11:20:25 +0100 [thread overview]
Message-ID: <20200804102025.GA15199@bogus> (raw)
In-Reply-To: <20200804085657.10776-1-jason.hui.liu@nxp.com>
+Marc Z
On Tue, Aug 04, 2020 at 04:56:57PM +0800, Jason Liu wrote:
> No need to do the irq_chip->irq_mask() if it already masked.
> BTW, unconditionally do the irq_chip->irq_mask() will also bring issues
> when the irq_chip in the runtime PM suspend. Accessing registers of the
> irq_chip will bring in the exceptions. For example on the i.MX:
>
The change looks good and is inline with the additional checks we do for
eoi and disable. However, the imx_irqsteer_irq_mask is not safe to be
called with runtime suspend. What happens if some driver using the irq
on this chip calls disable_irq when this irqchip is suspended ?
--
Regards,
Sudeep
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
next prev parent reply other threads:[~2020-08-04 10:22 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-08-04 8:56 [PATCH 1/1] arm64: kexec: no need to do irq_chip->irq_mask if it already masked Jason Liu
2020-08-04 10:20 ` Sudeep Holla [this message]
2020-08-05 6:30 ` Jason Liu
2020-08-04 10:58 ` Marc Zyngier
2020-08-04 11:38 ` Sudeep Holla
2020-08-05 6:31 ` Jason Liu
2020-08-05 8:17 ` Marc Zyngier
2020-08-06 10:05 ` Jason Liu
2020-08-06 12:25 ` Marc Zyngier
2020-08-13 6:03 ` Jason Liu
2020-08-13 10:08 ` Marc Zyngier
2020-08-05 8:47 ` Sudeep Holla
2020-08-06 10:09 ` Jason Liu
-- strict thread matches above, loose matches on Subject: below --
2020-07-02 9:27 Jason Liu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200804102025.GA15199@bogus \
--to=sudeep.holla@arm.com \
--cc=ashal@kernel.org \
--cc=catalin.marinas@arm.com \
--cc=jason.hui.liu@nxp.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=maz@kernel.org \
--cc=will@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).