From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-10.0 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH, MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id E59D7C433E0 for ; Tue, 4 Aug 2020 16:02:36 +0000 (UTC) Received: from merlin.infradead.org (merlin.infradead.org [205.233.59.134]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id BCEB7208A9 for ; Tue, 4 Aug 2020 16:02:36 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="KyFl/QtH" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org BCEB7208A9 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=bootlin.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=merlin.20170209; h=Sender:Content-Transfer-Encoding: Content-Type:Cc:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References:Message-ID: Subject:To:From:Date:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=iC/7ogBz206osnSougV4xLkB/q+/WcSwk7ifoQ/bGcc=; b=KyFl/QtH0iJ6gntNd9j0nV44N KhXmEQ5e/ZnQEJLxT4Nw2+0muj2gI55NsH4DgVJCyKKn4KTIFVgMd87LcNwvyvxjtUC5YFvRjVDeI 2SGB+/pi2yasAPIvnqUjl1V4a40PKqzJ0tiupPYhumBUHm3JX7G/dkUPFJkZq/LyM4kr8+BAH9bgb 9X2tZH+97en80OkvokVRH3GD/1no0QgGEhbHOsM50C9qx5KuqlWiXohMXtsVuDDeDBOsmY5KpxvOH eLelj+Sv0gN+mNfhA7Y9S+e8/xjbsPIGinji7odperP2dDeZ7bRq5OKad7LQM/HgKIvbcvd5Dc0L4 EjB6uZoAA==; Received: from localhost ([::1] helo=merlin.infradead.org) by merlin.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1k2zMg-0003W2-QN; Tue, 04 Aug 2020 16:00:34 +0000 Received: from relay3-d.mail.gandi.net ([217.70.183.195]) by merlin.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1k2zMe-0003Ux-O0 for linux-arm-kernel@lists.infradead.org; Tue, 04 Aug 2020 16:00:33 +0000 X-Originating-IP: 86.202.118.225 Received: from localhost (lfbn-lyo-1-23-225.w86-202.abo.wanadoo.fr [86.202.118.225]) (Authenticated sender: alexandre.belloni@bootlin.com) by relay3-d.mail.gandi.net (Postfix) with ESMTPSA id 20F0E6000C; Tue, 4 Aug 2020 16:00:28 +0000 (UTC) Date: Tue, 4 Aug 2020 18:00:28 +0200 From: Alexandre Belloni To: Claudiu Beznea Subject: Re: [PATCH] clk: at91: clk-main: update key before writing AT91_CKGR_MOR Message-ID: <20200804160028.GD10725@piout.net> References: <1596099803-1393-1-git-send-email-claudiu.beznea@microchip.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <1596099803-1393-1-git-send-email-claudiu.beznea@microchip.com> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20200804_120032_886198_C253DCA2 X-CRM114-Status: GOOD ( 16.06 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: mturquette@linaro.org, bbrezillon@kernel.org, sboyd@kernel.org, mturquette@baylibre.com, linux-kernel@vger.kernel.org, ludovic.desroches@microchip.com, linux-clk@vger.kernel.org, linux-arm-kernel@lists.infradead.org Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On 30/07/2020 12:03:23+0300, Claudiu Beznea wrote: > SAMA5D2 datasheet specifies on chapter 33.22.8 (PMC Clock Generator > Main Oscillator Register) that writing any value other than > 0x37 on KEY field aborts the write operation. Use the key when > selecting main clock parent. > > Fixes: 27cb1c2083373 ("clk: at91: rework main clk implementation") > Signed-off-by: Claudiu Beznea Reviewed-by: Alexandre Belloni > --- > drivers/clk/at91/clk-main.c | 11 ++++++++--- > 1 file changed, 8 insertions(+), 3 deletions(-) > > diff --git a/drivers/clk/at91/clk-main.c b/drivers/clk/at91/clk-main.c > index 5c83e899084f..cfae2f59df66 100644 > --- a/drivers/clk/at91/clk-main.c > +++ b/drivers/clk/at91/clk-main.c > @@ -437,12 +437,17 @@ static int clk_sam9x5_main_set_parent(struct clk_hw *hw, u8 index) > return -EINVAL; > > regmap_read(regmap, AT91_CKGR_MOR, &tmp); > - tmp &= ~MOR_KEY_MASK; > > if (index && !(tmp & AT91_PMC_MOSCSEL)) > - regmap_write(regmap, AT91_CKGR_MOR, tmp | AT91_PMC_MOSCSEL); > + tmp = AT91_PMC_MOSCSEL; > else if (!index && (tmp & AT91_PMC_MOSCSEL)) > - regmap_write(regmap, AT91_CKGR_MOR, tmp & ~AT91_PMC_MOSCSEL); > + tmp = 0; > + else > + return 0; > + > + regmap_update_bits(regmap, AT91_CKGR_MOR, > + AT91_PMC_MOSCSEL | MOR_KEY_MASK, > + tmp | AT91_PMC_KEY); > > while (!clk_sam9x5_main_ready(regmap)) > cpu_relax(); > -- > 2.7.4 > -- Alexandre Belloni, Bootlin Embedded Linux and Kernel engineering https://bootlin.com _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel