From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.5 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 9B3F6C433DF for ; Wed, 5 Aug 2020 08:49:31 +0000 (UTC) Received: from merlin.infradead.org (merlin.infradead.org [205.233.59.134]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 66AF021744 for ; Wed, 5 Aug 2020 08:49:31 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="cIYw41Jg" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 66AF021744 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=arm.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=merlin.20170209; h=Sender:Content-Transfer-Encoding: Content-Type:Cc:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References:Message-ID: Subject:To:From:Date:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=IgbzZ9r1FgUZdu8IiGwuPRnC/kMUh9f1PRExzWVsJNU=; b=cIYw41Jgoa4ov3N7H7cVu/u2t YHieJFmQQt+RTvWTCECb+qWYm0UfBf0NA2LjruyLbSWe/KVINr/iFK+RRdfwyPff0N2eHB9qNJmTl WxwhCLo6xygZjgUke7RzmT+NIEPzmkcJ3j7uCoaNB67rE4IY7+SJFzQLZVytH+KbpxTvQzFuyKS95 iAu29q35uVTBUeGpnR1fOkgkO4W6jsjbPL/eykjkir126i5AbutaAzRP9O6coxuf1xCfIEX0QoV16 4udGCXlVJS1GnVVaAT913wXLid8u8yIbIIbC86fmsWxpLGbJMmjeU2gO9gPrYhaWpOFdvmO/YyP97 oMtmhJK6Q==; Received: from localhost ([::1] helo=merlin.infradead.org) by merlin.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1k3F5r-00037d-B7; Wed, 05 Aug 2020 08:48:15 +0000 Received: from foss.arm.com ([217.140.110.172]) by merlin.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1k3F5o-00036q-9E for linux-arm-kernel@lists.infradead.org; Wed, 05 Aug 2020 08:48:13 +0000 Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id 273B7D6E; Wed, 5 Aug 2020 01:48:11 -0700 (PDT) Received: from bogus (unknown [10.37.12.53]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id 1750C3F6CF; Wed, 5 Aug 2020 01:48:08 -0700 (PDT) Date: Wed, 5 Aug 2020 09:47:57 +0100 From: Sudeep Holla To: Jason Liu Subject: Re: [PATCH 1/1] arm64: kexec: no need to do irq_chip->irq_mask if it already masked Message-ID: <20200805084748.GA4818@bogus> References: <20200804085657.10776-1-jason.hui.liu@nxp.com> <20200804113850.GB15199@bogus> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.9.4 (2018-02-28) X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20200805_044812_417050_F27F8100 X-CRM114-Status: GOOD ( 12.61 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: "sashal@kernel.org" , "catalin.marinas@arm.com" , Marc Zyngier , "linux-kernel@vger.kernel.org" , Sudeep Holla , "will@kernel.org" , "linux-arm-kernel@lists.infradead.org" Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Wed, Aug 05, 2020 at 06:31:20AM +0000, Jason Liu wrote: > > > > Indeed, the runtime PM ops in that driver looks dodgy. Any calls to mask_irq > > from drivers or anywhere with irqchip suspended with just blows up the > > system. > > If you look at the chip->irq_mask implementation on different platforms, almost > all with directly access the register of the irqchip including irqsteer. > There are fine due to driver will use the common mask_irq API. > That still doesn't explain how you can prevent system from blowing up if chip->irq_mask gets called with irqchip suspended ? -- Regards, Sudeep _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel