From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.5 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id ECADAC433DF for ; Wed, 5 Aug 2020 10:36:23 +0000 (UTC) Received: from merlin.infradead.org (merlin.infradead.org [205.233.59.134]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id B9E222173E for ; Wed, 5 Aug 2020 10:36:23 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="AcErJrsk" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org B9E222173E Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=arm.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=merlin.20170209; h=Sender:Content-Transfer-Encoding: Content-Type:Cc:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References:Message-ID: Subject:To:From:Date:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=rbL3W2Bu+2Ww0rjA260uVa/BGhe6KA4tQBDmNsbKI+4=; b=AcErJrskbYKajMhK+1km4jcJT fjMsBEFwQeEN3AR4lusTxYJLt+MEwB9Csj4Xu5e91p3+oHDjZeyptHRc+O2+gsB4qhCsAtE4/8POY nawkcdiMTgz4HKI4qCAr4fciR8kWoD5le7rP2AHl3/1mHN91n1w3UlaepnAO8NPUy714qu8yGCAIx vjiMQ/hqTWyJswn9WzYXd+T9VoLUtIgyKU4YvKOXu94Yhp5BTzYzItSw7+xEyrtPrR71bsYtX6ZCJ mt+YOCJTJzxHbWN1TZnNp8pekBPXYUPWxHeFw4vmTz2DE7edEMxVnXBwjqqHBpeaYBsbRuIsi0o3P DwxkH15KQ==; Received: from localhost ([::1] helo=merlin.infradead.org) by merlin.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1k3GlL-0008RW-7D; Wed, 05 Aug 2020 10:35:11 +0000 Received: from foss.arm.com ([217.140.110.172]) by merlin.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1k3GlJ-0008R5-By for linux-arm-kernel@lists.infradead.org; Wed, 05 Aug 2020 10:35:10 +0000 Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id 1F4401FB; Wed, 5 Aug 2020 03:35:07 -0700 (PDT) Received: from localhost (e108754-lin.cambridge.arm.com [10.1.198.53]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id B26013FA32; Wed, 5 Aug 2020 03:35:06 -0700 (PDT) Date: Wed, 5 Aug 2020 11:35:05 +0100 From: Ionela Voinescu To: Viresh Kumar Subject: Re: [PATCH v2 2/7] cpufreq: set invariance scale factor on transition end Message-ID: <20200805103452.GA4817@arm.com> References: <20200722093732.14297-1-ionela.voinescu@arm.com> <20200722093732.14297-3-ionela.voinescu@arm.com> <20200730041334.cjg5mc5xpopd2lst@vireshk-mac-ubuntu> <20200803135838.GB9512@arm.com> <20200804062611.6jpra73hmhybdw3i@vireshk-mac-ubuntu> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20200804062611.6jpra73hmhybdw3i@vireshk-mac-ubuntu> User-Agent: Mutt/1.9.4 (2018-02-28) X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20200805_063509_468815_9CB903CD X-CRM114-Status: GOOD ( 20.52 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: linux-pm@vger.kernel.org, peterz@infradead.org, catalin.marinas@arm.com, rjw@rjwysocki.net, linux@armlinux.org.uk, linux-kernel@vger.kernel.org, mingo@redhat.com, sudeep.holla@arm.com, will@kernel.org, dietmar.eggemann@arm.com, linux-arm-kernel@lists.infradead.org Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Tuesday 04 Aug 2020 at 11:56:11 (+0530), Viresh Kumar wrote: [..] > > > > - In __target_index(), cpufreq_freq_transition_end() is called only for > > > > drivers that have synchronous notifications enabled. There is only one > > > > driver that disables them, > > > > > > > > drivers/cpufreq/powernow-k8.c:1142: .flags = CPUFREQ_ASYNC_NOTIFICATION, > > > > > > > > which is deprecated. > > > > > > I don't think this is deprecated. > > Heh, maybe I misunderstood. I thought you are talking about the flag, > while you were talking about the driver. > > > Sorry, possibly 'deprecated' is a strong word. > > > > As far as I knew acpi_cpufreq was recommended more recently for K8/K10 > > CPUs so that's why I decided not to create a special case for it, also > > considering that it was not supporting cpufreq-based frequency > > invariance to begin with. > > > > We could support this as well by having a call to arch_set_freq_scale() > > on the else path in __target_index(). But given that there was only this > > one user of CPUFREQ_ASYNC_NOTIFICATION, I thought I'd propose this simpler > > version first. > > > > Let me know if my reasoning is wrong. > > Nevertheless, I don't think you need to mention this detail in > changelog for powernow-k8 as cpufreq_freq_transition_end() does get > called for it as well, by the driver instead of the core. > Agreed! Many thanks, Ionela. > -- > viresh _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel