From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.5 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 3291EC433DF for ; Wed, 5 Aug 2020 10:36:52 +0000 (UTC) Received: from merlin.infradead.org (merlin.infradead.org [205.233.59.134]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id F26C020792 for ; Wed, 5 Aug 2020 10:36:51 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="Tr7B0C5B" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org F26C020792 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=arm.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=merlin.20170209; h=Sender:Content-Transfer-Encoding: Content-Type:Cc:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References:Message-ID: Subject:To:From:Date:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=xEV6nme+x1WVBoe/oJOrRolHPDbIsBIpMXMyecivLQ4=; b=Tr7B0C5BdWheGsxOBaqwWp4E8 woHk3MU7Qb43Us1KbQ1QZN7hYagk1EF7JJvQbPEnt83nSNzAxtXG5CM//DPf2AZ0s3XETGCt5RI19 elfZtKQLDgdsXzCQpPbBqtOs412iF+d0Hkd3ho2zQmXFhU/U61pvb2JGGyyhknc6JQ1aI9Ah0/AW6 Bx2bHpXz86jXSzb/bs4IIRFqNvop0bIJP5oob84ZjLJNaaJAiJ4RsWzn72cjKItTw9wACqJdJaAuZ TsB5anZ1f76yVawaHz3AhX4XL+yyZJJnXQjvLhuebbvtFw2OYgme5vdTPtqAaZ40x+7q53kyclqqg uuzzb8Uxg==; Received: from localhost ([::1] helo=merlin.infradead.org) by merlin.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1k3Gll-00005g-Tb; Wed, 05 Aug 2020 10:35:38 +0000 Received: from foss.arm.com ([217.140.110.172]) by merlin.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1k3Gli-0008WF-Lu for linux-arm-kernel@lists.infradead.org; Wed, 05 Aug 2020 10:35:35 +0000 Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id 01926D6E; Wed, 5 Aug 2020 03:35:33 -0700 (PDT) Received: from localhost (e108754-lin.cambridge.arm.com [10.1.198.53]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id 97E053FA32; Wed, 5 Aug 2020 03:35:32 -0700 (PDT) Date: Wed, 5 Aug 2020 11:35:31 +0100 From: Ionela Voinescu To: Viresh Kumar Subject: Re: [PATCH v2 4/7] cpufreq: report whether cpufreq supports Frequency Invariance (FI) Message-ID: <20200805103531.GB4817@arm.com> References: <20200722093732.14297-1-ionela.voinescu@arm.com> <20200722093732.14297-5-ionela.voinescu@arm.com> <20200730044346.rgtaikotkgwdpc3m@vireshk-mac-ubuntu> <20200803152400.GB20312@arm.com> <20200804064656.h25yapthuumdxjw7@vireshk-mac-ubuntu> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20200804064656.h25yapthuumdxjw7@vireshk-mac-ubuntu> User-Agent: Mutt/1.9.4 (2018-02-28) X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20200805_063534_823062_A618481E X-CRM114-Status: GOOD ( 17.82 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: linux-pm@vger.kernel.org, peterz@infradead.org, catalin.marinas@arm.com, rjw@rjwysocki.net, linux@armlinux.org.uk, linux-kernel@vger.kernel.org, mingo@redhat.com, sudeep.holla@arm.com, will@kernel.org, dietmar.eggemann@arm.com, linux-arm-kernel@lists.infradead.org Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Tuesday 04 Aug 2020 at 12:16:56 (+0530), Viresh Kumar wrote: > On 03-08-20, 16:24, Ionela Voinescu wrote: > > Right, cpufreq_register_driver() should check that at least one of them > > is present > > > (although currently cpufreq_register_driver() will return > > -EINVAL if .fast_switch() alone is present - something to be fixed). > > I think it is fine as there is no guarantee from cpufreq core if > .fast_switch() will get called and so target/target_index must be > present. We can't do fast-switch today without schedutil (as only that > enables it) and if a notifier gets registered before the driver, then > we are gone again. > > > Will do, on both accounts. > > > > > > > > + static_branch_enable_cpuslocked(&cpufreq_set_freq_scale); > > > > + pr_debug("%s: Driver %s can provide frequency invariance.", > > > > + __func__, driver->name); > > > > > > I think a simpler print will work well too. > > > > > > pr_debug("Freq invariance enabled"); > > > > > > > I think the right way of reporting this support is important here. > > Yeah, we can't say it is enabled as you explained, though I meant > something else here then, i.e. getting rid of driver name and > unimportant stuff. What about this now: > > pr_debug("supports frequency invariance"); > > This shall get printed as this finally: > > cpufreq: supports frequency invariance > Will do! Thanks, Ionela. > -- > viresh _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel