From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.5 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS, URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id B4CB4C433E0 for ; Wed, 5 Aug 2020 10:52:31 +0000 (UTC) Received: from merlin.infradead.org (merlin.infradead.org [205.233.59.134]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 804212250E for ; Wed, 5 Aug 2020 10:52:31 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="j9/9Rnoq"; dkim=fail reason="signature verification failed" (1024-bit key) header.d=kernel.org header.i=@kernel.org header.b="Tz9/O3Mw" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 804212250E Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=kernel.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=merlin.20170209; h=Sender:Content-Type:Cc: List-Subscribe:List-Help:List-Post:List-Archive:List-Unsubscribe:List-Id: In-Reply-To:MIME-Version:References:Message-ID:Subject:To:From:Date:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=fY81YZ6tAPjJcqu7/Lhu0xJrCbA8nQfkjnSrdzL4w70=; b=j9/9Rnoq+Nm7qtog9sPDn4TPv mO6iQVmg0dvBVTccER9jApMfJNUdE0dW+V0ayVtwh3zd7wgRBExqyNrKjdglqRxIq+BW6ca/+bv2d SiL1gd+1xADRQiGpEGG8SDu1OWhOlLuic+7xrdBYJk7hw93nJLgQVlPmzXpugO5UMfgcINjPgJH+x ySbL9MAmvfgEV9/DvmYa2PV1nYy61etOj9yoTxmogx0ZQp1tj3bqkChBbDZxLS5D8lcHfNUV6jsih fZeQJSmUrgRbTnsE5ESBgAyLG66VmuMvt678g8w/bqyH1ueJFyivxL2fa3/4Eib2qzltCt0p4ta13 W8Chc+LbA==; Received: from localhost ([::1] helo=merlin.infradead.org) by merlin.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1k3H17-0001We-5t; Wed, 05 Aug 2020 10:51:29 +0000 Received: from mail.kernel.org ([198.145.29.99]) by merlin.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1k3H15-0001W9-MJ for linux-arm-kernel@lists.infradead.org; Wed, 05 Aug 2020 10:51:28 +0000 Received: from localhost (fw-tnat.cambridge.arm.com [217.140.96.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 616D7207FC; Wed, 5 Aug 2020 10:51:26 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1596624686; bh=x3ZHXxquKDbAiA2NrYdhb8ekIS3wwnWPgFDvfXsCgjQ=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=Tz9/O3MwNWVUjnDemRDBvIBHLVnCwzcZU9KwGVAfLwJL9klqT5BXqz1Xdd8jPqNwM JihxqNRzl/tuH3X1xIDDy5h7jYfjdribFzyTkod95UguTpz2DDZsDpOs0iFqDPn3aZ SwLoSRPWz174jubsykqQiQ8naeWwRJ0IJ1ilLquY= Date: Wed, 5 Aug 2020 11:51:04 +0100 From: Mark Brown To: Alain Volmat Subject: Re: [PATCH 03/18] spi: stm32h7: remove unused mode fault MODF event handling Message-ID: <20200805105104.GC5556@sirena.org.uk> References: <1596610933-32599-1-git-send-email-alain.volmat@st.com> <1596610933-32599-4-git-send-email-alain.volmat@st.com> MIME-Version: 1.0 In-Reply-To: <1596610933-32599-4-git-send-email-alain.volmat@st.com> X-Cookie: Fast, cheap, good: pick two. User-Agent: Mutt/1.10.1 (2018-07-13) X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20200805_065127_809231_496DACFD X-CRM114-Status: GOOD ( 18.10 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: amelie.delaunay@st.com, alexandre.torgue@st.com, linux-kernel@vger.kernel.org, linux-spi@vger.kernel.org, mcoquelin.stm32@gmail.com, fabrice.gasnier@st.com, linux-stm32@st-md-mailman.stormreply.com, linux-arm-kernel@lists.infradead.org Content-Type: multipart/mixed; boundary="===============0015957647157862114==" Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org --===============0015957647157862114== Content-Type: multipart/signed; micalg=pgp-sha512; protocol="application/pgp-signature"; boundary="4jXrM3lyYWu4nBt5" Content-Disposition: inline --4jXrM3lyYWu4nBt5 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline On Wed, Aug 05, 2020 at 09:01:58AM +0200, Alain Volmat wrote: > From: Antonio Borneo > Accordingly to STM32H7 document RM0433, "mode fault" MODF is > a special mode to handle a spi bus with multiple masters, in > which each master has to "detect" if another master enables > its CS to take control of the bus. Once this is detected, > all other masters has to temporarily switch to "slave" mode. > Such multi-master mode is not supported in Linux and this > driver properly disables the mode by setting the bits > SPI_CR1_SSI and SPI_CFG2_SSM, thus forcing a master only > operating mode. > In this condition, we will never receive an interrupt due to > MODF event and we do not need to handle it. > Remove all the unused code around handling MODF events. What does having this cost us? Hopefully it's not doing much but if something goes wrong with the hardware and this does get flagged up for some reason it'd be good to know about it. It doesn't seem to be having a big impact on the code or anything. --4jXrM3lyYWu4nBt5 Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQEzBAABCgAdFiEEreZoqmdXGLWf4p/qJNaLcl1Uh9AFAl8qjxcACgkQJNaLcl1U h9C+kAf8CK9hJ/6Jc4BQ05hn0nAaypIJAYNq1bv8lExUjoH1m3AeiTfTBbh8Aq25 W/1u3hhb83akhry/0vcVC2vSF5UGKInNhyeb6FRRoqUaiBD2krRo55ZDgmYeD7Ta F34U8K3C4QbYMpQeKO5ceuZZOadkfjxKrgX4h+ZkFwGXaUn8tIGN9MDZLKyQ85md ecRl77X3Wt9kX9OxEml6f5UFJvbaVA//arSxikBmyBnFDAe4udEu9PVXHtdJ1pNy jvw6E20aw6tBoteFTfL1iv36f8kImbVrjGWJjgHEUu2ujyEgQgJfg9xrU3wWIykr OlTao50KMlI4sHvYI2leN01XzXGJdA== =gL3F -----END PGP SIGNATURE----- --4jXrM3lyYWu4nBt5-- --===============0015957647157862114== Content-Type: text/plain; charset="us-ascii" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Content-Disposition: inline _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel --===============0015957647157862114==--