From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.5 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS, URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id B3158C433E0 for ; Wed, 5 Aug 2020 10:55:43 +0000 (UTC) Received: from merlin.infradead.org (merlin.infradead.org [205.233.59.134]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 81C4B2250E for ; Wed, 5 Aug 2020 10:55:43 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="fVEaHmqT"; dkim=fail reason="signature verification failed" (1024-bit key) header.d=kernel.org header.i=@kernel.org header.b="daILxyCw" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 81C4B2250E Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=kernel.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=merlin.20170209; h=Sender:Content-Type:Cc: List-Subscribe:List-Help:List-Post:List-Archive:List-Unsubscribe:List-Id: In-Reply-To:MIME-Version:References:Message-ID:Subject:To:From:Date:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=scaUXNDRV1GECudJtd5FmhHR1ytNV7veTXqzwJPVmZQ=; b=fVEaHmqTdyREpBGTz2dTnBzIp NvmZmWnp3DiI8Qb7qmznoVYt7gouQKnmo73sLXIJMaX6dtUTta+b2PCb0mMJ/NuEPRyALZoFkGIvJ ff7yh5HC3lx5CtzCyyLnAiMologqHndjb0TVZgFuKliCcyXyoD5n/S1Uzx2jQsGKN9rxj1+RLk157 25VXDvSHNjI7uPg9v/lh+wjqPqgQDs7VbBnAh33xd/+9vLINSpA6tVQWttoymp65m+QEP4uTRL4/Q f8nY8dKds73vRU/w/4e7wVGOuNbK8n/8/j5fqMTlQ7CRCSJwsF+DDT+90vFjz7Q+8ioB5G1PPTzIa h8Y+GtbfQ==; Received: from localhost ([::1] helo=merlin.infradead.org) by merlin.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1k3H3w-0002KB-Nn; Wed, 05 Aug 2020 10:54:24 +0000 Received: from mail.kernel.org ([198.145.29.99]) by merlin.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1k3H3t-0002Iq-9l for linux-arm-kernel@lists.infradead.org; Wed, 05 Aug 2020 10:54:22 +0000 Received: from localhost (fw-tnat.cambridge.arm.com [217.140.96.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id E99452173E; Wed, 5 Aug 2020 10:54:19 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1596624860; bh=itzMvNq8nfgP8VKXOJXPOoZfq8+Pd5YP4oo6JUWZy/Q=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=daILxyCwv0M7mQeyhNXxvi03DAUtga5jJtqn9dQXwRgrXBcNva8DPZDusD/aFamB8 Au9mHe9ABAS9MqqceMBsO7YPBu1LumIOWL9uh+TWE/OO/RKyxryVA4IqaKwGaUH9uK 2Cbco3etFIjw9O/v4cujAsyuMP3cTEND8YVamfgM= Date: Wed, 5 Aug 2020 11:53:57 +0100 From: Mark Brown To: Alain Volmat Subject: Re: [PATCH 09/18] spi: stm32h7: fix race condition at end of transfer Message-ID: <20200805105357.GD5556@sirena.org.uk> References: <1596610933-32599-1-git-send-email-alain.volmat@st.com> <1596610933-32599-10-git-send-email-alain.volmat@st.com> MIME-Version: 1.0 In-Reply-To: <1596610933-32599-10-git-send-email-alain.volmat@st.com> X-Cookie: Fast, cheap, good: pick two. User-Agent: Mutt/1.10.1 (2018-07-13) X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20200805_065421_998714_3BC5D73F X-CRM114-Status: GOOD ( 16.31 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: amelie.delaunay@st.com, alexandre.torgue@st.com, linux-kernel@vger.kernel.org, linux-spi@vger.kernel.org, mcoquelin.stm32@gmail.com, fabrice.gasnier@st.com, linux-stm32@st-md-mailman.stormreply.com, linux-arm-kernel@lists.infradead.org Content-Type: multipart/mixed; boundary="===============2885210228756091653==" Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org --===============2885210228756091653== Content-Type: multipart/signed; micalg=pgp-sha512; protocol="application/pgp-signature"; boundary="3Gf/FFewwPeBMqCJ" Content-Disposition: inline --3Gf/FFewwPeBMqCJ Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Wed, Aug 05, 2020 at 09:02:04AM +0200, Alain Volmat wrote: > From: Antonio Borneo >=20 > The caller of stm32_spi_transfer_one(), spi_transfer_one_message(), > is waiting for us to call spi_finalize_current_transfer() and will > eventually schedule a new transfer, if available. > We should guarantee that the spi controller is really available > before calling spi_finalize_current_transfer(). >=20 > Move the call to spi_finalize_current_transfer() _after_ the call > to stm32_spi_disable(). This seems like a bug fix and should therefore be at the start of the series so it can be sent to mainline without the new development work. --3Gf/FFewwPeBMqCJ Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQEzBAABCgAdFiEEreZoqmdXGLWf4p/qJNaLcl1Uh9AFAl8qj8UACgkQJNaLcl1U h9BPMwf/SVAa/tykTrFSDmtKpWBCSoTEQyhwBfjKuq+rQf3+01Akz63PIPooThf4 4hcsMCzyVNfFiNhOCvCyeK5ccZ3iJ6ZX+CBzIp82qadb35VN1MNxMVwHPy2kshTW 8S+oKpDXRIFEiuKmDTBW22swtHCy8m01Ng4gQXvQPBhdjIpff4sl/kAMBxPRUFBS TjkRi39WPFNwmRWRBrAxa99mmyOt0+83zOs0jjLRRJADsfoIaDdkISbFGJ517Wh1 10XUqNK0kNJC8hqj6rK7jgkgQeMW3vAQaimhlJzFbnjVOgtiW74zF03RPmxM1w6V R+0IRfA+AzMkXP1gTek7e+vjuBraaQ== =4szv -----END PGP SIGNATURE----- --3Gf/FFewwPeBMqCJ-- --===============2885210228756091653== Content-Type: text/plain; charset="us-ascii" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Content-Disposition: inline _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel --===============2885210228756091653==--