From: Vinod Koul <vkoul@kernel.org>
To: Peter Ujfalusi <peter.ujfalusi@ti.com>
Cc: grygorii.strashko@ti.com, santosh.shilimkar@oracle.com,
linux-kernel@vger.kernel.org, ssantosh@kernel.org,
dmaengine@vger.kernel.org, linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH] dmaengine: ti: k3-udma-glue: Fix parameters for rx ring pair request
Date: Wed, 5 Aug 2020 17:02:37 +0530 [thread overview]
Message-ID: <20200805113237.GX12965@vkoul-mobl> (raw)
In-Reply-To: <20200805112746.15475-1-peter.ujfalusi@ti.com>
On 05-08-20, 14:27, Peter Ujfalusi wrote:
> The original commit mixed up the forward and completion ring IDs for the
> rx flow configuration.
Acked-By: Vinod Koul <vkoul@kernel.org>
>
> Fixes: 4927b1ab2047 ("dmaengine: ti: k3-udma: Switch to k3_ringacc_request_rings_pair")
> Signed-off-by: Peter Ujfalusi <peter.ujfalusi@ti.com>
> ---
> Hi Santosh, Vinod,
>
> the offending patch was queued via ti SoC tree.
> Santosh, can you pick up this fix also?
>
> Regards,
> Peter
>
> drivers/dma/ti/k3-udma-glue.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/dma/ti/k3-udma-glue.c b/drivers/dma/ti/k3-udma-glue.c
> index 3a5d33ea5ebe..12da38a92218 100644
> --- a/drivers/dma/ti/k3-udma-glue.c
> +++ b/drivers/dma/ti/k3-udma-glue.c
> @@ -579,8 +579,8 @@ static int k3_udma_glue_cfg_rx_flow(struct k3_udma_glue_rx_channel *rx_chn,
>
> /* request and cfg rings */
> ret = k3_ringacc_request_rings_pair(rx_chn->common.ringacc,
> - flow_cfg->ring_rxq_id,
> flow_cfg->ring_rxfdq0_id,
> + flow_cfg->ring_rxq_id,
> &flow->ringrxfdq,
> &flow->ringrx);
> if (ret) {
> --
> Peter
>
> Texas Instruments Finland Oy, Porkkalankatu 22, 00180 Helsinki.
> Y-tunnus/Business ID: 0615521-4. Kotipaikka/Domicile: Helsinki
--
~Vinod
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
next prev parent reply other threads:[~2020-08-05 11:34 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-08-05 11:27 [PATCH] dmaengine: ti: k3-udma-glue: Fix parameters for rx ring pair request Peter Ujfalusi
2020-08-05 11:32 ` Vinod Koul [this message]
2020-08-05 13:17 ` Grygorii Strashko
2020-08-06 17:58 ` santosh.shilimkar
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200805113237.GX12965@vkoul-mobl \
--to=vkoul@kernel.org \
--cc=dmaengine@vger.kernel.org \
--cc=grygorii.strashko@ti.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=peter.ujfalusi@ti.com \
--cc=santosh.shilimkar@oracle.com \
--cc=ssantosh@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox