From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-7.0 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE, SPF_PASS,URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 9BB94C433DF for ; Wed, 5 Aug 2020 13:20:44 +0000 (UTC) Received: from merlin.infradead.org (merlin.infradead.org [205.233.59.134]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 5E79C22CA1 for ; Wed, 5 Aug 2020 13:20:44 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="wllXr59E"; dkim=fail reason="signature verification failed" (1024-bit key) header.d=kernel.org header.i=@kernel.org header.b="RZK5/PZX" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 5E79C22CA1 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=kernel.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=merlin.20170209; h=Sender:Content-Transfer-Encoding: Content-Type:Cc:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References:Message-ID: Subject:To:From:Date:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=pQ8t9Vw3pjJFhJXBsnqV289GdNVm9IACGRH525NaUvk=; b=wllXr59ERytp0LJyWNq4DsuLy gP0oYIhjsVnNYht5V1va29YFIJULOvHvhXJIRgP7hexxUPSmAAI5y5bWCtW45HuQ8H+MbQ18qA9P0 U1j0i+i0IltSTCxH3oYCrHi/6b/NnjZTA2jteiRrCELG90qOofoNEbTpvYdkREXf8eSwdCPwznwTZ x9The1sBUeS8sW5Wvk51EfNBk64KNHVy6vzzavbpHQCBCtE18kp461jSbh0K0YfYxCzW3vyl6vQlQ hFTdl7EZdN33OTnyQ/EYZuumdJ4EYUSfd7g91mzzXiw2SyUnd1B3oJTt9eWOC/ZlblCtgYboEAKLW he7cvfkwA==; Received: from localhost ([::1] helo=merlin.infradead.org) by merlin.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1k3JKN-0003kf-57; Wed, 05 Aug 2020 13:19:31 +0000 Received: from mail.kernel.org ([198.145.29.99]) by merlin.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1k3JKK-0003jv-C4 for linux-arm-kernel@lists.infradead.org; Wed, 05 Aug 2020 13:19:29 +0000 Received: from localhost (unknown [122.171.202.192]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 0BEA822D75; Wed, 5 Aug 2020 13:19:25 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1596633566; bh=3MsIB79zBI0fO6hFED+2PELXN5lzdVBWP95KH0wBH9I=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=RZK5/PZXQyb5E2xDXei3LEsgNsjsWbhsLQmYNpOCHlPpt0GCwrSwYNqCYvD4kfeIP Hbpk+HWDzMbC0+cK8xnUE31SqMuhCjoSMDTuv+MHlP37YeDKS4CJVRAzciNnNhNaCk ptJnG0ENBNRlSaZjIhOZo9NHqiG1R18UllMX4O+k= Date: Wed, 5 Aug 2020 18:49:22 +0530 From: Vinod Koul To: "Gustavo A. R. Silva" Subject: Re: [PATCH][next] dmaengine: Use fallthrough pseudo-keyword Message-ID: <20200805131922.GZ12965@vkoul-mobl> References: <20200727203413.GA6245@embeddedor> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20200727203413.GA6245@embeddedor> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20200805_091928_743271_A3D29E63 X-CRM114-Status: GOOD ( 12.12 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Song Liu , Alexei Starovoitov , Shawn Guo , Fabio Estevam , Daniel Borkmann , John Fastabend , Zhang Wei , NXP Linux Team , Yonghong Song , Andrii Nakryiko , Sascha Hauer , KP Singh , Dan Williams , linux-arm-kernel@lists.infradead.org, netdev@vger.kernel.org, linux-kernel@vger.kernel.org, Li Yang , Pengutronix Kernel Team , dmaengine@vger.kernel.org, bpf@vger.kernel.org, linuxppc-dev@lists.ozlabs.org, Martin KaFai Lau Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On 27-07-20, 15:34, Gustavo A. R. Silva wrote: > diff --git a/drivers/dma/pl330.c b/drivers/dma/pl330.c > index 2c508ee672b9..9b69716172a4 100644 > --- a/drivers/dma/pl330.c > +++ b/drivers/dma/pl330.c > @@ -1061,16 +1061,16 @@ static bool _start(struct pl330_thread *thrd) > > if (_state(thrd) == PL330_STATE_KILLING) > UNTIL(thrd, PL330_STATE_STOPPED) > - /* fall through */ > + fallthrough; > > case PL330_STATE_FAULTING: > _stop(thrd); > - /* fall through */ > + fallthrough; > > case PL330_STATE_KILLING: > case PL330_STATE_COMPLETING: > UNTIL(thrd, PL330_STATE_STOPPED) > - /* fall through */ > + fallthrough; > > case PL330_STATE_STOPPED: > return _trigger(thrd); > @@ -1121,7 +1121,6 @@ static u32 _emit_load(unsigned int dry_run, u8 buf[], > > switch (direction) { > case DMA_MEM_TO_MEM: > - /* fall through */ > case DMA_MEM_TO_DEV: > off += _emit_LD(dry_run, &buf[off], cond); > break; > @@ -1155,7 +1154,6 @@ static inline u32 _emit_store(unsigned int dry_run, u8 buf[], > > switch (direction) { > case DMA_MEM_TO_MEM: > - /* fall through */ > case DMA_DEV_TO_MEM: > off += _emit_ST(dry_run, &buf[off], cond); > break; > @@ -1216,7 +1214,6 @@ static int _bursts(struct pl330_dmac *pl330, unsigned dry_run, u8 buf[], > > switch (pxs->desc->rqtype) { > case DMA_MEM_TO_DEV: > - /* fall through */ > case DMA_DEV_TO_MEM: > off += _ldst_peripheral(pl330, dry_run, &buf[off], pxs, cyc, > cond); > @@ -1266,7 +1263,6 @@ static int _dregs(struct pl330_dmac *pl330, unsigned int dry_run, u8 buf[], > > switch (pxs->desc->rqtype) { > case DMA_MEM_TO_DEV: > - /* fall through */ replacement missed here and above few -- ~Vinod _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel