From: Tingwei Zhang <tingweiz@codeaurora.org>
To: Suzuki K Poulose <suzuki.poulose@arm.com>
Cc: tsoni@codeaurora.org, saiprakash.ranjan@codeaurora.org,
kim.phillips@arm.com, mathieu.poirier@linaro.org,
alexander.shishkin@linux.intel.com, gregkh@linuxfoundation.org,
coresight@lists.linaro.org, rdunlap@infradead.org,
ykaukab@suse.de, linux@armlinux.org.uk, jinlmao@codeaurora.org,
tingwei@codeaurora.org, leo.yan@linaro.org,
linux-arm-kernel@lists.infradead.org, mike.leach@linaro.org
Subject: Re: [PATCH v7 08/25] coresight: etm: perf: Fix warning caused by etm_setup_aux failure
Date: Thu, 6 Aug 2020 10:46:27 +0800 [thread overview]
Message-ID: <20200806024627.GC10121@codeaurora.org> (raw)
In-Reply-To: <c7dcf2d4-f7f5-30e7-d89e-a98c2de64b2a@arm.com>
On Wed, Aug 05, 2020 at 06:18:35PM +0800, Suzuki K Poulose wrote:
> On 08/05/2020 03:54 AM, Tingwei Zhang wrote:
> >When coresight_build_path() fails on all the cpus, etm_setup_aux
> >calls etm_free_aux() to free allocated event_data.
> >WARN_ON(cpumask_empty(mask) will be triggered since cpu mask is empty.
> >Check event_data->snk_config is not NULL first to avoid this
> >warning.
> >
> >Signed-off-by: Tingwei Zhang <tingwei@codeaurora.org>
> >Reviewed-by: Mike Leach <mike.leach@linaro.org>
>
> Please could you added a Fixes tag for this ?
>
> Fixes: f5200aa9831f38 ("coresight: perf: Refactor function
> free_event_data()")
>
I'll add Fixes tag.
Thanks,
Tingwei
> Reviewed-by: Suzuki K Poulose <suzuki.poulose@arm.com>
>
> >---
> > drivers/hwtracing/coresight/coresight-etm-perf.c | 4 ++--
> > 1 file changed, 2 insertions(+), 2 deletions(-)
> >
> >diff --git a/drivers/hwtracing/coresight/coresight-etm-perf.c
> >b/drivers/hwtracing/coresight/coresight-etm-perf.c
> >index dcb0592418ae..3728c44e5763 100644
> >--- a/drivers/hwtracing/coresight/coresight-etm-perf.c
> >+++ b/drivers/hwtracing/coresight/coresight-etm-perf.c
> >@@ -126,10 +126,10 @@ static void free_sink_buffer(struct etm_event_data
> >*event_data)
> > cpumask_t *mask = &event_data->mask;
> > struct coresight_device *sink;
> >
> >- if (WARN_ON(cpumask_empty(mask)))
> >+ if (!event_data->snk_config)
> > return;
> >
> >- if (!event_data->snk_config)
> >+ if (WARN_ON(cpumask_empty(mask)))
> > return;
>
>
> >
> > cpu = cpumask_first(mask);
> >
>
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
next prev parent reply other threads:[~2020-08-06 2:48 UTC|newest]
Thread overview: 63+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-08-05 2:54 [PATCH v7 00/25] coresight: allow to build coresight as modules Tingwei Zhang
2020-08-05 2:54 ` [PATCH v7 01/25] coresight: cpu_debug: add module name in Kconfig Tingwei Zhang
2020-08-05 9:46 ` Suzuki K Poulose
2020-08-05 2:54 ` [PATCH v7 02/25] coresight: cpu_debug: define MODULE_DEVICE_TABLE Tingwei Zhang
2020-08-05 2:54 ` [PATCH v7 03/25] coresight: use IS_ENABLED for CONFIGs that may be modules Tingwei Zhang
2020-08-05 2:54 ` [PATCH v7 04/25] coresight: add coresight prefix to barrier_pkt Tingwei Zhang
2020-08-05 2:54 ` [PATCH v7 05/25] coresight: export global symbols Tingwei Zhang
2020-08-05 11:13 ` Suzuki K Poulose
2020-08-06 1:43 ` Tingwei Zhang
2020-08-05 2:54 ` [PATCH v7 06/25] coresight: add try_get_module() in coresight_grab_device() Tingwei Zhang
2020-08-05 10:55 ` Suzuki K Poulose
2020-08-06 2:43 ` Tingwei Zhang
2020-08-05 2:54 ` [PATCH v7 07/25] coresight: stm: allow to build coresight-stm as a module Tingwei Zhang
2020-08-05 11:00 ` Suzuki K Poulose
2020-08-05 2:54 ` [PATCH v7 08/25] coresight: etm: perf: Fix warning caused by etm_setup_aux failure Tingwei Zhang
2020-08-05 10:18 ` Suzuki K Poulose
2020-08-06 2:46 ` Tingwei Zhang [this message]
2020-08-05 2:54 ` [PATCH v7 09/25] coresight: etm3x: allow etm3x to be built as a module Tingwei Zhang
2020-08-05 11:09 ` Suzuki K Poulose
2020-08-05 12:54 ` Mike Leach
2020-08-05 14:58 ` Suzuki K Poulose
2020-08-06 5:44 ` Sai Prakash Ranjan
2020-08-06 11:43 ` Tingwei Zhang
2020-08-05 2:54 ` [PATCH v7 10/25] coresight: etm4x: allow etm4x " Tingwei Zhang
2020-08-05 11:27 ` Suzuki K Poulose
2020-08-05 2:54 ` [PATCH v7 11/25] coresight: etb: allow etb " Tingwei Zhang
2020-08-05 15:43 ` Suzuki K Poulose
2020-08-06 11:19 ` Tingwei Zhang
2020-08-06 14:56 ` Suzuki K Poulose
2020-08-07 1:56 ` Tingwei Zhang
2020-08-05 2:54 ` [PATCH v7 12/25] coresight: tpiu: allow tpiu " Tingwei Zhang
2020-08-05 15:47 ` Suzuki K Poulose
2020-08-05 2:54 ` [PATCH v7 13/25] coresight: tmc: allow tmc " Tingwei Zhang
2020-08-05 15:49 ` Suzuki K Poulose
2020-08-06 14:58 ` Suzuki K Poulose
2020-08-05 2:54 ` [PATCH v7 14/25] coresight: funnel: remove multiple init calls from funnel driver Tingwei Zhang
2020-08-05 2:54 ` [PATCH v7 15/25] coresight: replicator: remove multiple init calls Tingwei Zhang
2020-08-05 2:54 ` [PATCH v7 16/25] coresight: allow funnel and replicator drivers to be built as modules Tingwei Zhang
2020-08-05 16:04 ` Suzuki K Poulose
2020-08-06 2:55 ` Tingwei Zhang
2020-08-05 2:54 ` [PATCH v7 17/25] coresight: cti: add function to register cti associate ops Tingwei Zhang
2020-08-05 2:54 ` [PATCH v7 18/25] coresight: cti: Fix remove sysfs link error Tingwei Zhang
2020-08-05 2:54 ` [PATCH v7 19/25] coresight: cti: Fix bug clearing sysfs links on callback Tingwei Zhang
2020-08-06 16:21 ` Suzuki K Poulose
2020-08-05 2:54 ` [PATCH v7 20/25] coresight: cti: don't disable ect device if it's not enabled Tingwei Zhang
2020-08-05 2:54 ` [PATCH v7 21/25] coresight: cti: increase reference count when enabling cti Tingwei Zhang
2020-08-05 2:54 ` [PATCH v7 22/25] coresight: cti: allow cti to be built as a module Tingwei Zhang
2020-08-05 2:54 ` [PATCH v7 23/25] coresight: tmc-etr: add function to register catu ops Tingwei Zhang
2020-08-05 16:09 ` Suzuki K Poulose
2020-08-05 16:11 ` Suzuki K Poulose
2020-08-05 2:54 ` [PATCH v7 24/25] coresight: catu: allow catu drivers to be built as modules Tingwei Zhang
2020-08-05 16:11 ` Suzuki K Poulose
2020-08-05 2:54 ` [PATCH v7 25/25] coresight: allow the coresight core driver to be built as a module Tingwei Zhang
2020-08-05 16:29 ` Suzuki K Poulose
2020-08-06 16:33 ` Suzuki K Poulose
2020-08-06 17:25 ` Robin Murphy
2020-08-06 17:39 ` Robin Murphy
2020-08-06 22:20 ` Suzuki K Poulose
2020-08-05 17:17 ` [PATCH v7 00/25] coresight: allow to build coresight as modules Suzuki K Poulose
2020-08-05 19:39 ` Mike Leach
2020-08-06 3:06 ` Tingwei Zhang
2020-08-06 9:38 ` Mike Leach
2020-08-06 11:23 ` Suzuki K Poulose
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200806024627.GC10121@codeaurora.org \
--to=tingweiz@codeaurora.org \
--cc=alexander.shishkin@linux.intel.com \
--cc=coresight@lists.linaro.org \
--cc=gregkh@linuxfoundation.org \
--cc=jinlmao@codeaurora.org \
--cc=kim.phillips@arm.com \
--cc=leo.yan@linaro.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux@armlinux.org.uk \
--cc=mathieu.poirier@linaro.org \
--cc=mike.leach@linaro.org \
--cc=rdunlap@infradead.org \
--cc=saiprakash.ranjan@codeaurora.org \
--cc=suzuki.poulose@arm.com \
--cc=tingwei@codeaurora.org \
--cc=tsoni@codeaurora.org \
--cc=ykaukab@suse.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).