From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-11.5 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH, MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED, USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 4D29FC433DF for ; Thu, 6 Aug 2020 02:48:02 +0000 (UTC) Received: from merlin.infradead.org (merlin.infradead.org [205.233.59.134]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 182A32086A for ; Thu, 6 Aug 2020 02:48:02 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="R1a4LMhs"; dkim=fail reason="signature verification failed" (1024-bit key) header.d=mg.codeaurora.org header.i=@mg.codeaurora.org header.b="e+Wzbhgq" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 182A32086A Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=codeaurora.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=merlin.20170209; h=Sender:Content-Transfer-Encoding: Content-Type:Cc:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References:Message-ID: Subject:To:From:Date:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=uMvOW96q9QnfCA1OXR9noNtbaSN9VUBsFzFOHSHuNCI=; b=R1a4LMhsX/2Ga1FDrCrIiz+Ae wGCMfxmVzljrBeUmEtah9yAyQAirtbEmoSIoh6qEXjrir7ivQ7sxkaZtT6VScXCMIdXzBs5PKB4dd +CW+Uk8UbipQFQTgRHtaXzweMD7SqWKTBm6FtS3kkc5+sQ2CqKQHOwf+DMKrqNviOCz/w6RrBKAo0 gIf5akLBltUsYicNC4B2xjMxpKU3ILOP705smOZG/U2+XnxWd8scG0MNNrpuvxmgLlozMxWPq/fwY wFRNiytHIcqT4T8W8fE2zDV0yJDdk8nwWJqD4GulnBFgmZmCUXaWAoBlkqqnwjIETUvgRg+TQu04I kKuuvqEcQ==; Received: from localhost ([::1] helo=merlin.infradead.org) by merlin.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1k3VvV-0007fT-Up; Thu, 06 Aug 2020 02:46:41 +0000 Received: from mail29.static.mailgun.info ([104.130.122.29]) by merlin.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1k3VvR-0007ey-OP for linux-arm-kernel@lists.infradead.org; Thu, 06 Aug 2020 02:46:39 +0000 DKIM-Signature: a=rsa-sha256; v=1; c=relaxed/relaxed; d=mg.codeaurora.org; q=dns/txt; s=smtp; t=1596681998; h=In-Reply-To: Content-Type: MIME-Version: References: Message-ID: Subject: Cc: To: From: Date: Sender; bh=c2YKxQt8k7p6yTgVahoSmB/xvUIXzTd5Gg515paV6KU=; b=e+WzbhgqYvUCpL7cIHooO84YzXyhw7QDEKBq8RvDDnccC4Go4poysZtN3ggnaZm8COb9klX6 +DEGPO5ULWYCYdkz88dBF5LUGiwrjmHqvVkzVXS/gGK0sivtrTVCk2yJ8LdumGncQHErLNNb t0iUFWIWpU3iqECGfRfwaylfl24= X-Mailgun-Sending-Ip: 104.130.122.29 X-Mailgun-Sid: WyJiYzAxZiIsICJsaW51eC1hcm0ta2VybmVsQGxpc3RzLmluZnJhZGVhZC5vcmciLCAiYmU5ZTRhIl0= Received: from smtp.codeaurora.org (ec2-35-166-182-171.us-west-2.compute.amazonaws.com [35.166.182.171]) by smtp-out-n04.prod.us-west-2.postgun.com with SMTP id 5f2b6f0b668ab3fef61dee48 (version=TLS1.2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256); Thu, 06 Aug 2020 02:46:35 GMT Received: by smtp.codeaurora.org (Postfix, from userid 1001) id 175CCC433A0; Thu, 6 Aug 2020 02:46:35 +0000 (UTC) Received: from codeaurora.org (unknown [180.166.53.21]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) (Authenticated sender: tingwei) by smtp.codeaurora.org (Postfix) with ESMTPSA id 3226BC433C6; Thu, 6 Aug 2020 02:46:31 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 smtp.codeaurora.org 3226BC433C6 Authentication-Results: aws-us-west-2-caf-mail-1.web.codeaurora.org; dmarc=none (p=none dis=none) header.from=codeaurora.org Authentication-Results: aws-us-west-2-caf-mail-1.web.codeaurora.org; spf=none smtp.mailfrom=tingweiz@codeaurora.org Date: Thu, 6 Aug 2020 10:46:27 +0800 From: Tingwei Zhang To: Suzuki K Poulose Subject: Re: [PATCH v7 08/25] coresight: etm: perf: Fix warning caused by etm_setup_aux failure Message-ID: <20200806024627.GC10121@codeaurora.org> References: <20200805025458.2978-1-tingwei@codeaurora.org> <20200805025458.2978-9-tingwei@codeaurora.org> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.5.24 (2015-08-30) X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20200805_224638_821218_C1CA417C X-CRM114-Status: GOOD ( 19.22 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: tsoni@codeaurora.org, saiprakash.ranjan@codeaurora.org, kim.phillips@arm.com, mathieu.poirier@linaro.org, alexander.shishkin@linux.intel.com, gregkh@linuxfoundation.org, coresight@lists.linaro.org, rdunlap@infradead.org, ykaukab@suse.de, linux@armlinux.org.uk, jinlmao@codeaurora.org, tingwei@codeaurora.org, leo.yan@linaro.org, linux-arm-kernel@lists.infradead.org, mike.leach@linaro.org Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Wed, Aug 05, 2020 at 06:18:35PM +0800, Suzuki K Poulose wrote: > On 08/05/2020 03:54 AM, Tingwei Zhang wrote: > >When coresight_build_path() fails on all the cpus, etm_setup_aux > >calls etm_free_aux() to free allocated event_data. > >WARN_ON(cpumask_empty(mask) will be triggered since cpu mask is empty. > >Check event_data->snk_config is not NULL first to avoid this > >warning. > > > >Signed-off-by: Tingwei Zhang > >Reviewed-by: Mike Leach > > Please could you added a Fixes tag for this ? > > Fixes: f5200aa9831f38 ("coresight: perf: Refactor function > free_event_data()") > I'll add Fixes tag. Thanks, Tingwei > Reviewed-by: Suzuki K Poulose > > >--- > > drivers/hwtracing/coresight/coresight-etm-perf.c | 4 ++-- > > 1 file changed, 2 insertions(+), 2 deletions(-) > > > >diff --git a/drivers/hwtracing/coresight/coresight-etm-perf.c > >b/drivers/hwtracing/coresight/coresight-etm-perf.c > >index dcb0592418ae..3728c44e5763 100644 > >--- a/drivers/hwtracing/coresight/coresight-etm-perf.c > >+++ b/drivers/hwtracing/coresight/coresight-etm-perf.c > >@@ -126,10 +126,10 @@ static void free_sink_buffer(struct etm_event_data > >*event_data) > > cpumask_t *mask = &event_data->mask; > > struct coresight_device *sink; > > > >- if (WARN_ON(cpumask_empty(mask))) > >+ if (!event_data->snk_config) > > return; > > > >- if (!event_data->snk_config) > >+ if (WARN_ON(cpumask_empty(mask))) > > return; > > > > > > cpu = cpumask_first(mask); > > > _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel