From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.5 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 70987C433E0 for ; Thu, 6 Aug 2020 02:57:40 +0000 (UTC) Received: from merlin.infradead.org (merlin.infradead.org [205.233.59.134]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 35AF92177B for ; Thu, 6 Aug 2020 02:57:40 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="XZUy4JFB"; dkim=fail reason="signature verification failed" (1024-bit key) header.d=mg.codeaurora.org header.i=@mg.codeaurora.org header.b="Mcbrdj3A" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 35AF92177B Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=codeaurora.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=merlin.20170209; h=Sender:Content-Transfer-Encoding: Content-Type:Cc:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References:Message-ID: Subject:To:From:Date:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=soOnzpkRCV26RVeqKsFu900ICQ2TpYgdTq/k2JWZohM=; b=XZUy4JFBnhWD60BLtA+Hm6OI2 350f+eKQ6Q046B5cboGIRFZ/2v+Yj0Hpd6ayxFfYdSeBlJBIhPek6F0fdGejIG1sZpsO11k/rLeUz jTONb+TU/5yW7Ek1GM42eNTsyFXikv09MIVJ2KPuedO/TVyItYGsPw/CwD4R+cQqjC+JcSyyYUKCz 1pXRR29ATlNY+xUOE9JCsyvDOSlF8GWy4q2LyT8nxF3jME1eIadqpy8giCXPnZ6PmohQ/8a3Iyll5 +JgfSOgF+28XzwGXywlZQaYHEfGF1OROGblF6nQ14NCclTaC2vM/wVi7LPGAEZNeQrujioPndKB2p Q1DYkrvmw==; Received: from localhost ([::1] helo=merlin.infradead.org) by merlin.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1k3W4k-0008Jc-HP; Thu, 06 Aug 2020 02:56:14 +0000 Received: from mail29.static.mailgun.info ([104.130.122.29]) by merlin.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1k3W4e-0008Ir-CX for linux-arm-kernel@lists.infradead.org; Thu, 06 Aug 2020 02:56:12 +0000 DKIM-Signature: a=rsa-sha256; v=1; c=relaxed/relaxed; d=mg.codeaurora.org; q=dns/txt; s=smtp; t=1596682571; h=In-Reply-To: Content-Type: MIME-Version: References: Message-ID: Subject: Cc: To: From: Date: Sender; bh=5+LU4SioX6pmQg8rJsEW6rrkDMXcvtEbOdGMx7G5Wzk=; b=Mcbrdj3APpfB6pQ3mgkhehLEiPZ09zInhs+J9/Lfw/hQgOTzQckTCEcTVrpWSs7DNwS9HJ25 DDQz50MVms9eqb0FVSZ0flNQ9RJtCxWvc0wenmc0K/tv/aXMNfULg0pqGZGAbJNahLMLt2jo rSlk6A6AMUxfvc4jh2V3OnH1suk= X-Mailgun-Sending-Ip: 104.130.122.29 X-Mailgun-Sid: WyJiYzAxZiIsICJsaW51eC1hcm0ta2VybmVsQGxpc3RzLmluZnJhZGVhZC5vcmciLCAiYmU5ZTRhIl0= Received: from smtp.codeaurora.org (ec2-35-166-182-171.us-west-2.compute.amazonaws.com [35.166.182.171]) by smtp-out-n02.prod.us-east-1.postgun.com with SMTP id 5f2b7146d5b453ea40760f30 (version=TLS1.2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256); Thu, 06 Aug 2020 02:56:06 GMT Received: by smtp.codeaurora.org (Postfix, from userid 1001) id AE8F2C43395; Thu, 6 Aug 2020 02:56:05 +0000 (UTC) Received: from codeaurora.org (unknown [180.166.53.21]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) (Authenticated sender: tingwei) by smtp.codeaurora.org (Postfix) with ESMTPSA id ACEAEC433C9; Thu, 6 Aug 2020 02:56:01 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 smtp.codeaurora.org ACEAEC433C9 Authentication-Results: aws-us-west-2-caf-mail-1.web.codeaurora.org; dmarc=none (p=none dis=none) header.from=codeaurora.org Authentication-Results: aws-us-west-2-caf-mail-1.web.codeaurora.org; spf=none smtp.mailfrom=tingweiz@codeaurora.org Date: Thu, 6 Aug 2020 10:55:54 +0800 From: Tingwei Zhang To: Suzuki K Poulose Subject: Re: [PATCH v7 16/25] coresight: allow funnel and replicator drivers to be built as modules Message-ID: <20200806025554.GD10121@codeaurora.org> References: <20200805025458.2978-1-tingwei@codeaurora.org> <20200805025458.2978-17-tingwei@codeaurora.org> <6572f524-804b-cd51-8d8c-e1e522bcbef0@arm.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <6572f524-804b-cd51-8d8c-e1e522bcbef0@arm.com> User-Agent: Mutt/1.5.24 (2015-08-30) X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20200805_225611_700899_38FF0A66 X-CRM114-Status: GOOD ( 17.03 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: tsoni@codeaurora.org, saiprakash.ranjan@codeaurora.org, kim.phillips@arm.com, mathieu.poirier@linaro.org, alexander.shishkin@linux.intel.com, gregkh@linuxfoundation.org, coresight@lists.linaro.org, rdunlap@infradead.org, ykaukab@suse.de, linux@armlinux.org.uk, jinlmao@codeaurora.org, tingwei@codeaurora.org, leo.yan@linaro.org, linux-arm-kernel@lists.infradead.org, mike.leach@linaro.org Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Thu, Aug 06, 2020 at 12:04:24AM +0800, Suzuki K Poulose wrote: > On 08/05/2020 03:54 AM, Tingwei Zhang wrote: > >From: Kim Phillips > > > >Allow to build coresight-funnel and coresight-replicator as modules, > >for ease of development. > > > >- Kconfig becomes a tristate, to allow =m > >- add funnel_remove and replicator_remove functions, > > for module unload > >- add a MODULE_DEVICE_TABLE for autoloading on boot > > > >Cc: Mathieu Poirier > >Cc: Leo Yan > >Cc: Alexander Shishkin > >Cc: Randy Dunlap > >Cc: Suzuki K Poulose > >Cc: Greg Kroah-Hartman > >Cc: Russell King > >Signed-off-by: Kim Phillips > >Signed-off-by: Tingwei Zhang > >Tested-by: Mike Leach > > nit: Please split the changes to multiple drivers into their respective > patches. Also, I don't see any harm in merging the "remove multiple init > calls" patches with the respective "allow module" for the respective > drivers. I'll rearrange the patches. Thanks, Tingwei > > Otherwise looks good to me. > > Suzuki _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel