From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-11.5 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH, MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED, USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id D6164C433E0 for ; Thu, 6 Aug 2020 11:45:37 +0000 (UTC) Received: from merlin.infradead.org (merlin.infradead.org [205.233.59.134]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 8D3E2206C3 for ; Thu, 6 Aug 2020 11:45:37 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="cuxS5W2u"; dkim=fail reason="signature verification failed" (1024-bit key) header.d=mg.codeaurora.org header.i=@mg.codeaurora.org header.b="h5Wbng6j" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 8D3E2206C3 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=codeaurora.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=merlin.20170209; h=Sender:Content-Transfer-Encoding: Content-Type:Cc:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References:Message-ID: Subject:To:From:Date:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=4zLVK7IFRxDgaEM1y76N2tYi7bvepR7J0/KKn9k5sQE=; b=cuxS5W2umX2GDi5hCa9JoxYGF uJCpStGIvxYQnpda4YaAqicPUxR20BiBZ5majgnVhD90+2g1CkSxg0ocuecXvJXuK1n47frWOGfJU fRcjgNrS1CnLfw29DPNeniiHbSG+Ku67R9KoSCFyu3VeyXykPSrdaGmUe5NBq5voJHi3KFahthsG8 O7KM4n7vlK1Up76J6w32mzq7psuO6/5HYhXxfDRX6eqZ0CCKg4aLv7dsTSvvlvdCdXLAPYBI1g8vC MfVxADaD60TCdJ6UNBX/zVa7FKpMIKzV64GP2zNYEc7yvpRHmlVhjEjLLL+eLoqJIew2lR+iHEYZa igi+54qkA==; Received: from localhost ([::1] helo=merlin.infradead.org) by merlin.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1k3eJN-0007sS-8m; Thu, 06 Aug 2020 11:43:53 +0000 Received: from m43-7.mailgun.net ([69.72.43.7]) by merlin.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1k3eJI-0007rj-3I for linux-arm-kernel@lists.infradead.org; Thu, 06 Aug 2020 11:43:51 +0000 DKIM-Signature: a=rsa-sha256; v=1; c=relaxed/relaxed; d=mg.codeaurora.org; q=dns/txt; s=smtp; t=1596714230; h=In-Reply-To: Content-Type: MIME-Version: References: Message-ID: Subject: Cc: To: From: Date: Sender; bh=ralTxBC+0/nbzVfaUQ9VVIr661Mhvbb9Sb82E6hnGDM=; b=h5Wbng6jxPfDGiVaJkvAc4IemAddvxPkchCAgZ8T3/YRvYftDLuVRhJt8v1ILZwpc8Gszqcu CRqGoAtpqA874ov+lNy1m35meOh7gzo7IkQ8NOvA5d4mENCiZOFNPeflrbJReMvzaTQc9bXq 4VQNyXTcQ7rJkLVeq/SXdewNWYU= X-Mailgun-Sending-Ip: 69.72.43.7 X-Mailgun-Sid: WyJiYzAxZiIsICJsaW51eC1hcm0ta2VybmVsQGxpc3RzLmluZnJhZGVhZC5vcmciLCAiYmU5ZTRhIl0= Received: from smtp.codeaurora.org (ec2-35-166-182-171.us-west-2.compute.amazonaws.com [35.166.182.171]) by smtp-out-n11.prod.us-east-1.postgun.com with SMTP id 5f2becf06372cee9a89a097d (version=TLS1.2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256); Thu, 06 Aug 2020 11:43:44 GMT Received: by smtp.codeaurora.org (Postfix, from userid 1001) id E7849C433A0; Thu, 6 Aug 2020 11:43:43 +0000 (UTC) Received: from codeaurora.org (unknown [180.166.53.21]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) (Authenticated sender: tingwei) by smtp.codeaurora.org (Postfix) with ESMTPSA id 8D5A6C433C6; Thu, 6 Aug 2020 11:43:39 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 smtp.codeaurora.org 8D5A6C433C6 Authentication-Results: aws-us-west-2-caf-mail-1.web.codeaurora.org; dmarc=none (p=none dis=none) header.from=codeaurora.org Authentication-Results: aws-us-west-2-caf-mail-1.web.codeaurora.org; spf=none smtp.mailfrom=tingweiz@codeaurora.org Date: Thu, 6 Aug 2020 19:43:33 +0800 From: Tingwei Zhang To: Sai Prakash Ranjan Subject: Re: [PATCH v7 09/25] coresight: etm3x: allow etm3x to be built as a module Message-ID: <20200806114332.GA4918@codeaurora.org> References: <20200805025458.2978-1-tingwei@codeaurora.org> <20200805025458.2978-10-tingwei@codeaurora.org> <83abb52f-4c3b-9b50-4053-84343d75eeb3@arm.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.5.24 (2015-08-30) X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20200806_074350_466785_EB8B9ADE X-CRM114-Status: GOOD ( 36.07 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: tsoni@codeaurora.org, Kim Phillips , Mathieu Poirier , Suzuki K Poulose , Alexander Shishkin , Greg Kroah-Hartman , Coresight ML , Randy Dunlap , Mian Yousaf Kaukab , Russell King , Mao Jinlong , Tingwei Zhang , Leo Yan , linux-arm-kernel , Mike Leach Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Thu, Aug 06, 2020 at 01:44:56PM +0800, Sai Prakash Ranjan wrote: > Hi Mike, > > On 2020-08-05 18:24, Mike Leach wrote: > >Hi, > > > >On Wed, 5 Aug 2020 at 12:05, Suzuki K Poulose > >wrote: > >> > >>On 08/05/2020 03:54 AM, Tingwei Zhang wrote: > >>> From: Kim Phillips > >>> > >>> Allow to build coresight-etm3x as a module, for ease of development. > >>> > >>> - Kconfig becomes a tristate, to allow =m > >>> - append -core to source file name to allow module to > >>> be called coresight-etm3x by the Makefile > >>> - add an etm_remove function, for module unload > >>> - add a MODULE_DEVICE_TABLE for autoloading on boot > >>> > >>> Cc: Mathieu Poirier > >>> Cc: Leo Yan > >>> Cc: Alexander Shishkin > >>> Cc: Randy Dunlap > >>> Cc: Suzuki K Poulose > >>> Cc: Greg Kroah-Hartman > >>> Cc: Russell King > >>> Signed-off-by: Kim Phillips > >>> Signed-off-by: Tingwei Zhang > >>> Reviewed-by: Mike Leach > >>> --- > >>> drivers/hwtracing/coresight/Kconfig | 5 +++- > >>> drivers/hwtracing/coresight/Makefile | 3 ++- > >>> ...resight-etm3x.c => coresight-etm3x-core.c} | 27 > ++++++++++++++++++- > >>> 3 files changed, 32 insertions(+), 3 deletions(-) > >>> rename drivers/hwtracing/coresight/{coresight-etm3x.c => > coresight-etm3x-core.c} (97%) > >>> > >>> diff --git a/drivers/hwtracing/coresight/Kconfig > b/drivers/hwtracing/coresight/Kconfig > >>> index 6433f835fc97..8fd9fd139cf3 100644 > >>> --- a/drivers/hwtracing/coresight/Kconfig > >>> +++ b/drivers/hwtracing/coresight/Kconfig > >>> @@ -65,7 +65,7 @@ config CORESIGHT_SINK_ETBV10 > >>> special enhancement or added features. > >>> > >>> config CORESIGHT_SOURCE_ETM3X > >>> - bool "CoreSight Embedded Trace Macrocell 3.x driver" > >>> + tristate "CoreSight Embedded Trace Macrocell 3.x driver" > >>> depends on !ARM64 > >>> select CORESIGHT_LINKS_AND_SINKS > >>> help > >>> @@ -74,6 +74,9 @@ config CORESIGHT_SOURCE_ETM3X > >>> This is primarily useful for instruction level tracing. > Depending > >>> the ETM version data tracing may also be available. > >>> > >>> + To compile this driver as a module, choose M here: the > >>> + module will be called coresight-etm3x. > >>> + > >>> config CORESIGHT_SOURCE_ETM4X > >>> bool "CoreSight Embedded Trace Macrocell 4.x driver" > >>> depends on ARM64 > >>> diff --git a/drivers/hwtracing/coresight/Makefile > b/drivers/hwtracing/coresight/Makefile > >>> index 19497d1d92bf..d619cfd0abd8 100644 > >>> --- a/drivers/hwtracing/coresight/Makefile > >>> +++ b/drivers/hwtracing/coresight/Makefile > >>> @@ -11,7 +11,8 @@ obj-$(CONFIG_CORESIGHT_SINK_TPIU) += > coresight-tpiu.o > >>> obj-$(CONFIG_CORESIGHT_SINK_ETBV10) += coresight-etb10.o > >>> obj-$(CONFIG_CORESIGHT_LINKS_AND_SINKS) += coresight-funnel.o \ > >>> coresight-replicator.o > >>> -obj-$(CONFIG_CORESIGHT_SOURCE_ETM3X) += coresight-etm3x.o > coresight-etm-cp14.o \ > >>> +obj-$(CONFIG_CORESIGHT_SOURCE_ETM3X) += coresight-etm3x.o > >>> +coresight-etm3x-y := coresight-etm3x-core.o coresight-etm-cp14.o \ > >>> coresight-etm3x-sysfs.o > >>> obj-$(CONFIG_CORESIGHT_SOURCE_ETM4X) += coresight-etm4x.o \ > >>> coresight-etm4x-sysfs.o > >>> diff --git a/drivers/hwtracing/coresight/coresight-etm3x.c > b/drivers/hwtracing/coresight/coresight-etm3x-core.c > >>> similarity index 97% > >>> rename from drivers/hwtracing/coresight/coresight-etm3x.c > >>> rename to drivers/hwtracing/coresight/coresight-etm3x-core.c > >>> index bf22dcfd3327..82b333c40006 100644 > >>> --- a/drivers/hwtracing/coresight/coresight-etm3x.c > >>> +++ b/drivers/hwtracing/coresight/coresight-etm3x-core.c > >>> @@ -895,6 +895,23 @@ static int etm_probe(struct amba_device *adev, > const struct amba_id *id) > >>> return ret; > >>> } > >>> > >>> +static int __exit etm_remove(struct amba_device *adev) > >>> +{ > >>> + struct etm_drvdata *drvdata = dev_get_drvdata(&adev->dev); > >>> + > >>> + etm_perf_symlink(drvdata->csdev, false); > >>> + > >>> + if (--etm_count == 0) { > >> > >>Could there be multiple instances of remove running in parallel ? I > >>believe we need some sort of a protection here to avoid racing. > >> > >>Or even better, I would recommend leaving the notifiers registered > >>at module_init and removed at the cleanup of the module, just like > >>we are doing for etm4x driver, and get rid of this silly scheme. > > > >I would agree that this needs addressing but this is an independent > >problem that could be better served by a separate patchset, rather > >than add feature creep to this set. The same schema is used in the CTI > >driver as well and needs fixing there. > > > >>Like here : > >> > >> > https://lkml.kernel.org/r/20200729051310.18436-1-saiprakash.ranjan@codeaur > ora.org > >> > > > >This conflicts with the init / exit fns created for module loading in > >the etm4x part of this set.. > > > >A decision needs to be made on which set gets applied first - my view > >is that the module set could go first, then a set fixing the PM > >registration issues for all three affected drivers to be applied next. > > The etm4_count race is a bug fix which in my opinion should go first because > this feature would likely to be merged for 5.10 and till then we would have > a bug lying around if the fix patch for the race does not go in right? > Agree with you, Sai. I'll rebase this series to your change. > Thanks, > Sai > > -- > QUALCOMM INDIA, on behalf of Qualcomm Innovation Center, Inc. is a member > of Code Aurora Forum, hosted by The Linux Foundation _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel