From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-7.0 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE, SPF_PASS,URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id DC47AC433DF for ; Thu, 6 Aug 2020 13:38:08 +0000 (UTC) Received: from merlin.infradead.org (merlin.infradead.org [205.233.59.134]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id D852923110 for ; Thu, 6 Aug 2020 13:38:08 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="IpmTyOHC"; dkim=fail reason="signature verification failed" (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="ogSom+x8" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org D852923110 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=kernel.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=merlin.20170209; h=Sender:Content-Transfer-Encoding: Content-Type:Cc:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References:Message-ID: Subject:To:From:Date:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=uIRmdFuePFX5qsXs8lDFr79j2bHsRDCjnFzw7O6XjFM=; b=IpmTyOHCHs2jN3At3AYfPkJx6 zbYrMg1Q5T7b9+ztv3knrm4MC+DOu2AZnIOdop002GUavyWJ5W7YGioizEY4Y8m47WVKyhm18Q/sU Zjf1X1Bdj0sYk1Xa8P/PzOVVhlN3TA4L9m1PhD/3Orjd+fj9WiCJsTYmqqBWF1sBecjp6Fp+J/p+0 uRCdWNd3/1TXsZjbVDD4VwuFZgljZ1mXK/61iivqjzfIoKayA4w7a21xuFUQUPLVv8QZXyrudTXfY FWfDtvFbrTVKOWOKz88mHNW5cx5sK6McLCgXJxJXIet4EZ2ac7jdTj+uA3NGnJ6evWV51w/tZnazj 3pBGJXtRg==; Received: from localhost ([::1] helo=merlin.infradead.org) by merlin.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1k3g4Q-0005de-Px; Thu, 06 Aug 2020 13:36:34 +0000 Received: from mail-ej1-x642.google.com ([2a00:1450:4864:20::642]) by merlin.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1k3g4O-0005cp-Em; Thu, 06 Aug 2020 13:36:33 +0000 Received: by mail-ej1-x642.google.com with SMTP id o23so22911890ejr.1; Thu, 06 Aug 2020 06:36:31 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=sender:date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to; bh=gIDHrckbjX7A25XdrR7+VuHvfE++wIYqYDxklPozcMs=; b=ogSom+x8Vy+lrAdhx1aGY5/eZbaKav0gVy1rtsnre4Wxvro3UESENnKfnCp/QxCtmG fW5QRMvekFqUn3rRvHSO0BVG77bAIelCG1bTOXD3LZh+CjPOWHHlBw6YNgv4yxyWxZ1A C2MtbtQJlwXe0jG5hKajDsyJBM1ZI881zSKQnR1JyP/vsNpY/I4tAkQEfGlTqBz4ikWO 8uiMs17fIiTulh4cHi8R/rcX/ZP3A6ZBHdcA2FT6m7uZyIoFs7mEANUdpHknqNVgI7xv geOQu7Af/PNjiCUOmAWBleQ8MnuxaZLIhkPbbGEI7EYs0CjOlF5400DjzClFHZI+z9ii Qt3w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:sender:date:from:to:cc:subject:message-id :references:mime-version:content-disposition:in-reply-to; bh=gIDHrckbjX7A25XdrR7+VuHvfE++wIYqYDxklPozcMs=; b=ZJuV6Ag474MaSUUgFAEj4aJnjlezTBoQt5unU37RUb2EdAJYuL7oZwPRbAIzSIrX99 XKx3A/9AiiQtNyFcjHF0Ej8ElL5JIOzs7OvKT6aKaM61TdE+O5FpsOwgigjdA0fYDZv3 iT4a0Ip7ZmEMB9KpYZwfo/9bsu8J11RApLrT1h8zJyggF8YnNxJztc4EzYmf5pUyJL+0 6fevxbY8WyXC1PRmKWjmhwHXKn1qv/DZ3ChrNzVjHmLFVNM1FIb7hkkOUq5j5ptaOJn/ Yfh9xQO3blytoaGPkrnMqAhLlXaJF2oAWSQvTfcKY86JzbZpVWM4yaw8/aryxHUGZlal d3dA== X-Gm-Message-State: AOAM532rkW8ZyD1IkkYNkdVN1/QDhHHn6aObaXu9u4wGjPwi5HfiPck3 AkWxxB5fsgRxTJohmFh9QEQ= X-Google-Smtp-Source: ABdhPJxwl1YXqFobKjLCcATa/wMS8MPiG3+A3CHWjljmnJY2ertpfCVqc4nVSOG5Fs9xOTTwnb/N0A== X-Received: by 2002:a17:906:b59:: with SMTP id v25mr4357184ejg.436.1596720991043; Thu, 06 Aug 2020 06:36:31 -0700 (PDT) Received: from gmail.com (54033286.catv.pool.telekom.hu. [84.3.50.134]) by smtp.gmail.com with ESMTPSA id pv28sm3788137ejb.71.2020.08.06.06.36.28 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 06 Aug 2020 06:36:29 -0700 (PDT) Date: Thu, 6 Aug 2020 15:36:27 +0200 From: Ingo Molnar To: Chen Zhou Subject: Re: [PATCH v11 2/5] x86: kdump: move reserve_crashkernel_low() into crash_core.c Message-ID: <20200806133627.GB2077191@gmail.com> References: <20200801130856.86625-1-chenzhou10@huawei.com> <20200801130856.86625-3-chenzhou10@huawei.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20200801130856.86625-3-chenzhou10@huawei.com> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20200806_093632_663201_01F3354E X-CRM114-Status: GOOD ( 11.82 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: wangkefeng.wang@huawei.com, linux-doc@vger.kernel.org, catalin.marinas@arm.com, bhsharma@redhat.com, huawei.libin@huawei.com, guohanjun@huawei.com, will@kernel.org, bhe@redhat.com, corbet@lwn.net, mingo@redhat.com, dyoung@redhat.com, John.P.donnelly@oracle.com, arnd@arndb.de, xiexiuqi@huawei.com, horms@verge.net.au, tglx@linutronix.de, linux-arm-kernel@lists.infradead.org, kexec@lists.infradead.org, linux-kernel@vger.kernel.org, robh+dt@kernel.org, james.morse@arm.com, prabhakar.pkin@gmail.com, nsaenzjulienne@suse.de Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org * Chen Zhou wrote: > In preparation for supporting reserve_crashkernel_low in arm64 as > x86_64 does, move reserve_crashkernel_low() into kernel/crash_core.c. > > BTW, move x86_64 CRASH_ALIGN to 2M suggested by Dave. CONFIG_PHYSICAL_ALIGN > can be selected from 2M to 16M, move to the same as arm64. > > Signed-off-by: Chen Zhou > --- > arch/x86/include/asm/kexec.h | 24 ++++++++++ > arch/x86/kernel/setup.c | 86 +++--------------------------------- > include/linux/crash_core.h | 3 ++ > include/linux/kexec.h | 2 - > kernel/crash_core.c | 74 +++++++++++++++++++++++++++++++ > kernel/kexec_core.c | 17 ------- > 6 files changed, 107 insertions(+), 99 deletions(-) Since the changes are centered around arm64, I suppose the arm64 tree will carry this patchset? Assuming that this is a 100% invariant moving of code that doesn't regress on x86: Acked-by: Ingo Molnar Thanks, Ingo _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel