From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-10.0 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id D72E4C433E0 for ; Thu, 6 Aug 2020 14:41:12 +0000 (UTC) Received: from merlin.infradead.org (merlin.infradead.org [205.233.59.134]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id E7C1823105 for ; Thu, 6 Aug 2020 14:41:12 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="R0pBAHNY" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org E7C1823105 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=kernel.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=merlin.20170209; h=Sender:Content-Transfer-Encoding: Content-Type:Cc:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References:Message-ID: Subject:To:From:Date:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=16hvQBPEqU4YHapYoP+cx9c6AsBSN5O36yHMsuV+waQ=; b=R0pBAHNYg/ruNTrsJ3PVHYTcd 7drxtS4sbl4tisX5IvJWWptsjFExGPpxo9AzL7EjMnGOQ0BAsBXLLLR6r9HM0vZRgQHW6TCuV4fxh 3sMu9IilCqMyKuUcXNvY1TcRBfETty2mSiTq3XTCflT77YswoFpwzkiXrVG8q0K1tDa7lZITu4f72 5uxgMav0KTUMkTOgpa88faQo5imy7kgga4uso0xa/LSVH4I7jqGps4j9sSfd+hSG3rAMEeHqQMR41 jNL0TxfTQefC3BTxu3MmP76LwnJ/fphQS3sC+Qxi35sGLBaH48rwZIDuuTswPW6Zwq/3PbjZW0JHv M390FjKwQ==; Received: from localhost ([::1] helo=merlin.infradead.org) by merlin.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1k3h3A-00054E-Pb; Thu, 06 Aug 2020 14:39:20 +0000 Received: from mail-io1-f67.google.com ([209.85.166.67]) by merlin.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1k3h38-00053t-Gi for linux-arm-kernel@lists.infradead.org; Thu, 06 Aug 2020 14:39:19 +0000 Received: by mail-io1-f67.google.com with SMTP id t15so40883363iob.3 for ; Thu, 06 Aug 2020 07:39:18 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=xk1+TxcE3QnIGMOvPraXoKHV6uIacnJL3Sj3a6NYZPM=; b=Dz8XTuJ3gBrCz/lyZKFztuhkByW+h+CBCtjpCCOdlMN9CBlVlFDUa9VrNlSz5gWbRC P0KnC9zwAU0TUj3CimA27UqXF5pkQkmv81QbYOMpiN5yZCe+BwxpXxWelBuBs57AZak1 5mQ6V4DfamzCzDnM8XfTQgguAppDAwIGoPJeDeJZ6sT/LjNytmxQyuNMfVN04lukkKDC eT3u/69356qhTX85n6Ws60vo60mUxqIGokbbWpTl04HDc54hfyqCRv9CgPUJ0IMruiUB 4bgPbBhsloaJ4jqxOqQoiSdw+TZphembj9qdrZxXiZj01N4GvFDFbpuYACobNOfy7C2k w/UA== X-Gm-Message-State: AOAM5331Km1G9wcMoMf4GEHWXoms5CkmGbvHoAPxlvkFM/NLg3FyXKxf 1ad7gmpAhdckXTf0ObMqoQ== X-Google-Smtp-Source: ABdhPJywUa1fS+mhDPPCoUj+LuP94rGkcgwbq8VHiTsnW6mBNPkpA3uSHzABW0gjnvpFFTpk6c+lhA== X-Received: by 2002:a05:6602:24d5:: with SMTP id h21mr10407216ioe.108.1596724757598; Thu, 06 Aug 2020 07:39:17 -0700 (PDT) Received: from xps15 ([64.188.179.252]) by smtp.gmail.com with ESMTPSA id a18sm4061245ilp.52.2020.08.06.07.39.13 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 06 Aug 2020 07:39:16 -0700 (PDT) Received: (nullmailer pid 822114 invoked by uid 1000); Thu, 06 Aug 2020 14:39:12 -0000 Date: Thu, 6 Aug 2020 08:39:12 -0600 From: Rob Herring To: Cheng-Yi Chiang Subject: Re: [PATCH v4 1/2] ASoC: qcom: dt-bindings: Add sc7180 machine bindings Message-ID: <20200806143912.GA816294@bogus> References: <20200803040122.2063634-1-cychiang@chromium.org> <20200803040122.2063634-2-cychiang@chromium.org> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20200803040122.2063634-2-cychiang@chromium.org> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20200806_103918_590181_76FF460F X-CRM114-Status: GOOD ( 18.50 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Taniya Das , devicetree@vger.kernel.org, alsa-devel@alsa-project.org, Banajit Goswami , Stephan Gerhold , Liam Girdwood , linux-arm-msm@vger.kernel.org, Patrick Lai , Takashi Iwai , linux-kernel@vger.kernel.org, tzungbi@chromium.org, Bjorn Andersson , Mark Brown , Rohit kumar , Andy Gross , dianders@chromium.org, Srini Kandagatla , dgreid@chromium.org, Jaroslav Kysela , linux-arm-kernel@lists.infradead.org Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Mon, Aug 03, 2020 at 12:01:21PM +0800, Cheng-Yi Chiang wrote: > Add devicetree bindings documentation file for sc7180 sound card. > > Signed-off-by: Cheng-Yi Chiang > --- > .../bindings/sound/qcom,sc7180.yaml | 113 ++++++++++++++++++ > 1 file changed, 113 insertions(+) > create mode 100644 Documentation/devicetree/bindings/sound/qcom,sc7180.yaml > > diff --git a/Documentation/devicetree/bindings/sound/qcom,sc7180.yaml b/Documentation/devicetree/bindings/sound/qcom,sc7180.yaml > new file mode 100644 > index 000000000000..c74f0fe9fb3b > --- /dev/null > +++ b/Documentation/devicetree/bindings/sound/qcom,sc7180.yaml > @@ -0,0 +1,113 @@ > +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause) > +%YAML 1.2 > +--- > +$id: http://devicetree.org/schemas/sound/qcom,sc7180.yaml# > +$schema: http://devicetree.org/meta-schemas/core.yaml# > + > +title: Qualcomm Technologies Inc. SC7180 ASoC sound card driver > + > +maintainers: > + - Rohit kumar > + - Cheng-Yi Chiang > + > +description: > + This binding describes the SC7180 sound card which uses LPASS for audio. > + > +properties: > + compatible: > + contains: > + const: qcom,sc7180-sndcard > + > + audio-routing: > + $ref: /schemas/types.yaml#/definitions/non-unique-string-array > + description: > + A list of the connections between audio components. Each entry is a > + pair of strings, the first being the connection's sink, the second > + being the connection's source. > + > + model: > + $ref: /schemas/types.yaml#/definitions/string > + description: User specified audio sound card name > + > + aux-dev: > + $ref: /schemas/types.yaml#/definitions/phandle > + description: phandle of the codec for headset detection > + > +patternProperties: > + "^dai-link(@[0-9]+)?$": > + description: > + Each subnode represents a dai link. Subnodes of each dai links would be > + cpu/codec dais. > + > + type: object > + > + properties: > + link-name: > + description: Indicates dai-link name and PCM stream name. > + $ref: /schemas/types.yaml#/definitions/string > + maxItems: 1 > + > + reg: > + description: dai link address. > + $ref: /schemas/types.yaml#/definitions/uint32 > + maxItems: 1 > + > + cpu: > + description: Holds subnode which indicates cpu dai. > + type: object > + properties: > + sound-dai: true > + > + codec: > + description: Holds subnode which indicates codec dai. > + type: object > + properties: > + sound-dai: true > + > + required: > + - link-name > + - cpu > + - codec > + > + additionalProperties: false Nothing required? Add: additionalProperties: false (And you'll need to define #address-cells and #size-cells) > + > +examples: > + > + - | > + sound { > + compatible = "qcom,sc7180-sndcard"; > + model = "sc7180-snd-card"; > + > + audio-routing = > + "Headphone Jack", "HPOL", > + "Headphone Jack", "HPOR"; > + > + aux-dev = <&alc5682>; > + > + #address-cells = <1>; > + #size-cells = <0>; > + > + dai-link@0 { > + link-name = "MultiMedia0"; > + reg = <0>; > + cpu { > + sound-dai = <&lpass_cpu 0>; > + }; > + > + codec { > + sound-dai = <&alc5682 0>; > + }; > + }; > + > + dai-link@1 { > + link-name = "MultiMedia1"; > + reg = <1>; > + cpu { > + sound-dai = <&lpass_cpu 1>; > + }; > + > + codec { > + sound-dai = <&max98357a>; > + }; > + }; > + }; > -- > 2.28.0.163.g6104cc2f0b6-goog > _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel