From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-4.0 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id F16DEC433E0 for ; Fri, 7 Aug 2020 00:45:12 +0000 (UTC) Received: from merlin.infradead.org (merlin.infradead.org [205.233.59.134]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id DC66E206B5 for ; Fri, 7 Aug 2020 00:45:12 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="sCmWZU4Q"; dkim=fail reason="signature verification failed" (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="whSCyRwN" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org DC66E206B5 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=linaro.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=merlin.20170209; h=Sender:Content-Transfer-Encoding: Content-Type:Cc:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References:Message-ID: Subject:To:From:Date:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=yw1XF5fWTkF41jtmQOPmicIETntoR3iZF4b/dhSaouk=; b=sCmWZU4QHNipGKMjVTSIR7lGN kkbMOco6UZfYK2c8CItONQ9guILf5h1Z1d7HoTLXLyFnzO0EucA9+FoEIDBWS7UK6WrlkHX7tRxzD t9zwLNKAfDTid4iRUWoKOTec8N5UoFcXHSthSyFXGeSEK277hieEpw0XFr4gCOWo7oIs2rpgMCKbX R3Zy0xUrelrAQrkZR+X4/mOHWyxHBq7iCuYmmxivYr1CxqhARPchwzcVPjFaNaQv+9YoZzX/TkMei gtZBiYfEeE5sKutxTY1lnh6exkXLHY8q555pbn8+xlNIphFk8PWHQGdWD/fZMTc9eLLA+7NwH0Lx6 VGrL8Pv1w==; Received: from localhost ([::1] helo=merlin.infradead.org) by merlin.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1k3qU9-0001Yk-AU; Fri, 07 Aug 2020 00:43:49 +0000 Received: from mail-pj1-x1042.google.com ([2607:f8b0:4864:20::1042]) by merlin.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1k3qU5-0001XT-At for linux-arm-kernel@lists.infradead.org; Fri, 07 Aug 2020 00:43:47 +0000 Received: by mail-pj1-x1042.google.com with SMTP id mt12so58226pjb.4 for ; Thu, 06 Aug 2020 17:43:43 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to; bh=RgPXZVMrIckGX5DmfsQv8yNcqJQDdPlKU/7tj+0RAOU=; b=whSCyRwNhpsO+yWDNZ4Cv5qNyZzpLOvp7DiNIK2pc3y7XGe+OgdIGNTYBxcj8Zsxh7 zYK0DR66GIMJwtwOdD0UOwxI+I5yf6lNoZKf3J+MlgeO82rATZ4XoQZuFSQZYbA+Y1el SO329IS71+vYIjIWEGLmlMbwErG6gv2/N5bXbsRi6xPMSzueQ04XdqNNg2be3HuBptsM +lJdAMvJDOB5JSozRVKaB3mz6n5A8d428+EF0qwNz/iOBaDczoIhMPLfszGtK7+UWBPK Z67kBsTMFlydITNfQZc49FejvfOdYfrpHYf+O4jF1aB9AFLpGA0O2BcoeO4qSphffdVH WRdA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=RgPXZVMrIckGX5DmfsQv8yNcqJQDdPlKU/7tj+0RAOU=; b=Ub0un1xhkJ7FRNwB7scAEY6in+cageGI34ug2Khf8KpK0TA7qwOuSYJY/pEdgA0OSF 14+LdW48Svb2PpmM1/0AzOaFZXjfYqGm4UoFcpKNjW1s/A7idVlMtfnDUVqMOt8uQMcd M9vPo6vMrCdOBqE1UA3oT6RpukkZ7I1hg3WBlBU8rBz4Rt4kPniELk5ALVLlds8eNuuD mr8+c07shTcnYptQf8Iq6eG4Ek211X9UkKtLoeC8VTdVevbomXKmL4suAyiYQyz4prhl Tv2wXSgPhGs0NMqs4/KRoxzANNZF7MwxmgnGZUGxktf8Qk2ypY5K81u1bEGmMXmvAuIw Elqw== X-Gm-Message-State: AOAM533BPDUX1She0Z3NkkYbinkvj8fJUvWkRcJSfuSm6Aksd8ECgodJ dpIMt9MfDewaW1wxsyh44jkHeQ== X-Google-Smtp-Source: ABdhPJzzSsdKj+hMfY/ueb2cz2zxYSb8Y/2u33WYsliSAC12b4M2MWm1xSe3yMluHLVX3jxKgljGCQ== X-Received: by 2002:a17:902:8a88:: with SMTP id p8mr10174683plo.184.1596761019053; Thu, 06 Aug 2020 17:43:39 -0700 (PDT) Received: from builder.lan (104-188-17-28.lightspeed.sndgca.sbcglobal.net. [104.188.17.28]) by smtp.gmail.com with ESMTPSA id b15sm9673497pft.116.2020.08.06.17.43.37 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 06 Aug 2020 17:43:38 -0700 (PDT) Date: Thu, 6 Aug 2020 17:40:01 -0700 From: Bjorn Andersson To: John Stultz Subject: Re: [PATCH v3 2/4] irqchip/qcom-pdc: Switch to using IRQCHIP_PLATFORM_DRIVER helper macros Message-ID: <20200807004001.GF20825@builder.lan> References: <20200718000637.3632841-1-saravanak@google.com> <20200718000637.3632841-3-saravanak@google.com> <78ad0914-6173-f753-9eba-b7cbfbb51fd6@kali.org> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20200806_204345_777532_57924CF4 X-CRM114-Status: GOOD ( 26.95 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: CC Hwang , Jason Cooper , Saravana Kannan , Marc Zyngier , Hanks Chen , Loda Chou , lkml , Steev Klimaszewski , Andy Gross , "moderated list:ARM/Mediatek SoC support" , linux-arm-msm , Matthias Brugger , Thomas Gleixner , Android Kernel Team , linux-arm-kernel Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Wed 05 Aug 14:57 PDT 2020, John Stultz wrote: > On Wed, Aug 5, 2020 at 2:47 PM Steev Klimaszewski wrote: > > > > > > On 8/5/20 4:16 PM, Steev Klimaszewski wrote: > > > On 8/5/20 3:19 PM, Saravana Kannan wrote: > > >> On Wed, Aug 5, 2020 at 12:44 AM John Stultz wrote: > > >>> > > >>> So this is where I bashfully admit I didn't get a chance to try this > > >>> patch series out, as I had success with a much older version of > > >>> Saravana's macro magic. > > >>> > > >>> But unfortunately, now that this has landed in mainline, I'm seeing > > >>> boot regressions on db845c. :( This is in the non-modular case, > > >>> building the driver in. > > >> Does that mean the modular version is working? Or you haven't tried > > >> that yet? I'll wait for your reply before I try to fix it. I don't > > >> have the hardware, but it should be easy to guess this issue looking > > >> at the code delta. > > > For what it's worth, I saw this too on the Lenovo C630 (started on -next > > > around 20200727, but I didn't track it down as, well, there's less way > > > to get debug output on the C630. > > > > > > In my testing, module or built-in doesn't matter, but reverting does > > > allow me to boot again. > > > > > Actually - I spoke too soon - QCOM_PDC built-in with the commit reverted > > boots, however, module (on the c630 at least) doesn't boot whether it's > > a module or built-in. > > You may need to set deferred_probe_timeout=30 to give things a bit > more grace time to load. With the risk of me reading more into this than what you're saying, please don't upstream anything that depend this parameter to be increased. Compiling any of these drivers as module should not require the user to pass additional kernel command line parameters in order to get their device to boot. Regards, Bjorn > (I've mostly recently used qcom-pdc as a module with the android tree, > so the fw_devlink bits help there, but I need to re-check the state of > that upstream.) > > I'll dbl check this and dig more on the issue with the patch in > question once I can get back in my office later today. > > thanks > -john _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel