RE: [PATCH 1/1] arm64: add support for PAGE_SIZE aligned kernel stack

From: Maninder Singh <maninder1.s@samsung.com>
To: Vaneet Narang <v.narang@samsung.com>,
	Mark Rutland <mark.rutland@arm.com>
Cc: "catalin.marinas@arm.com" <catalin.marinas@arm.com>,
	"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
	"laoar.shao@gmail.com" <laoar.shao@gmail.com>,
	AMIT SAHRAWAT <a.sahrawat@samsung.com>,
	"vincenzo.frascino@arm.com" <vincenzo.frascino@arm.com>,
	"will@kernel.org" <will@kernel.org>,
	"ardb@kernel.org" <ardb@kernel.org>,
	"walken@google.com" <walken@google.com>,
	"maz@kernel.org" <maz@kernel.org>,
	"daniel.m.jordan@oracle.com" <daniel.m.jordan@oracle.com>,
	"mingo@redhat.com" <mingo@redhat.com>,
	"samitolvanen@google.com" <samitolvanen@google.com>,
	"adobriyan@gmail.com" <adobriyan@gmail.com>,
	"keescook@chromium.org" <keescook@chromium.org>,
	"arnd@arndb.de" <arnd@arndb.de>,
	"anshuman.khandual@arm.com" <anshuman.khandual@arm.com>,
	"rostedt@goodmis.org" <rostedt@goodmis.org>,
	"broonie@kernel.org" <broonie@kernel.org>,
	"kristina.martsenko@arm.com" <kristina.martsenko@arm.com>,
	"linux-arm-kernel@lists.infradead.org"
	<linux-arm-kernel@lists.infradead.org>,
	"john.johansen@canonical.com" <john.johansen@canonical.com>,
	"avagin@gmail.com" <avagin@gmail.com>,
	"steve.capper@arm.com" <steve.capper@arm.com>,
	"gladkov.alexey@gmail.com" <gladkov.alexey@gmail.com>,
	"oleg@redhat.com" <oleg@redhat.com>,
	"bernd.edlinger@hotmail.de" <bernd.edlinger@hotmail.de>,
	"james.morse@arm.com" <james.morse@arm.com>,
	"ebiederm@xmission.com" <ebiederm@xmission.com>,
	"gregkh@linuxfoundation.org" <gregkh@linuxfoundation.org>,
	"linux-fsdevel@vger.kernel.org" <linux-fsdevel@vger.kernel.org>,
	"akpm@linux-foundation.org" <akpm@linux-foundation.org>
Subject: RE: [PATCH 1/1] arm64: add support for PAGE_SIZE aligned kernel stack
Date: Fri, 07 Aug 2020 16:47:20 +0530	[thread overview]
Message-ID: <20200807111720epcms5p1206fe967bcee6136774c8432ed5b514b@epcms5p1> (raw)
In-Reply-To: <20200804061526epcms5p3ff393f7e51d28ed896105c868bd31e5b@epcms5p3>

Hi Mark, 

>>If you are seeing issues with the current stack size, can you please
>>explain that in more detail? Where are you seeing problems? Which
>>configuration options do you have selected?
>>

We checked on our system with netflix and youtube 4K videos running
max stack consumption was 7 KB:

sh-3.2# cat /sys/kernel/debug/tracing/stack_max_size  
7312

Thus we thought 16KB wil waste a lot of memory for our ARM64 target,
and 8KB can be less in some exceptional case.
So we decided for 12 KB change.

>>I'm not keen on making kernel stack sizes configurable as it's not
>>currently possible for the person building the kernel to figure out a
>>safe size (and if this were possible, it's be better to handle this
>>automatically).
>>

Ok, can we do something else?, like not making it configurable,
but do code changes to support it for PAGE_SIZE aligned stacks
rather than power of 2 alignement.

Although with configurable also, it depends on VMAP stack,
so user will have stack exhaust  exception and can increase acccordingly also.

> 
>Motivation behind these changes is saving memory on our system. 
>Our system runs around 2500 threads concurrently so saving 4Kb  
>might help us in saving 10MB memory.
> 
>To ensure 12KB is sufficient for our system we have used stack tracing and 
>realised maximum stack used is not more than 9KB. 
> /sys/kernel/tracing/stack_max_size
> 
>Tracing interface defined by kernel to track maximum stack size can be used
>by others to decide appropriate stack size.
> 

Thanks

_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel