From: Russell King - ARM Linux admin <linux@armlinux.org.uk>
To: Linus Walleij <linus.walleij@linaro.org>
Cc: Fabrizio Castro <fabrizio.castro@bp.renesas.com>,
Ard Biesheuvel <ardb@kernel.org>,
linux-arm-kernel@lists.infradead.org,
Nicolas Pitre <nico@fluxnic.net>
Subject: Re: [PATCH] ARM: compress: Fix the debug prints
Date: Fri, 7 Aug 2020 13:59:08 +0100 [thread overview]
Message-ID: <20200807125908.GH1551@shell.armlinux.org.uk> (raw)
In-Reply-To: <20200807122656.119574-1-linus.walleij@linaro.org>
On Fri, Aug 07, 2020 at 02:26:56PM +0200, Linus Walleij wrote:
> @@ -49,8 +49,10 @@
>
> #include CONFIG_DEBUG_LL_INCLUDE
>
> - .macro writeb, ch, rb
> + .macro writeb, ch, rb, tmp
> + waituart \tmp, \rb
> senduart \ch, \rb
> + busyuart \tmp, \rb
> .endm
This could likely cause problems.
waituart does things such as waiting for CTS to be asserted, and we
really don't want to block the decompressor if CTS is deasserted.
busyuart should be mostly fine though, provided the UART is actually
functional.
We haven't used either of these, we've relied on a software loop to
wait some time before queueing the next character.
--
RMK's Patch system: https://www.armlinux.org.uk/developer/patches/
FTTP is here! 40Mbps down 10Mbps up. Decent connectivity at last!
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
next prev parent reply other threads:[~2020-08-07 13:00 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-08-07 12:26 [PATCH] ARM: compress: Fix the debug prints Linus Walleij
2020-08-07 12:59 ` Russell King - ARM Linux admin [this message]
2020-08-09 20:49 ` Linus Walleij
2020-08-09 21:00 ` Russell King - ARM Linux admin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200807125908.GH1551@shell.armlinux.org.uk \
--to=linux@armlinux.org.uk \
--cc=ardb@kernel.org \
--cc=fabrizio.castro@bp.renesas.com \
--cc=linus.walleij@linaro.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=nico@fluxnic.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).