From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.5 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id EE9E3C433DF for ; Fri, 7 Aug 2020 13:00:50 +0000 (UTC) Received: from merlin.infradead.org (merlin.infradead.org [205.233.59.134]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id B7521221E2 for ; Fri, 7 Aug 2020 13:00:50 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="q6sK86ab"; dkim=fail reason="signature verification failed" (2048-bit key) header.d=armlinux.org.uk header.i=@armlinux.org.uk header.b="ts/wkO1E" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org B7521221E2 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=armlinux.org.uk Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=merlin.20170209; h=Sender:Content-Transfer-Encoding: Content-Type:Cc:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References:Message-ID: Subject:To:From:Date:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=pAye2G0FTWg/EjKqOrLZLVRUvJv5FCn8KUrQs3C+PWc=; b=q6sK86abovfKcyOfv59CtM4Gr 2zHndo71rOC/KlS6/rTo5ioKkoaiiki4IX+Ulr2+kulWWWgHJd+qtB93GD+xj+Hi6pbaIMtKTzK9K rEW+mRExKe+0zGXORoJEk2+tchn//0x40/ipOoPlZdW16fUr6LmFo1S6iRxbvERicf4fIfGS5QN56 xSLji57SiiaF7a4JXfTSZJnRCEszZqldJr9T1SlQK678wpWehfdaElqnDdSnivnFh//aRu8Ea05cA QZqziAqMtZeAQLpC6r4POt2HzTESf9zArMzIgh9TQkndkBe87trjHSi8Sq23qcNdn/LPLdKK7VqGu 2QnWB64Lw==; Received: from localhost ([::1] helo=merlin.infradead.org) by merlin.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1k41xs-0006T5-08; Fri, 07 Aug 2020 12:59:16 +0000 Received: from pandora.armlinux.org.uk ([2001:4d48:ad52:32c8:5054:ff:fe00:142]) by merlin.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1k41xp-0006Sg-Nv for linux-arm-kernel@lists.infradead.org; Fri, 07 Aug 2020 12:59:14 +0000 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=armlinux.org.uk; s=pandora-2019; h=Sender:In-Reply-To:Content-Type: MIME-Version:References:Message-ID:Subject:Cc:To:From:Date:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Id: List-Help:List-Unsubscribe:List-Subscribe:List-Post:List-Owner:List-Archive; bh=DQHakSFEnw3yzQTVHkQdf8BRuXjeEZ1N5LdAdvTGUsU=; b=ts/wkO1EqzuJMLnfVro/143Sz +EmqldrA6hc5q/DNY61sUC/EqRjxaDkFjMdFAB4BDzlt5pEc+CtdOygh+01PtatZ1Tud6YVPWXcmd gkTeV4Ul19u0zA7196zw9dVje5nnYQR7CJZLyG7eyW90XhnaTtORMzAlwY9XJg+AFNMui/v2LQAAE f1QNXZh2/Cb6YCpfir+ZTodKpnp13vwEKD6RT5qd5xT4uDl3g9wORHJFoAU34WBLhcpWOS3VLFQ+A zE8ilxJjh5IfZhyos/Kqkwhf/v+Gl6yIcXD0ZlK9fGDnxMBBh3aBfKjitbJrJQJrigC7PpKSwhFFK L8MJTrzIg==; Received: from shell.armlinux.org.uk ([fd8f:7570:feb6:1:5054:ff:fe00:4ec]:49490) by pandora.armlinux.org.uk with esmtpsa (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1k41xm-0005vW-0o; Fri, 07 Aug 2020 13:59:10 +0100 Received: from linux by shell.armlinux.org.uk with local (Exim 4.92) (envelope-from ) id 1k41xk-0007D9-6A; Fri, 07 Aug 2020 13:59:08 +0100 Date: Fri, 7 Aug 2020 13:59:08 +0100 From: Russell King - ARM Linux admin To: Linus Walleij Subject: Re: [PATCH] ARM: compress: Fix the debug prints Message-ID: <20200807125908.GH1551@shell.armlinux.org.uk> References: <20200807122656.119574-1-linus.walleij@linaro.org> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20200807122656.119574-1-linus.walleij@linaro.org> User-Agent: Mutt/1.10.1 (2018-07-13) X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20200807_085913_842747_3697CE15 X-CRM114-Status: GOOD ( 10.61 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Fabrizio Castro , Ard Biesheuvel , linux-arm-kernel@lists.infradead.org, Nicolas Pitre Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Fri, Aug 07, 2020 at 02:26:56PM +0200, Linus Walleij wrote: > @@ -49,8 +49,10 @@ > > #include CONFIG_DEBUG_LL_INCLUDE > > - .macro writeb, ch, rb > + .macro writeb, ch, rb, tmp > + waituart \tmp, \rb > senduart \ch, \rb > + busyuart \tmp, \rb > .endm This could likely cause problems. waituart does things such as waiting for CTS to be asserted, and we really don't want to block the decompressor if CTS is deasserted. busyuart should be mostly fine though, provided the UART is actually functional. We haven't used either of these, we've relied on a software loop to wait some time before queueing the next character. -- RMK's Patch system: https://www.armlinux.org.uk/developer/patches/ FTTP is here! 40Mbps down 10Mbps up. Decent connectivity at last! _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel