From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-7.0 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id DFEADC433DF for ; Sat, 8 Aug 2020 15:31:33 +0000 (UTC) Received: from merlin.infradead.org (merlin.infradead.org [205.233.59.134]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id AB59F2073E for ; Sat, 8 Aug 2020 15:31:33 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="dAWtyDe2"; dkim=fail reason="signature verification failed" (1024-bit key) header.d=kernel.org header.i=@kernel.org header.b="EYMDmSt0" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org AB59F2073E Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=linuxfoundation.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=merlin.20170209; h=Sender:Content-Transfer-Encoding: Content-Type:Cc:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References:Message-ID: Subject:To:From:Date:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=J6m05uLnXA0pOKdzZAIGlPL1QoxKAudxHYcJEgW0EdE=; b=dAWtyDe2NObwlgc40hVJNlRoo zO3aD0dxcwdMLFqjnhuzP2HXH4UnghbcLXQ0Axt9oU6f+nwMYi+nP5+JSGn5d/CXi3AAD/Gy6ajQy OHLxnzPm4gxQoEON/CcRf9j+YCKrDv7lhrRl5y2uLXY1dvmqUSk/GuaM9r/dWgXdN8wimDCclOnZ8 TNFZVr9zgnsUHEZs1d5RnT0RsKt2pVK5DBglPJvFx7v3LlbJbc+TPFPIgSjuDeX//kPQpUiUzymbt qiLeFsRvi3332FY76tasU57v7kTAfzHQyU4uzTZFr1KKRJc0rJQrFlDThjh0DKsInnZ72DRqEwvSS RmqQGUfmw==; Received: from localhost ([::1] helo=merlin.infradead.org) by merlin.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1k4Qn7-0007vY-Pj; Sat, 08 Aug 2020 15:29:49 +0000 Received: from mail.kernel.org ([198.145.29.99]) by merlin.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1k4Qn4-0007v8-Rq for linux-arm-kernel@lists.infradead.org; Sat, 08 Aug 2020 15:29:47 +0000 Received: from localhost (83-86-89-107.cable.dynamic.v4.ziggo.nl [83.86.89.107]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 1B3EB2070A; Sat, 8 Aug 2020 15:29:44 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1596900585; bh=zF/xJR2FOJwu4V30N6nLpSiw1LpaGSCuquAHMuvzg7I=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=EYMDmSt0iFDI3O+5p6pz8AChEXtEZUpYqjz0keW07x5+UckLp0Prc44ANBEgBGaGq vJq1VZQOTib+9FCXbU590eCvBSKTSkynP00ZWGtDncP3x5rBdy0/KKom+5vW7sLs8k O1CWMljrh4wd5CH4qUyd/SFC3dhkyY0CMeAaxOOM= Date: Sat, 8 Aug 2020 17:29:58 +0200 From: Greg Kroah-Hartman To: Catalin Marinas Subject: Re: [PATCH] fix arm64 build with lack of __cpu_logical_map exported Message-ID: <20200808152958.GB369184@kroah.com> References: <20200808124242.GA352821@kroah.com> <20200808150443.GA492@DESKTOP-O1885NU.localdomain> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20200808150443.GA492@DESKTOP-O1885NU.localdomain> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20200808_112947_005591_2BFB1BAE X-CRM114-Status: GOOD ( 17.73 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Mark Rutland , Gavin Shan , kernel-team@android.com, linux-kernel@vger.kernel.org, Sudeep Holla , Sumit Gupta , Will Deacon , linux-arm-kernel@lists.infradead.org Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Sat, Aug 08, 2020 at 04:05:00PM +0100, Catalin Marinas wrote: > Hi Greg, > > On Sat, Aug 08, 2020 at 02:42:42PM +0200, Greg Kroah-Hartman wrote: > > diff --git a/arch/arm64/kernel/setup.c b/arch/arm64/kernel/setup.c > > index 87e81d29e6fb..b421a4756793 100644 > > --- a/arch/arm64/kernel/setup.c > > +++ b/arch/arm64/kernel/setup.c > > @@ -275,6 +275,7 @@ static int __init reserve_memblock_reserved_regions(void) > > arch_initcall(reserve_memblock_reserved_regions); > > > > u64 __cpu_logical_map[NR_CPUS] = { [0 ... NR_CPUS-1] = INVALID_HWID }; > > +EXPORT_SYMBOL_GPL(__cpu_logical_map); > > This was still under discussion, Sudeep preferring an alternative in the > driver: > > http://lkml.kernel.org/r/20200727172744.GD8003@bogus > http://lkml.kernel.org/r/20200724131059.GB6521@bogus > > Sumit came with a new diff inline that fixes the driver instead of > exporting the __cpu_logical_map. > > https://lore.kernel.org/linux-arm-kernel/e3a4bc21-c334-4d48-90b5-aab8d187939e@nvidia.com/ Ok, but having a broken tree is not nice, how did this survive linux-next testing? > Sumit, Sudeep, is the above diff sufficient and can it go upstream? Note that MIPS already export this symbol, so perhaps the drivers that need it on that platform should also be fixed the same way? thanks, greg k-h _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel