From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.5 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 3EB4DC433DF for ; Sat, 8 Aug 2020 18:31:17 +0000 (UTC) Received: from merlin.infradead.org (merlin.infradead.org [205.233.59.134]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 0319A206B2 for ; Sat, 8 Aug 2020 18:31:17 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="JNsKQ/Vo" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 0319A206B2 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=arm.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=merlin.20170209; h=Sender:Content-Transfer-Encoding: Content-Type:Cc:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References:Message-ID: Subject:To:From:Date:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=tzrav+0/88jJ1mUxIF28yAqTYUl4usPo4Oh0sumdhfg=; b=JNsKQ/VoWD2lcGNZi1jWYbYd4 hsrsinHQjIJ5zIAq5QTKCBdP5Cp6Di/Bmr1NP55CkDZMgebjSEDinUGsosiw+Dy3OobSQ+kCEi/1d MqtsO+k6qmGXNIO+c0JS1T2wq5JeZNWJ3xFLzTXgMcBHxPJwuGdt9gIVUG7N1IEUZ3hgLIMGHfqbw pn3ji3fZgatfmAJRnlSeR9bo94+yyxs57nbuLDLSE1XlP4NyEtVDRqMdda4BLX9LPp9+SPE+8hoRU iuIiNV9ECDDeZRlWY+FDG5EZrMc15PS/ZYvGuHLXy5NjigbVdJZPLGcAlT51CtbKJfUg3vnHaqLgW cKyAv+4YQ==; Received: from localhost ([::1] helo=merlin.infradead.org) by merlin.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1k4Tar-0008J3-3X; Sat, 08 Aug 2020 18:29:21 +0000 Received: from foss.arm.com ([217.140.110.172]) by merlin.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1k4Tan-0008Ia-Vp for linux-arm-kernel@lists.infradead.org; Sat, 08 Aug 2020 18:29:19 +0000 Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id D507C1FB; Sat, 8 Aug 2020 11:29:11 -0700 (PDT) Received: from gaia (unknown [172.31.20.19]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id 8DB413F7D8; Sat, 8 Aug 2020 11:29:10 -0700 (PDT) Date: Sat, 8 Aug 2020 19:29:08 +0100 From: Catalin Marinas To: Greg Kroah-Hartman Subject: Re: [PATCH] fix arm64 build with lack of __cpu_logical_map exported Message-ID: <20200808182907.GA2073@gaia> References: <20200808124242.GA352821@kroah.com> <20200808150443.GA492@DESKTOP-O1885NU.localdomain> <20200808152958.GB369184@kroah.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20200808152958.GB369184@kroah.com> User-Agent: Mutt/1.10.1 (2018-07-13) X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20200808_142918_087837_049E42E5 X-CRM114-Status: GOOD ( 21.59 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Mark Rutland , Gavin Shan , kernel-team@android.com, linux-kernel@vger.kernel.org, Sudeep Holla , Sumit Gupta , Will Deacon , linux-arm-kernel@lists.infradead.org Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Sat, Aug 08, 2020 at 05:29:58PM +0200, Greg Kroah-Hartman wrote: > On Sat, Aug 08, 2020 at 04:05:00PM +0100, Catalin Marinas wrote: > > On Sat, Aug 08, 2020 at 02:42:42PM +0200, Greg Kroah-Hartman wrote: > > > diff --git a/arch/arm64/kernel/setup.c b/arch/arm64/kernel/setup.c > > > index 87e81d29e6fb..b421a4756793 100644 > > > --- a/arch/arm64/kernel/setup.c > > > +++ b/arch/arm64/kernel/setup.c > > > @@ -275,6 +275,7 @@ static int __init reserve_memblock_reserved_regions(void) > > > arch_initcall(reserve_memblock_reserved_regions); > > > > > > u64 __cpu_logical_map[NR_CPUS] = { [0 ... NR_CPUS-1] = INVALID_HWID }; > > > +EXPORT_SYMBOL_GPL(__cpu_logical_map); > > > > This was still under discussion, Sudeep preferring an alternative in the > > driver: > > > > http://lkml.kernel.org/r/20200727172744.GD8003@bogus > > http://lkml.kernel.org/r/20200724131059.GB6521@bogus > > > > Sumit came with a new diff inline that fixes the driver instead of > > exporting the __cpu_logical_map. > > > > https://lore.kernel.org/linux-arm-kernel/e3a4bc21-c334-4d48-90b5-aab8d187939e@nvidia.com/ > > Ok, but having a broken tree is not nice, how did this survive > linux-next testing? I guess defconfig worked ok since tegra194-cpufreq is not a module so we didn't bother much. The fault was reported for allmodconfig but the discussion didn't conclude. > > Sumit, Sudeep, is the above diff sufficient and can it go upstream? > > Note that MIPS already export this symbol, so perhaps the drivers that > need it on that platform should also be fixed the same way? I push Kefeng's patch to the arm64 for-next/core branch which exports cpu_logical_map() as a function. We can revert it later is the Tegra driver is fixed. I'll send Linus a pull request in a bit, once I finish testing the branch. -- Catalin _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel