From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.5 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS, USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 586BDC433E0 for ; Sun, 9 Aug 2020 08:45:44 +0000 (UTC) Received: from merlin.infradead.org (merlin.infradead.org [205.233.59.134]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 21B29206C0 for ; Sun, 9 Aug 2020 08:45:44 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="Dgb6gcYI" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 21B29206C0 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=kernel.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=merlin.20170209; h=Sender:Content-Transfer-Encoding: Content-Type:Cc:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References:Message-ID: Subject:To:From:Date:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=Qr3SYdFiIShppFUvcLfeweU+2lw45fedv/O1j7laCkE=; b=Dgb6gcYIECgw1PLPpmbcZ+/CO S3IyFES0x0H6NdpHdOpRqTF9Mlavhw0cEhtd+FjsttyfoaekQAxsxgRhNROlNDIX/d9cTJZeAlaMq ZoSx2v0bm9Q4pYhBe9ia8Ug/ffoqEQS00LanJGs1ey/Qh8F1GmUqsa5LOLWuNEA4blVqGaaPHYgyr aJtKctlb1PA+fiOwoM8l5XXaZgRBnf80qmGJd/hub2H03Bds+x1Uq//f2DbdQkxAGG1mDZTLAgL7q KfwdrKu/xkEpRoIvWdyGpqcGSHDrrGvu19s19LCiQtZV8wOY0AIwu99cspcPE1cS3v6DnRL5Ds+x7 aBRr48IFQ==; Received: from localhost ([::1] helo=merlin.infradead.org) by merlin.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1k4gwC-0000GM-7q; Sun, 09 Aug 2020 08:44:16 +0000 Received: from mail-wr1-f65.google.com ([209.85.221.65]) by merlin.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1k4gw9-0000FU-GD for linux-arm-kernel@lists.infradead.org; Sun, 09 Aug 2020 08:44:14 +0000 Received: by mail-wr1-f65.google.com with SMTP id a15so5381578wrh.10 for ; Sun, 09 Aug 2020 01:44:11 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to:user-agent; bh=XTNoyFeYnEOkAJbw8iUBzSkCy3+i9xEDKg6ExpJpe58=; b=gC9vx+yMU8iR6K7ll6xwNKsunUYKC0CzLOeKdaA4kVwcHooAM/BOOADUVgBRtUveHm 4X1OkNmqAB6IxlbRyStHO4sKX6l1xVkKddD4xABUkXwCpeFFS7Fe2rek6LpQZeU7EkRZ 1Mq6ZxwZKQqGUV83Ag82UozmncNWx8WnkVfuw/ma9SS/V22hf6FgX06UY+54QEZA8P+X 6VvgemgbYjSrpdrrWMrN5M8os0PppUWeaTYt0838jgjuPjqNBLeGNjKXHODl3fbjP6iR hbGy/nhxYV9BrrLwy/xaOfMpyCmFXbuYug+JAfHZbeblW94KM5qPM5t0AuFGbgliNDB8 QwdA== X-Gm-Message-State: AOAM531wwPUQV2U+OmBvRRCwA0PopgTxv7EcfyNttaczmnMH0/9q29sP En4lpu/Jxrq5H23aVSUUDFMhwm01LisXUA== X-Google-Smtp-Source: ABdhPJzR24fsvQn+bWapiKi1vT1VGMsKWHkAfPzOI1FgKJZqRX84iY++vZGIbOeWRK5zx5K/fvoPtQ== X-Received: by 2002:adf:fac8:: with SMTP id a8mr19817671wrs.368.1596962650201; Sun, 09 Aug 2020 01:44:10 -0700 (PDT) Received: from kozik-lap ([194.230.155.117]) by smtp.googlemail.com with ESMTPSA id d23sm16745787wmd.27.2020.08.09.01.44.08 (version=TLS1_2 cipher=ECDHE-ECDSA-CHACHA20-POLY1305 bits=256/256); Sun, 09 Aug 2020 01:44:09 -0700 (PDT) Date: Sun, 9 Aug 2020 10:44:07 +0200 From: Krzysztof Kozlowski To: Arnd Bergmann Subject: Re: [PATCH v2 09/41] usb: gadget: s3c-hsudc: remove platform header dependency Message-ID: <20200809084407.GA7722@kozik-lap> References: <20200806181932.2253-1-krzk@kernel.org> <20200806182059.2431-9-krzk@kernel.org> <87v9hupnf7.fsf@kernel.org> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.9.4 (2018-02-28) X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20200809_044413_590195_EB5BCD0F X-CRM114-Status: GOOD ( 25.58 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Felipe Balbi , Greg Kroah-Hartman , USB list , "linux-kernel@vger.kernel.org" , Russell King , Linux ARM Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Fri, Aug 07, 2020 at 07:42:30PM +0200, Arnd Bergmann wrote: > On Fri, Aug 7, 2020 at 3:59 PM Felipe Balbi wrote: > > Krzysztof Kozlowski writes: > > > > +#include > > > + > > > #define S3C2443_CLKREG(x) ((x) + S3C24XX_VA_CLKPWR) > > > > > > #define S3C2443_PLLCON_MDIVSHIFT 16 > > > @@ -184,5 +186,52 @@ s3c2443_get_epll(unsigned int pllval, unsigned int baseclk) > > > return (unsigned int)fvco; > > > } > > > > > > +static inline void s3c_hsudc_init_phy(void) > > > > This should, really, be a PHY driver under drivers/phy, since the goal > > is to make this platform-independent, might as well take the opportunity > > to introduce a proper driver, no? > > In theory, this is absolutely correct. I fear it will be hard to find anyone > to make a larger scale cleanup of the file however. As my old changelog > text says, there is only one board (smdk2416) in the kernel that registers > the device. My change was the minimum to keep it working during the > move to a multiplatform configuration, but if there is someone who has > the hardware and volunteers to make a proper phy driver, that would also > work. > > As the board only exists as a reference for other boards, but none of those > made it into the kernel, we could alternatively just decide to drop the > driver. There is also a .dts file for the board, which is lacking a device node > for the udc (and the driver lacks DT support), so that board file could also > be dropped then, leaving only the DT version as a reference for the SoC. All this is a work on a very old SoC with an unknown number of current/real users. I don't have the hardware to test so I would prefer to skip any big changes. As Arnd suggests, we could just drop this one board and the driver... or if it does not harm/bother to much we could keep it as is, just without platform header dependency. Someone still might be using it. Best regards, Krzysztof _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel