From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-7.2 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH, MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS, UNWANTED_LANGUAGE_BODY,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 42F4DC433DF for ; Mon, 10 Aug 2020 22:00:54 +0000 (UTC) Received: from merlin.infradead.org (merlin.infradead.org [205.233.59.134]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 0C0B0206C3 for ; Mon, 10 Aug 2020 22:00:53 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="S3moNfYN"; dkim=fail reason="signature verification failed" (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="HJCz+RFS" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 0C0B0206C3 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=linaro.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=merlin.20170209; h=Sender:Content-Transfer-Encoding: Content-Type:Cc:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References:Message-ID: Subject:To:From:Date:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=DQMNpp/nDPpHrH0UBIaxhZ9v3VaDtcARnaPBgzu1qFE=; b=S3moNfYNH3na/U5aixgICSTyZ cvJy9JYcpglrO+jEds9bqiO+TO9OdpehzfYd287ywb64G0+yd7R1ZiZfDZWZknb4rHQrErk9M3EZ3 tB4/k9+8X3whbVMskMQX187yLEq1Gxkm4WPH3Q9l1rUQScy0AiS1wMOjwGbrvI6l+hoJO6lDQ1IvJ uBJletVbXi+Sfc3LXYF2dldlN2uRGYAKOt/KYI6+1MsmgtIBk9sq9Exe2z0Ute1ZQNWiDSCxMSDmT 9AcRmiFSEXaR+iXh1nAWBbROELGCu+Rh/bCnWphoL+14ZrLhl5jiIb3RMf6tTZ98OP0bkhe3Ejddp fxRMY3D2g==; Received: from localhost ([::1] helo=merlin.infradead.org) by merlin.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1k5Fp4-0006sC-4D; Mon, 10 Aug 2020 21:59:14 +0000 Received: from mail-pl1-x644.google.com ([2607:f8b0:4864:20::644]) by merlin.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1k5Fp0-0006rD-Nt for linux-arm-kernel@lists.infradead.org; Mon, 10 Aug 2020 21:59:12 +0000 Received: by mail-pl1-x644.google.com with SMTP id p1so5814533pls.4 for ; Mon, 10 Aug 2020 14:59:09 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to; bh=M0Hgl/apzUGb6/DFALqVL+085I6rcZOP034hb6ICC0k=; b=HJCz+RFSvu8+IM6U1lcSiNrmlFHo/pMdjtbmrpcl47GVK1u/KNj+LBSop6qXp8Q5E9 5+4CSIOGIL52r6ax6QcZhhroF3huUomdSJVwpwuoiYf5dLtPRTQKB2V9jk1OnJEt06bX Y/R4H+Fie+SM5d1BUIN/Xo6BfYZ8fS6KpZ0l/6qbj+BYWbVNPfEcyzikPT5bl8MoeGdi edC5u8dJhWvBfc4Z2k6YnYHw4bJXNY2Bu8CqZIaFqtcJdCWwqQEQyZbFggQCc2rMckz2 oAl/4SDCcj/3FkKArm6S3ENZhWqZZpAbdJm9WxJyNkY4f/cJIPnd1iZQQkyy3PvHRMQC o67Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=M0Hgl/apzUGb6/DFALqVL+085I6rcZOP034hb6ICC0k=; b=BqJZBuW1p/65q6g+h2ekz05sh7qua8KrbSX1bQ10PDaV4N/oIaeX9NJcr+426hQDRv LxX8aUMehnlVD/WcEzTVlG9dQsHljxYX5j302Fl1LbDMhMjSkxjUnjSoE+SSB/gZAYwD JqsBm9ac7KvHyuzyixbHgHwr5bEhEKLGqbEm2mKgl61EKsTIqiRLV/MuX80T4vXJlm5C zvaFxHYQuhYol6qGvl1U6+ubeKpRT09eZHM8pyavFvcFRj08VLPlMMAWosdeX84y1w0V LIncUR+OpnwRkvymcogslDTaKmfNaDkt9UsDzp0SpdRR+soEn6aYVi93XsjkuZ6k2S4v SJag== X-Gm-Message-State: AOAM531PcCYwRQqbyir46XMJ2KmhFNfcmfADIx2LSaeOJoM0kkpfGqz6 0LeHL34e4ZxeDtIs2ul4fzfkOQ== X-Google-Smtp-Source: ABdhPJx0Y9yjQ6w7BpPCI+A4v7L45U49qP8UmkjUsv3DPoyZBXY9GYcwOTeT0CivKtImrrDLay6ckw== X-Received: by 2002:a17:902:d341:: with SMTP id l1mr25740490plk.134.1597096748287; Mon, 10 Aug 2020 14:59:08 -0700 (PDT) Received: from xps15 (S0106002369de4dac.cg.shawcable.net. [68.147.8.254]) by smtp.gmail.com with ESMTPSA id y20sm23279816pfn.183.2020.08.10.14.59.06 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 10 Aug 2020 14:59:06 -0700 (PDT) Date: Mon, 10 Aug 2020 15:59:05 -0600 From: Mathieu Poirier To: Tingwei Zhang Subject: Re: [PATCH v2] coresight: stm: support marked packet Message-ID: <20200810215905.GD3223977@xps15> References: <20200726023950.3804-1-tingwei@codeaurora.org> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20200726023950.3804-1-tingwei@codeaurora.org> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20200810_175911_071147_CBB989F3 X-CRM114-Status: GOOD ( 21.39 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: tsoni@codeaurora.org, Sai Prakash Ranjan , Suzuki K Poulose , Alexander Shishkin , coresight@lists.linaro.org, Mao Jinlong , linux-arm-kernel@lists.infradead.org Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Sun, Jul 26, 2020 at 10:39:50AM +0800, Tingwei Zhang wrote: > STP_PACKET_MARKED is not supported by STM currently. > Add STM_FLAG_MARKED to support marked packet in STM. > > Signed-off-by: Tingwei Zhang > --- > drivers/hwtracing/coresight/coresight-stm.c | 11 +++++++---- > include/uapi/linux/coresight-stm.h | 1 + > 2 files changed, 8 insertions(+), 4 deletions(-) > > diff --git a/drivers/hwtracing/coresight/coresight-stm.c b/drivers/hwtracing/coresight/coresight-stm.c > index b908ca104645..f1969051a6aa 100644 > --- a/drivers/hwtracing/coresight/coresight-stm.c > +++ b/drivers/hwtracing/coresight/coresight-stm.c > @@ -412,6 +412,7 @@ static ssize_t notrace stm_generic_packet(struct stm_data *stm_data, > void __iomem *ch_addr; > struct stm_drvdata *drvdata = container_of(stm_data, > struct stm_drvdata, stm); > + unsigned int stm_flags; > > if (!(drvdata && local_read(&drvdata->mode))) > return -EACCES; > @@ -421,8 +422,9 @@ static ssize_t notrace stm_generic_packet(struct stm_data *stm_data, > > ch_addr = stm_channel_addr(drvdata, channel); > > - flags = (flags == STP_PACKET_TIMESTAMPED) ? STM_FLAG_TIMESTAMPED : 0; > - flags |= test_bit(channel, drvdata->chs.guaranteed) ? > + stm_flags = (flags & STP_PACKET_TIMESTAMPED) ? > + STM_FLAG_TIMESTAMPED : 0; > + stm_flags |= test_bit(channel, drvdata->chs.guaranteed) ? > STM_FLAG_GUARANTEED : 0; > > if (size > drvdata->write_bytes) > @@ -432,7 +434,7 @@ static ssize_t notrace stm_generic_packet(struct stm_data *stm_data, > > switch (packet) { > case STP_PACKET_FLAG: > - ch_addr += stm_channel_off(STM_PKT_TYPE_FLAG, flags); > + ch_addr += stm_channel_off(STM_PKT_TYPE_FLAG, stm_flags); > > /* > * The generic STM core sets a size of '0' on flag packets. > @@ -444,7 +446,8 @@ static ssize_t notrace stm_generic_packet(struct stm_data *stm_data, > break; > > case STP_PACKET_DATA: > - ch_addr += stm_channel_off(STM_PKT_TYPE_DATA, flags); > + stm_flags |= (flags & STP_PACKET_MARKED) ? STM_FLAG_MARKED : 0; > + ch_addr += stm_channel_off(STM_PKT_TYPE_DATA, stm_flags); Much better - I have applied this patch to my local tree. It will be published next week when 5.9-rc1 is released. Thanks, Mathieu > stm_send(ch_addr, payload, size, > drvdata->write_bytes); > break; > diff --git a/include/uapi/linux/coresight-stm.h b/include/uapi/linux/coresight-stm.h > index 8847dbf24151..7ff3709c01b8 100644 > --- a/include/uapi/linux/coresight-stm.h > +++ b/include/uapi/linux/coresight-stm.h > @@ -5,6 +5,7 @@ > #include > > #define STM_FLAG_TIMESTAMPED _BITUL(3) > +#define STM_FLAG_MARKED _BITUL(4) > #define STM_FLAG_GUARANTEED _BITUL(7) > > /* > -- > The Qualcomm Innovation Center, Inc. is a member of the Code Aurora Forum, > a Linux Foundation Collaborative Project > _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel