From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.5 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE, SPF_PASS,URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 42F4FC433DF for ; Tue, 11 Aug 2020 12:38:31 +0000 (UTC) Received: from merlin.infradead.org (merlin.infradead.org [205.233.59.134]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id EA62020756 for ; Tue, 11 Aug 2020 12:38:30 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="OHTFEa1b"; dkim=fail reason="signature verification failed" (1024-bit key) header.d=kernel.org header.i=@kernel.org header.b="uwuYb9or" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org EA62020756 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=kernel.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=merlin.20170209; h=Sender:Content-Transfer-Encoding: Content-Type:Cc:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References:Message-ID: Subject:To:From:Date:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=Ru2XKE4NMdyxlw+z/8b/BkNJ0WANX1KNfGlDA7U6dEU=; b=OHTFEa1b7MzmIAy+rrBQv+Ie9 FFmxj8svQ4Pds6b0K41dK9EusHZ8jc8xOV5ARI9uPqE+ldkpnNeeZM6OZ4kGM8vCLqPkrJxxxnfdB N+pCF4HdxNQcd5TJgOAwQogJhyrvexa9LVxPVgMGfoeHb+DrdAVr2H8p3FNTp30aXhFdwJODc/3ju vUfOkrkp7NuFApHfSb6hJ0Hq1StoQtvawbWzdonr+llkXOgu1sJtIFYzaZom7GTW2xXAysA0h9qJp szrJq9k67Z1N7MkAxWz137TeTcBJDgfVULykUtuFoW/yBhytABJe0OR05/ZKMo16nAWkvwoHVlgan mUK8BWDAw==; Received: from localhost ([::1] helo=merlin.infradead.org) by merlin.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1k5TWc-0004DD-9S; Tue, 11 Aug 2020 12:37:06 +0000 Received: from mail.kernel.org ([198.145.29.99]) by merlin.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1k5TWZ-0004C8-Kj for linux-arm-kernel@lists.infradead.org; Tue, 11 Aug 2020 12:37:04 +0000 Received: from willie-the-truck (236.31.169.217.in-addr.arpa [217.169.31.236]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id CE72220756; Tue, 11 Aug 2020 12:37:01 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1597149422; bh=aj3OHVG7/rXzCnhpHmjC06NSadxzyG0lzSdEAOk0tGs=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=uwuYb9or3/CS7Jl65+FfoFkcgAIVPsyT/a1tkVXX8vTq2LL1M52m9TEPSsGVo7u2p FHXzXwETO6Gnzo16IxW3R1AM94tOqO9iADfLHkM4TEQ+j9Sm64RMJ9GJTy11xnvVN/ /FKA+GAnMMsXmadKrQbd9pNw/pnwbNaY78ZCd/fs= Date: Tue, 11 Aug 2020 13:36:58 +0100 From: Will Deacon To: peterz@infradead.org Subject: Re: lockdep splat ("possible circular locking dependency detected") with PL011 on 5.8 Message-ID: <20200811123657.GA7252@willie-the-truck> References: <20200811101313.GA6970@willie-the-truck> <20200811103841.GC2674@hirez.programming.kicks-ass.net> <20200811111713.GA7203@willie-the-truck> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20200811111713.GA7203@willie-the-truck> User-Agent: Mutt/1.10.1 (2018-07-13) X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20200811_083703_877463_4D2CBFD1 X-CRM114-Status: GOOD ( 21.14 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: gregkh@linuxfoundation.org, linux-kernel@vger.kernel.org, linux@armlinux.org.uk, linux-arm-kernel@lists.infradead.org, andre.przywara@arm.com Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Tue, Aug 11, 2020 at 12:17:13PM +0100, Will Deacon wrote: > On Tue, Aug 11, 2020 at 12:38:41PM +0200, peterz@infradead.org wrote: > > diff --git a/drivers/tty/serial/amba-pl011.c b/drivers/tty/serial/amba-pl011.c > > index 8efd7c2a34fe..1717790ece2b 100644 > > --- a/drivers/tty/serial/amba-pl011.c > > +++ b/drivers/tty/serial/amba-pl011.c > > @@ -308,8 +308,9 @@ static void pl011_write(unsigned int val, const struct uart_amba_port *uap, > > */ > > static int pl011_fifo_to_tty(struct uart_amba_port *uap) > > { > > - u16 status; > > unsigned int ch, flag, fifotaken; > > + int sysrq; > > + u16 status; > > > > for (fifotaken = 0; fifotaken != 256; fifotaken++) { > > status = pl011_read(uap, REG_FR); > > @@ -344,10 +345,12 @@ static int pl011_fifo_to_tty(struct uart_amba_port *uap) > > flag = TTY_FRAME; > > } > > > > - if (uart_handle_sysrq_char(&uap->port, ch & 255)) > > - continue; > > + spin_unlock(&uap->port.lock); > > + sysrq = uart_handle_sysrq_char(&uap->port, ch & 255); > > + spin_lock(&uap->port.lock); > > > > - uart_insert_char(&uap->port, ch, UART011_DR_OE, ch, flag); > > + if (!sysrq) > > + uart_insert_char(&uap->port, ch, UART011_DR_OE, ch, flag); > > } > > > > return fifotaken; > > Cheers, that seems to do the trick: > > Tested-by: Will Deacon > > but what I don't understand is why I haven't run into this before, and why > nobody else seems to be reporting it! > > I'll try some older kernels to see if it ever worked. I tried 5.4, 4.19, 4.14 and 4.9: 5.4 and 4.19 have the lockdep splat 4.14 doesn't have the splat, yet I don't see why (the driver code hasn't really changed) 4.9 magic sysrq doesn't work at all (no splat either though) Will _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel