From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-4.0 required=3.0 tests=BAYES_00,DKIM_ADSP_CUSTOM_MED, DKIM_SIGNED,DKIM_VALID,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS, URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 2B68DC433DF for ; Tue, 11 Aug 2020 19:33:33 +0000 (UTC) Received: from merlin.infradead.org (merlin.infradead.org [205.233.59.134]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id E4783206B2 for ; Tue, 11 Aug 2020 19:33:32 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="Sb/7dvnY"; dkim=fail reason="signature verification failed" (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="Zup5i22j" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org E4783206B2 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=gmail.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=merlin.20170209; h=Sender:Content-Transfer-Encoding: Content-Type:Cc:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References:Message-ID: Subject:To:From:Date:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=hA6WNkbYbYRLJEn1fJjRGg0SNFch8//ktK3Naq1DiLk=; b=Sb/7dvnYjjnjW6Fuv+eBTWjQy vV6F2AmvSqGblPX/LHpmcBBRw7cIR4wcC8Uz0xxrZKVeA3xMGDldqM1UYl0YOi5dyfG+ewn6K7mqn NaLbsb6E2y0Wdo3BnSQ5jchyCUoDznnIj11bgvyp3tC/+xewCGo+ApA78KncKW1AZ5e9zeTUw7Nfp LijB7XH7m5CT3IOaoKufBzTqRxDVOQZ0eYM70W//JkOfqubC6nfLe/GJwTyekFJCHNLgoyVAw9Uwt abUSgO9m9bVAINdNKZZuR6fGnSsex54squsZx4e5nLELQUwGGhxResvmiqyxfnyvwbCIeQjUuxYaB ZOfKkaToA==; Received: from localhost ([::1] helo=merlin.infradead.org) by merlin.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1k5a0L-00051h-PI; Tue, 11 Aug 2020 19:32:13 +0000 Received: from mail-pf1-x444.google.com ([2607:f8b0:4864:20::444]) by merlin.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1k5a0J-00050z-5f for linux-arm-kernel@lists.infradead.org; Tue, 11 Aug 2020 19:32:12 +0000 Received: by mail-pf1-x444.google.com with SMTP id u20so8164810pfn.0 for ; Tue, 11 Aug 2020 12:32:09 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to; bh=L1QCDqC1jeWEZjJgqKuh/PvlUoKdtPIRoCRlMgnSgkk=; b=Zup5i22jfTfst2Dd9AzeWzIIw+U7EsZCFQh3l8LsO9CjkJjfS3FJn20mcGyoGWKCbm VeUqLCo8GyxQ7xY9GfK9FlzIiVo6GY4rbzNgAo8c4F5/dx5BPM1UKzgHq97/RjraWvmc hjDQUGAeqD5EU9sCtHQY3+TjMETJtA5naF4CGkAk6uDWqtBucnajeCiASzxw2WHMF1Ov EVq4+EDngGWQZQ4Oq7Efz6tATDHiGyHPCPBQ7cqbIA3wdlcLH7+caOJTWIRX8RE+FIDr vg/JVUd+qXJv78k4MUs4IemYQpP/qqwK7sVKV8wqNWf2oSUsvMu65CuMgvNh0ou8Q0BB xCsg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=L1QCDqC1jeWEZjJgqKuh/PvlUoKdtPIRoCRlMgnSgkk=; b=hHeBJShtB6jMHIBCafLaaw9EGlNKaWaFWIarIoMmaLwmSxtz370lUP1mSneoQ6K0TU 7vN9rgF/j2yIE59//3S0Vym3UhHpine5ta/iDt7IyC4qF/9UTc2M2p1KkcEQc2UQRBgk H/ygGLnd8YY0gL8xIEkzvGoftzhgTPxXTCxxY8+CY6VPpcIPKdSe+Edac5gfEvxw1VKt gecw6uayD1ck61JIkRxXuFVkJmr4l1T6OGx1k/Ryx+/3dPY/kHaYmaQpG9hFoBZRGpj/ zJXKI2Lpb8gdBTLic48XS4iuhCrhRqUbmW/H+YGxIhK/rJ19wfOJC+fW3pWLkhkCdUVU QRKQ== X-Gm-Message-State: AOAM530E6rC/m0bdMtPKgCpvyI3G7NDqq3Cj8/w/4Mlstkp0hXfabpY2 NPxT8d6DdGIbKY+1nZgsGQ== X-Google-Smtp-Source: ABdhPJyaa+AyUu5yMrX2PZZf5f/8RCTfXLIoKqj+U5eWAsuHEVf1Sm0q44cbwOoWVGmUMdkdq6HnTg== X-Received: by 2002:aa7:8608:: with SMTP id p8mr7464007pfn.62.1597174327916; Tue, 11 Aug 2020 12:32:07 -0700 (PDT) Received: from u2004 (h175-177-040-128.catv02.itscom.jp. [175.177.40.128]) by smtp.gmail.com with ESMTPSA id d80sm27121218pfd.22.2020.08.11.12.32.03 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 11 Aug 2020 12:32:07 -0700 (PDT) Date: Wed, 12 Aug 2020 04:32:01 +0900 From: Naoya Horiguchi To: Qian Cai Subject: Re: [PATCH v6 00/12] HWPOISON: soft offline rework Message-ID: <20200811193201.GA1410457@u2004> References: <20200806184923.7007-1-nao.horiguchi@gmail.com> <20200810152254.GC5307@lca.pw> <20200811031139.GA7145@hori.linux.bs1.fc.nec.co.jp> <20200811173923.GA39857@lca.pw> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20200811173923.GA39857@lca.pw> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20200811_153211_236630_9BB70379 X-CRM114-Status: GOOD ( 16.55 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: "tony.luck@intel.com" , "david@redhat.com" , "catalin.marinas@arm.com" , "zeil@yandex-team.ru" , HORIGUCHI =?iso-2022-jp?B?TkFPWUEoGyRCS1k4fSEhRD5MaRsoQik=?= , "linux-kernel@vger.kernel.org" , "mhocko@kernel.org" , "linux-mm@kvack.org" , "aneesh.kumar@linux.vnet.ibm.com" , "akpm@linux-foundation.org" , "osalvador@suse.de" , "will@kernel.org" , "linux-arm-kernel@lists.infradead.org" , "mike.kravetz@oracle.com" Content-Type: text/plain; charset="iso-2022-jp" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Tue, Aug 11, 2020 at 01:39:24PM -0400, Qian Cai wrote: > On Tue, Aug 11, 2020 at 03:11:40AM +0000, HORIGUCHI NAOYA(堀口 直也) wrote: > > I'm still not sure why the test succeeded by reverting these because > > current mainline kernel provides similar mechanism to prevent reuse of > > soft offlined page. So this success seems to me something suspicious. > > > > To investigate more, I want to have additional info about the page states > > of the relevant pages after soft offlining. Could you collect it by the > > following steps? > > > > - modify random.c not to run hotplug_memory() in migrate_huge_hotplug_memory(), > > - compile it and run "./random 1" once, > > - to collect page state with hwpoisoned pages, run "./page-types -Nlr -b hwpoison", > > where page-types is available under tools/vm in kernel source tree. > > - choose a few pfns of soft offlined pages from kernel message > > "Soft offlining pfn ...", and run "./page-types -Nlr -a ". > > # ./page-types -Nlr -b hwpoison > offset len flags > 99a000 1 __________B________X_______________________ > 99c000 1 __________B________X_______________________ > 99e000 1 __________B________X_______________________ > 9a0000 1 __________B________X_______________________ > ba6000 1 __________B________X_______________________ > baa000 1 __________B________X_______________________ Thank you. It only shows 6 lines of records, which is unexpected to me because random.c iterates soft offline 2 hugepages with madvise() 1000 times. Somehow (maybe in arch specific way?) other hwpoisoned pages might be cleared? If they really are, the success of this test is a fake, and this patchset can be considered as a fix. > > Every single one of pfns was like this, > > # ./page-types -Nlr -a 0x99a000 > offset len flags > 99a000 1 __________B________X_______________________ > > # ./page-types -Nlr -a 0x99e000 > offset len flags > 99e000 1 __________B________X_______________________ > > # ./page-types -Nlr -a 0x99c000 > offset len flags > 99c000 1 __________B________X_______________________ _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel