From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-10.0 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH, MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id E8294C433E0 for ; Tue, 11 Aug 2020 19:58:06 +0000 (UTC) Received: from merlin.infradead.org (merlin.infradead.org [205.233.59.134]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id B048720782 for ; Tue, 11 Aug 2020 19:58:06 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="ilhZItGY"; dkim=fail reason="signature verification failed" (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="Qp530flH" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org B048720782 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=linaro.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=merlin.20170209; h=Sender:Content-Transfer-Encoding: Content-Type:Cc:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References:Message-ID: Subject:To:From:Date:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=U3aMdhbuVFfsvw4PFeAFUbq1gKV4igYrnnHSwSZjuBQ=; b=ilhZItGYvc3tjKARdlc5j7L4P eQ8LLA0JavaFqNaOIinTKsfep2eNMHvKZAZD5pYdkwvCQGH3ZgMO/SjhYTft+rKEuUc7+LlYKsRhY UhOLNrc2kQcaXDD0v83n012r1hWBn5UI0D+7DGkv7+QO4Xw4DshGNrA+e3eOxrNxpOsc2v5n/oR/l 9bJZVPUwVyTNjdFxWWbKfjAFcMUlL/8wQ9/lTfkZ3SR872r//hzyNMA8mt3chURs9vQQCPUu0tcWJ 2stkUXQslTW9WN5xqJbCNc/q82dILYMUOF4bizC5t6pk3GvZZAkxOfS0O5Lg63Ql7bcbcJyRZkfM0 JH4yKNM3Q==; Received: from localhost ([::1] helo=merlin.infradead.org) by merlin.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1k5aNu-0007vj-GD; Tue, 11 Aug 2020 19:56:34 +0000 Received: from mail-pl1-x643.google.com ([2607:f8b0:4864:20::643]) by merlin.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1k5aNr-0007vB-98 for linux-arm-kernel@lists.infradead.org; Tue, 11 Aug 2020 19:56:32 +0000 Received: by mail-pl1-x643.google.com with SMTP id r4so48540pls.2 for ; Tue, 11 Aug 2020 12:56:28 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to; bh=jSpZyl6zszveRQTb+X3U9qCb6qt2a47wW3ClpVmbJd4=; b=Qp530flHFX5VujI6zk3JRpc5NHS0opLYWMJdFxardQIeNKy0kHusBV2UjudiK3A/4d nhhJ7oBQKZ6dPIgZTqyjIwb2PYjNxf/8dXO0LCpeQh/2qJxRxpIku/gGymanLHhOJsy1 esS5XOfi4eJ93Bw3t3emRXrWxZh6+lZj0+EUeHdRJovtGI421LpFAVG73OAU8Wm38dwF Yvs2LPr7qeBJjl8N6xCV/LmhXVZeZPyhvIcIlVNVdRTRIYsjAprLT0GpUX5pJwMrZyvW MwElCRoigXVExeMWpHlCirPTR10nssTPHq+fhb4VqNW4sctT7PS2MvSBfBnd4wuC4mlz XWrA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=jSpZyl6zszveRQTb+X3U9qCb6qt2a47wW3ClpVmbJd4=; b=iTj1R3CqqqoF5S/4WWoG+7h6A74Owv/bPH7uB9rDMAsdYKzR4EaWGgeQHT8PmDZrAq qYdM6H68Rg90MPJezt6LPJGgXb/u5SWJHYMdHsA37J1lq5EChPirC0JdwBbbHdLhmXbs 0jMdI7zdSPvfv9D6E6I7M8Q6glhLxM/K2+EBRjQjo2UUMMiYR09Rv8AV80YYigf8wc7x 8Xlpun6bHs1rN+/oFL1HPMlrKpOyarX5tdqxtagUdX562UNMLdyCmgb1haGMC0BDlH0g iPUrESsyFWz/NQO8yLveJvc/Sdvl/rE+Ue2i5lOEZjOFbppA7BcXrHaGPiebqYUtL36h NMpQ== X-Gm-Message-State: AOAM530QUqyGBA8MOO3UJPKhQi4H6V2jKRvF9yIkUuDJYO08/pguX2EG KDaNw7ji/jE/qpgnVoR79/TuQA== X-Google-Smtp-Source: ABdhPJzEvYm0TmVimHvXEGe/uKF0y2jzt+VsiVIHOLfRm4O0wA7RC6raA0fGG6z0aao+n1UTTAZFJw== X-Received: by 2002:a17:90a:9f44:: with SMTP id q4mr2826417pjv.66.1597175787041; Tue, 11 Aug 2020 12:56:27 -0700 (PDT) Received: from xps15 (S0106002369de4dac.cg.shawcable.net. [68.147.8.254]) by smtp.gmail.com with ESMTPSA id h24sm21487728pgi.85.2020.08.11.12.56.25 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 11 Aug 2020 12:56:26 -0700 (PDT) Date: Tue, 11 Aug 2020 13:56:24 -0600 From: Mathieu Poirier To: Peng Fan Subject: Re: [PATCH 02/10] remoteproc: imx_rproc: correct err message Message-ID: <20200811195624.GA3370567@xps15> References: <20200724080813.24884-1-peng.fan@nxp.com> <20200724080813.24884-3-peng.fan@nxp.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20200724080813.24884-3-peng.fan@nxp.com> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20200811_155631_372698_19C8030E X-CRM114-Status: GOOD ( 18.98 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: devicetree@vger.kernel.org, festevam@gmail.com, s.hauer@pengutronix.de, linux-remoteproc@vger.kernel.org, linux-kernel@vger.kernel.org, bjorn.andersson@linaro.org, o.rempel@pengutronix.de, robh+dt@kernel.org, linux-imx@nxp.com, kernel@pengutronix.de, shawnguo@kernel.org, linux-arm-kernel@lists.infradead.org Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Fri, Jul 24, 2020 at 04:08:05PM +0800, Peng Fan wrote: > It is using devm_ioremap, so not devm_ioremap_resource. Correct > the error message and print out sa/size. > > Signed-off-by: Peng Fan > --- > drivers/remoteproc/imx_rproc.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/remoteproc/imx_rproc.c b/drivers/remoteproc/imx_rproc.c > index 8957ed271d20..3b3904ebac75 100644 > --- a/drivers/remoteproc/imx_rproc.c > +++ b/drivers/remoteproc/imx_rproc.c > @@ -268,7 +268,7 @@ static int imx_rproc_addr_init(struct imx_rproc *priv, > priv->mem[b].cpu_addr = devm_ioremap(&pdev->dev, > att->sa, att->size); > if (!priv->mem[b].cpu_addr) { > - dev_err(dev, "devm_ioremap_resource failed\n"); > + dev_err(dev, "devm_ioremap sa:0x%x size:0x%x failed\n", att->sa, att->size); I'm good with fixing the devm_ioremap part but please remove the address and size. Printing them provides little value because they come from the device configuration area that is private to the driver. That way we don't expose system information involuntarily. With that: Reviewed-by: Mathieu Poirier > return -ENOMEM; > } > priv->mem[b].sys_addr = att->sa; > -- > 2.16.4 > _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel