From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-10.0 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH, MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id F0CF3C433DF for ; Wed, 12 Aug 2020 08:49:05 +0000 (UTC) Received: from merlin.infradead.org (merlin.infradead.org [205.233.59.134]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id BD3412076B for ; Wed, 12 Aug 2020 08:49:05 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="ih/KD0wN" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org BD3412076B Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=bootlin.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=merlin.20170209; h=Sender:Content-Transfer-Encoding: Content-Type:Cc:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References:Message-ID: Subject:To:From:Date:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=0bYKWQR/4CdM2b7hVP7QhSURwQwrZBVsPTimHsysDDg=; b=ih/KD0wN0c1pfHBqdMTWRmn9j 3EUNkgk+qPQxcak4cPSAl51uLiSjpdsX3zgYlkhS/aL+TSmOVsI6mdE0nWsU7jxkUBuU54+WJp1Tz 2ApQGv28MGK4Q84Cl4g20W4NKeSiB59d0plzOGyQZZPD6JF6Fjl9P6FeTVOn3tiqhRlMkSqjH1NkV zTNeP8EbObHH00JMxoEftZuYCbFFYAfGCgFJuB8bA8nTiVajGH5kZHUscHVRwOszyhRsE59JKGqiH 8XL1+lyYmCrMqlU7EvaAQx7FwDyt6VOQfIuPrioxP+J70cAtiWYeI3DaoFggxsqDHvHQLG2LNloz/ hDCOR9ROw==; Received: from localhost ([::1] helo=merlin.infradead.org) by merlin.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1k5mQ7-0006js-SK; Wed, 12 Aug 2020 08:47:39 +0000 Received: from relay11.mail.gandi.net ([217.70.178.231]) by merlin.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1k5mQ5-0006ix-8a for linux-arm-kernel@lists.infradead.org; Wed, 12 Aug 2020 08:47:38 +0000 Received: from localhost (lfbn-lyo-1-1932-79.w90-66.abo.wanadoo.fr [90.66.108.79]) (Authenticated sender: alexandre.belloni@bootlin.com) by relay11.mail.gandi.net (Postfix) with ESMTPSA id 30E1C10000B; Wed, 12 Aug 2020 08:47:29 +0000 (UTC) Date: Wed, 12 Aug 2020 10:47:28 +0200 From: Alexandre Belloni To: Uwe =?iso-8859-1?Q?Kleine-K=F6nig?= Subject: Re: [PATCH] pwm: atmel: Make use of dev_err_probe() Message-ID: <20200812084728.GI3448@piout.net> References: <20200812080259.4431-1-u.kleine-koenig@pengutronix.de> <20200812082002.GD4354@dell> <20200812083204.kktnid63j6vefsky@pengutronix.de> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20200812083204.kktnid63j6vefsky@pengutronix.de> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20200812_044737_410710_3009ECD5 X-CRM114-Status: GOOD ( 25.93 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: linux-pwm@vger.kernel.org, Ludovic Desroches , Thierry Reding , kernel@pengutronix.de, Lee Jones , Claudiu Beznea , linux-arm-kernel@lists.infradead.org Content-Type: text/plain; charset="iso-8859-1" Content-Transfer-Encoding: quoted-printable Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On 12/08/2020 10:32:04+0200, Uwe Kleine-K=F6nig wrote: > On Wed, Aug 12, 2020 at 09:20:02AM +0100, Lee Jones wrote: > > On Wed, 12 Aug 2020, Uwe Kleine-K=F6nig wrote: > > = > > > Add an error message for failure points that currently lack a message > > > and convert dev_err to dev_err_probe() which does the right thing for > > > -EPROBE_DEFER. Also slightly simplify the error handling. > > > = > > > Signed-off-by: Uwe Kleine-K=F6nig > > > --- > > > drivers/pwm/pwm-atmel.c | 24 +++++++++++------------- > > > 1 file changed, 11 insertions(+), 13 deletions(-) > > > = > > > diff --git a/drivers/pwm/pwm-atmel.c b/drivers/pwm/pwm-atmel.c > > > index 6161e7e3e9ac..aa0b36695dc7 100644 > > > --- a/drivers/pwm/pwm-atmel.c > > > +++ b/drivers/pwm/pwm-atmel.c > > > @@ -415,17 +415,18 @@ static int atmel_pwm_probe(struct platform_devi= ce *pdev) > > > res =3D platform_get_resource(pdev, IORESOURCE_MEM, 0); > > > atmel_pwm->base =3D devm_ioremap_resource(&pdev->dev, res); > > > if (IS_ERR(atmel_pwm->base)) > > > - return PTR_ERR(atmel_pwm->base); > > > + return dev_err_probe(&pdev->dev, PTR_ERR(atmel_pwm->base), > > > + "Failed to remap register space\n"); > > = > > This is a regression. > > = > > devm_ioremap_resource() already emits and error message for !-ENOMEM. > > = > > -ENOMEM cases should fail silently. > = > ah right. Maybe dev_err_probe() should do this right, too? > = > > > atmel_pwm->clk =3D devm_clk_get(&pdev->dev, NULL); > > > if (IS_ERR(atmel_pwm->clk)) > > > - return PTR_ERR(atmel_pwm->clk); > > > + return dev_err_probe(&pdev->dev, PTR_ERR(atmel_pwm->clk), > > > + "Failed to get clock\n"); > > = > > Isn't dev_err_probe() only useful for drivers handling -EPROBE_DEFER? > = > devm_clk_get() might return -EPROBE_DEFER. > = If it did, you wouldn't be able to print this message. I' not sure it is worth adding so many checks for errors that will never happen. > > > ret =3D clk_prepare(atmel_pwm->clk); > > > - if (ret) { > > > - dev_err(&pdev->dev, "failed to prepare PWM clock\n"); > > > - return ret; > > > - } > > > + if (ret) > > > + return dev_err_probe(&pdev->dev, ret, > > > + "Failed to prepare PWM clock\n"); > > = > > As above. > = > I only checked quickly and didn't find an instance where clk_prepare can > return -EPROBE_DEFER, but even if it doesn't it works fine. Same here, clk_prepare will never fail but there is a check and a string that will never be used. In my opinion, this is simply a waste of space... -- = Alexandre Belloni, Bootlin Embedded Linux and Kernel engineering https://bootlin.com _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel