From: Lee Jones <lee.jones@linaro.org>
To: "Uwe Kleine-König" <u.kleine-koenig@pengutronix.de>
Cc: linux-pwm@vger.kernel.org,
Alexandre Belloni <alexandre.belloni@bootlin.com>,
Ludovic Desroches <ludovic.desroches@microchip.com>,
Thierry Reding <thierry.reding@gmail.com>,
kernel@pengutronix.de,
Claudiu Beznea <claudiu.beznea@microchip.com>,
linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH] pwm: atmel: Make use of dev_err_probe()
Date: Wed, 12 Aug 2020 10:36:21 +0100 [thread overview]
Message-ID: <20200812093621.GF4354@dell> (raw)
In-Reply-To: <20200812092539.fbpapvrwxbmzfi65@pengutronix.de>
On Wed, 12 Aug 2020, Uwe Kleine-König wrote:
> Hello Alexandre,
>
> On Wed, Aug 12, 2020 at 10:47:28AM +0200, Alexandre Belloni wrote:
> > On 12/08/2020 10:32:04+0200, Uwe Kleine-König wrote:
> > > On Wed, Aug 12, 2020 at 09:20:02AM +0100, Lee Jones wrote:
> > > > On Wed, 12 Aug 2020, Uwe Kleine-König wrote:
> > > > > atmel_pwm->clk = devm_clk_get(&pdev->dev, NULL);
> > > > > if (IS_ERR(atmel_pwm->clk))
> > > > > - return PTR_ERR(atmel_pwm->clk);
> > > > > + return dev_err_probe(&pdev->dev, PTR_ERR(atmel_pwm->clk),
> > > > > + "Failed to get clock\n");
> > > >
> > > > Isn't dev_err_probe() only useful for drivers handling -EPROBE_DEFER?
> > >
> > > devm_clk_get() might return -EPROBE_DEFER.
> >
> > If it did, you wouldn't be able to print this message.
>
> Why that? It probably won't make it to the console immediately, but once
> the clk is available the log buffer should be pushed out, shouldn't it?
>
> > I' not sure it is worth adding so many checks for errors that will
> > never happen.
>
> I'm sure this train of thought is unsustainable. And people will copy
> this code to platforms where this assumption might even be more wrong
> than on at91.
This driver was authored (and reviewed) with intricate knowledge of
the H/W. The current code is optimal for this device. This patch
regresses certain aspects such as binary size and code complexity.
Sorry, but it's a NACK from me, and sounds like one from Alexandre
too.
--
Lee Jones [李琼斯]
Senior Technical Lead - Developer Services
Linaro.org │ Open source software for Arm SoCs
Follow Linaro: Facebook | Twitter | Blog
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
next prev parent reply other threads:[~2020-08-12 9:38 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-08-12 8:02 [PATCH] pwm: atmel: Make use of dev_err_probe() Uwe Kleine-König
2020-08-12 8:20 ` Lee Jones
2020-08-12 8:32 ` Uwe Kleine-König
2020-08-12 8:47 ` Alexandre Belloni
2020-08-12 9:25 ` Uwe Kleine-König
2020-08-12 9:34 ` Alexandre Belloni
2020-08-12 9:36 ` Lee Jones [this message]
2020-08-12 8:47 ` Lee Jones
2020-08-12 9:40 ` Uwe Kleine-König
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200812093621.GF4354@dell \
--to=lee.jones@linaro.org \
--cc=alexandre.belloni@bootlin.com \
--cc=claudiu.beznea@microchip.com \
--cc=kernel@pengutronix.de \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-pwm@vger.kernel.org \
--cc=ludovic.desroches@microchip.com \
--cc=thierry.reding@gmail.com \
--cc=u.kleine-koenig@pengutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).