* [v2, 1/3] mmc: dt-bindings: Add resets/reset-names for Mediatek MMC bindings
2020-08-12 13:01 [v2, 0/3] add optional reset property arm64: dts: mt7622: add reset node for mmc device mmc: mediatek: add optional module reset property Documentation/devicetree/bindings/mmc/mtk-sd.txt | 2 ++ arch/arm64/boot/dts/mediatek/mt7622.dtsi | 2 ++ drivers/mmc/host/mtk-sd.c | 13 +++++++++++++ 3 files changed, 17 insertions(+) Wenbin Mei
@ 2020-08-12 13:01 ` Wenbin Mei
2020-08-12 13:25 ` [v2,1/3] " Greg KH
2020-08-12 13:01 ` [v2,2/3] arm64: dts: mt7622: add reset node for mmc device Wenbin Mei
` (2 subsequent siblings)
3 siblings, 1 reply; 9+ messages in thread
From: Wenbin Mei @ 2020-08-12 13:01 UTC (permalink / raw)
To: Ulf Hansson, Rob Herring
Cc: devicetree, Wenbin Mei, srv_heupstream, linux-mmc, linux-kernel,
stable, linux-mediatek, linux-arm-kernel, Philipp Zabel,
Matthias Brugger, Chaotian Jing
Add description for resets/reset-names.
Signed-off-by: Wenbin Mei <wenbin.mei@mediatek.com>
---
Documentation/devicetree/bindings/mmc/mtk-sd.txt | 2 ++
1 file changed, 2 insertions(+)
diff --git a/Documentation/devicetree/bindings/mmc/mtk-sd.txt b/Documentation/devicetree/bindings/mmc/mtk-sd.txt
index 8a532f4453f2..15d42595a3f3 100644
--- a/Documentation/devicetree/bindings/mmc/mtk-sd.txt
+++ b/Documentation/devicetree/bindings/mmc/mtk-sd.txt
@@ -49,6 +49,8 @@ Optional properties:
error caused by stop clock(fifo full)
Valid range = [0:0x7]. if not present, default value is 0.
applied to compatible "mediatek,mt2701-mmc".
+- resets: Phandle and reset specifier pair to softreset line of MSDC IP.
+- reset-names: should be "hrst".
Examples:
mmc0: mmc@11230000 {
--
2.18.0
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
^ permalink raw reply related [flat|nested] 9+ messages in thread* Re: [v2,1/3] mmc: dt-bindings: Add resets/reset-names for Mediatek MMC bindings
2020-08-12 13:01 ` [v2, 1/3] mmc: dt-bindings: Add resets/reset-names for Mediatek MMC bindings Wenbin Mei
@ 2020-08-12 13:25 ` Greg KH
0 siblings, 0 replies; 9+ messages in thread
From: Greg KH @ 2020-08-12 13:25 UTC (permalink / raw)
To: Wenbin Mei
Cc: devicetree, Ulf Hansson, srv_heupstream, linux-mmc, linux-kernel,
stable, Rob Herring, linux-mediatek, linux-arm-kernel,
Philipp Zabel, Matthias Brugger, Chaotian Jing
On Wed, Aug 12, 2020 at 09:01:27PM +0800, Wenbin Mei wrote:
> Add description for resets/reset-names.
>
> Signed-off-by: Wenbin Mei <wenbin.mei@mediatek.com>
> ---
> Documentation/devicetree/bindings/mmc/mtk-sd.txt | 2 ++
> 1 file changed, 2 insertions(+)
>
> diff --git a/Documentation/devicetree/bindings/mmc/mtk-sd.txt b/Documentation/devicetree/bindings/mmc/mtk-sd.txt
> index 8a532f4453f2..15d42595a3f3 100644
> --- a/Documentation/devicetree/bindings/mmc/mtk-sd.txt
> +++ b/Documentation/devicetree/bindings/mmc/mtk-sd.txt
> @@ -49,6 +49,8 @@ Optional properties:
> error caused by stop clock(fifo full)
> Valid range = [0:0x7]. if not present, default value is 0.
> applied to compatible "mediatek,mt2701-mmc".
> +- resets: Phandle and reset specifier pair to softreset line of MSDC IP.
> +- reset-names: should be "hrst".
>
> Examples:
> mmc0: mmc@11230000 {
> --
> 2.18.0
<formletter>
This is not the correct way to submit patches for inclusion in the
stable kernel tree. Please read:
https://www.kernel.org/doc/html/latest/process/stable-kernel-rules.html
for how to do this properly.
</formletter>
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
^ permalink raw reply [flat|nested] 9+ messages in thread
* [v2,2/3] arm64: dts: mt7622: add reset node for mmc device
2020-08-12 13:01 [v2, 0/3] add optional reset property arm64: dts: mt7622: add reset node for mmc device mmc: mediatek: add optional module reset property Documentation/devicetree/bindings/mmc/mtk-sd.txt | 2 ++ arch/arm64/boot/dts/mediatek/mt7622.dtsi | 2 ++ drivers/mmc/host/mtk-sd.c | 13 +++++++++++++ 3 files changed, 17 insertions(+) Wenbin Mei
2020-08-12 13:01 ` [v2, 1/3] mmc: dt-bindings: Add resets/reset-names for Mediatek MMC bindings Wenbin Mei
@ 2020-08-12 13:01 ` Wenbin Mei
2020-08-12 13:25 ` Greg KH
2020-08-12 13:01 ` [v2,3/3] mmc: mediatek: add optional module reset property Wenbin Mei
2020-08-12 13:25 ` [v2,0/3] add optional reset property arm64: dts: mt7622: add reset node for mmc device mmc: mediatek: add optional module reset property Documentation/devicetree/bindings/mmc/mtk-sd.txt | 2 ++ arch/arm64/boot/dts/mediatek/mt7622.dtsi | 2 ++ drivers/mmc/host/mtk-sd.c | 13 +++++++++++++ 3 files changed, 17 insertions(+) Greg KH
3 siblings, 1 reply; 9+ messages in thread
From: Wenbin Mei @ 2020-08-12 13:01 UTC (permalink / raw)
To: Ulf Hansson, Rob Herring
Cc: devicetree, Wenbin Mei, srv_heupstream, linux-mmc, linux-kernel,
stable, linux-mediatek, linux-arm-kernel, Philipp Zabel,
Matthias Brugger, Chaotian Jing
This commit adds reset node for mmc device.
Fixes: 966580ad236e ("mmc: mediatek: add support for MT7622 SoC")
Signed-off-by: Wenbin Mei <wenbin.mei@mediatek.com>
Tested-by: Frank Wunderlich <frank-w@public-files.de>
---
arch/arm64/boot/dts/mediatek/mt7622.dtsi | 2 ++
1 file changed, 2 insertions(+)
diff --git a/arch/arm64/boot/dts/mediatek/mt7622.dtsi b/arch/arm64/boot/dts/mediatek/mt7622.dtsi
index 1a39e0ef776b..5b9ec032ce8d 100644
--- a/arch/arm64/boot/dts/mediatek/mt7622.dtsi
+++ b/arch/arm64/boot/dts/mediatek/mt7622.dtsi
@@ -686,6 +686,8 @@
clocks = <&pericfg CLK_PERI_MSDC30_0_PD>,
<&topckgen CLK_TOP_MSDC50_0_SEL>;
clock-names = "source", "hclk";
+ resets = <&pericfg MT7622_PERI_MSDC0_SW_RST>;
+ reset-names = "hrst";
status = "disabled";
};
--
2.18.0
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
^ permalink raw reply related [flat|nested] 9+ messages in thread* Re: [v2,2/3] arm64: dts: mt7622: add reset node for mmc device
2020-08-12 13:01 ` [v2,2/3] arm64: dts: mt7622: add reset node for mmc device Wenbin Mei
@ 2020-08-12 13:25 ` Greg KH
0 siblings, 0 replies; 9+ messages in thread
From: Greg KH @ 2020-08-12 13:25 UTC (permalink / raw)
To: Wenbin Mei
Cc: devicetree, Ulf Hansson, srv_heupstream, linux-mmc, linux-kernel,
stable, Rob Herring, linux-mediatek, linux-arm-kernel,
Philipp Zabel, Matthias Brugger, Chaotian Jing
On Wed, Aug 12, 2020 at 09:01:28PM +0800, Wenbin Mei wrote:
> This commit adds reset node for mmc device.
>
> Fixes: 966580ad236e ("mmc: mediatek: add support for MT7622 SoC")
> Signed-off-by: Wenbin Mei <wenbin.mei@mediatek.com>
> Tested-by: Frank Wunderlich <frank-w@public-files.de>
> ---
> arch/arm64/boot/dts/mediatek/mt7622.dtsi | 2 ++
> 1 file changed, 2 insertions(+)
>
> diff --git a/arch/arm64/boot/dts/mediatek/mt7622.dtsi b/arch/arm64/boot/dts/mediatek/mt7622.dtsi
> index 1a39e0ef776b..5b9ec032ce8d 100644
> --- a/arch/arm64/boot/dts/mediatek/mt7622.dtsi
> +++ b/arch/arm64/boot/dts/mediatek/mt7622.dtsi
> @@ -686,6 +686,8 @@
> clocks = <&pericfg CLK_PERI_MSDC30_0_PD>,
> <&topckgen CLK_TOP_MSDC50_0_SEL>;
> clock-names = "source", "hclk";
> + resets = <&pericfg MT7622_PERI_MSDC0_SW_RST>;
> + reset-names = "hrst";
> status = "disabled";
> };
>
> --
> 2.18.0
<formletter>
This is not the correct way to submit patches for inclusion in the
stable kernel tree. Please read:
https://www.kernel.org/doc/html/latest/process/stable-kernel-rules.html
for how to do this properly.
</formletter>
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
^ permalink raw reply [flat|nested] 9+ messages in thread
* [v2,3/3] mmc: mediatek: add optional module reset property
2020-08-12 13:01 [v2, 0/3] add optional reset property arm64: dts: mt7622: add reset node for mmc device mmc: mediatek: add optional module reset property Documentation/devicetree/bindings/mmc/mtk-sd.txt | 2 ++ arch/arm64/boot/dts/mediatek/mt7622.dtsi | 2 ++ drivers/mmc/host/mtk-sd.c | 13 +++++++++++++ 3 files changed, 17 insertions(+) Wenbin Mei
2020-08-12 13:01 ` [v2, 1/3] mmc: dt-bindings: Add resets/reset-names for Mediatek MMC bindings Wenbin Mei
2020-08-12 13:01 ` [v2,2/3] arm64: dts: mt7622: add reset node for mmc device Wenbin Mei
@ 2020-08-12 13:01 ` Wenbin Mei
2020-08-12 13:25 ` Greg KH
2020-08-12 14:19 ` Aw: " Frank Wunderlich
2020-08-12 13:25 ` [v2,0/3] add optional reset property arm64: dts: mt7622: add reset node for mmc device mmc: mediatek: add optional module reset property Documentation/devicetree/bindings/mmc/mtk-sd.txt | 2 ++ arch/arm64/boot/dts/mediatek/mt7622.dtsi | 2 ++ drivers/mmc/host/mtk-sd.c | 13 +++++++++++++ 3 files changed, 17 insertions(+) Greg KH
3 siblings, 2 replies; 9+ messages in thread
From: Wenbin Mei @ 2020-08-12 13:01 UTC (permalink / raw)
To: Ulf Hansson, Rob Herring
Cc: devicetree, Wenbin Mei, srv_heupstream, linux-mmc, linux-kernel,
stable, linux-mediatek, linux-arm-kernel, Philipp Zabel,
Matthias Brugger, Chaotian Jing
This patch fixs eMMC-Access on mt7622/Bpi-64.
Before we got these Errors on mounting eMMC ion R64:
[ 48.664925] blk_update_request: I/O error, dev mmcblk0, sector 204800 op 0x1:(WRITE)
flags 0x800 phys_seg 1 prio class 0
[ 48.676019] Buffer I/O error on dev mmcblk0p1, logical block 0, lost sync page write
This patch adds a optional reset management for msdc.
Sometimes the bootloader does not bring msdc register
to default state, so need reset the msdc controller.
Fixes: 966580ad236e ("mmc: mediatek: add support for MT7622 SoC")
Signed-off-by: Wenbin Mei <wenbin.mei@mediatek.com>
Tested-by: Frank Wunderlich <frank-w@public-files.de>
---
drivers/mmc/host/mtk-sd.c | 13 +++++++++++++
1 file changed, 13 insertions(+)
diff --git a/drivers/mmc/host/mtk-sd.c b/drivers/mmc/host/mtk-sd.c
index 39e7fc54c438..2b243c03c9b2 100644
--- a/drivers/mmc/host/mtk-sd.c
+++ b/drivers/mmc/host/mtk-sd.c
@@ -22,6 +22,7 @@
#include <linux/slab.h>
#include <linux/spinlock.h>
#include <linux/interrupt.h>
+#include <linux/reset.h>
#include <linux/mmc/card.h>
#include <linux/mmc/core.h>
@@ -434,6 +435,7 @@ struct msdc_host {
struct msdc_save_para save_para; /* used when gate HCLK */
struct msdc_tune_para def_tune_para; /* default tune setting */
struct msdc_tune_para saved_tune_para; /* tune result of CMD21/CMD19 */
+ struct reset_control *reset;
};
static const struct mtk_mmc_compatible mt8135_compat = {
@@ -1516,6 +1518,12 @@ static void msdc_init_hw(struct msdc_host *host)
u32 val;
u32 tune_reg = host->dev_comp->pad_tune_reg;
+ if (!IS_ERR(host->reset)) {
+ reset_control_assert(host->reset);
+ usleep_range(10, 50);
+ reset_control_deassert(host->reset);
+ }
+
/* Configure to MMC/SD mode, clock free running */
sdr_set_bits(host->base + MSDC_CFG, MSDC_CFG_MODE | MSDC_CFG_CKPDN);
@@ -2273,6 +2281,11 @@ static int msdc_drv_probe(struct platform_device *pdev)
if (IS_ERR(host->src_clk_cg))
host->src_clk_cg = NULL;
+ host->reset = devm_reset_control_get_optional_exclusive(&pdev->dev,
+ "hrst");
+ if (PTR_ERR(host->reset) == -EPROBE_DEFER)
+ return PTR_ERR(host->reset);
+
host->irq = platform_get_irq(pdev, 0);
if (host->irq < 0) {
ret = -EINVAL;
--
2.18.0
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
^ permalink raw reply related [flat|nested] 9+ messages in thread* Re: [v2,3/3] mmc: mediatek: add optional module reset property
2020-08-12 13:01 ` [v2,3/3] mmc: mediatek: add optional module reset property Wenbin Mei
@ 2020-08-12 13:25 ` Greg KH
2020-08-12 14:19 ` Aw: " Frank Wunderlich
1 sibling, 0 replies; 9+ messages in thread
From: Greg KH @ 2020-08-12 13:25 UTC (permalink / raw)
To: Wenbin Mei
Cc: devicetree, Ulf Hansson, srv_heupstream, linux-mmc, linux-kernel,
stable, Rob Herring, linux-mediatek, linux-arm-kernel,
Philipp Zabel, Matthias Brugger, Chaotian Jing
On Wed, Aug 12, 2020 at 09:01:29PM +0800, Wenbin Mei wrote:
> This patch fixs eMMC-Access on mt7622/Bpi-64.
> Before we got these Errors on mounting eMMC ion R64:
> [ 48.664925] blk_update_request: I/O error, dev mmcblk0, sector 204800 op 0x1:(WRITE)
> flags 0x800 phys_seg 1 prio class 0
> [ 48.676019] Buffer I/O error on dev mmcblk0p1, logical block 0, lost sync page write
>
> This patch adds a optional reset management for msdc.
> Sometimes the bootloader does not bring msdc register
> to default state, so need reset the msdc controller.
>
> Fixes: 966580ad236e ("mmc: mediatek: add support for MT7622 SoC")
> Signed-off-by: Wenbin Mei <wenbin.mei@mediatek.com>
> Tested-by: Frank Wunderlich <frank-w@public-files.de>
> ---
> drivers/mmc/host/mtk-sd.c | 13 +++++++++++++
> 1 file changed, 13 insertions(+)
>
> diff --git a/drivers/mmc/host/mtk-sd.c b/drivers/mmc/host/mtk-sd.c
> index 39e7fc54c438..2b243c03c9b2 100644
> --- a/drivers/mmc/host/mtk-sd.c
> +++ b/drivers/mmc/host/mtk-sd.c
> @@ -22,6 +22,7 @@
> #include <linux/slab.h>
> #include <linux/spinlock.h>
> #include <linux/interrupt.h>
> +#include <linux/reset.h>
>
> #include <linux/mmc/card.h>
> #include <linux/mmc/core.h>
> @@ -434,6 +435,7 @@ struct msdc_host {
> struct msdc_save_para save_para; /* used when gate HCLK */
> struct msdc_tune_para def_tune_para; /* default tune setting */
> struct msdc_tune_para saved_tune_para; /* tune result of CMD21/CMD19 */
> + struct reset_control *reset;
> };
>
> static const struct mtk_mmc_compatible mt8135_compat = {
> @@ -1516,6 +1518,12 @@ static void msdc_init_hw(struct msdc_host *host)
> u32 val;
> u32 tune_reg = host->dev_comp->pad_tune_reg;
>
> + if (!IS_ERR(host->reset)) {
> + reset_control_assert(host->reset);
> + usleep_range(10, 50);
> + reset_control_deassert(host->reset);
> + }
> +
> /* Configure to MMC/SD mode, clock free running */
> sdr_set_bits(host->base + MSDC_CFG, MSDC_CFG_MODE | MSDC_CFG_CKPDN);
>
> @@ -2273,6 +2281,11 @@ static int msdc_drv_probe(struct platform_device *pdev)
> if (IS_ERR(host->src_clk_cg))
> host->src_clk_cg = NULL;
>
> + host->reset = devm_reset_control_get_optional_exclusive(&pdev->dev,
> + "hrst");
> + if (PTR_ERR(host->reset) == -EPROBE_DEFER)
> + return PTR_ERR(host->reset);
> +
> host->irq = platform_get_irq(pdev, 0);
> if (host->irq < 0) {
> ret = -EINVAL;
> --
> 2.18.0
<formletter>
This is not the correct way to submit patches for inclusion in the
stable kernel tree. Please read:
https://www.kernel.org/doc/html/latest/process/stable-kernel-rules.html
for how to do this properly.
</formletter>
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
^ permalink raw reply [flat|nested] 9+ messages in thread* Aw: [v2,3/3] mmc: mediatek: add optional module reset property
2020-08-12 13:01 ` [v2,3/3] mmc: mediatek: add optional module reset property Wenbin Mei
2020-08-12 13:25 ` Greg KH
@ 2020-08-12 14:19 ` Frank Wunderlich
1 sibling, 0 replies; 9+ messages in thread
From: Frank Wunderlich @ 2020-08-12 14:19 UTC (permalink / raw)
To: Wenbin Mei
Cc: devicetree, Ulf Hansson, Wenbin Mei, srv_heupstream, linux-mmc,
linux-kernel, stable, Rob Herring, linux-mediatek, Chaotian Jing,
Philipp Zabel, Matthias Brugger, linux-arm-kernel
Hi,
it looks like you missed Philipps comments in v1
for stable i guess you need only add Cc: Stable-line to signed-off-area (not add it to CC of mail), sorry my mistake
Cc: stable@vger.kernel.org
regards Frank
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
^ permalink raw reply [flat|nested] 9+ messages in thread
* Re: [v2,0/3] add optional reset property arm64: dts: mt7622: add reset node for mmc device mmc: mediatek: add optional module reset property Documentation/devicetree/bindings/mmc/mtk-sd.txt | 2 ++ arch/arm64/boot/dts/mediatek/mt7622.dtsi | 2 ++ drivers/mmc/host/mtk-sd.c | 13 +++++++++++++ 3 files changed, 17 insertions(+)
2020-08-12 13:01 [v2, 0/3] add optional reset property arm64: dts: mt7622: add reset node for mmc device mmc: mediatek: add optional module reset property Documentation/devicetree/bindings/mmc/mtk-sd.txt | 2 ++ arch/arm64/boot/dts/mediatek/mt7622.dtsi | 2 ++ drivers/mmc/host/mtk-sd.c | 13 +++++++++++++ 3 files changed, 17 insertions(+) Wenbin Mei
` (2 preceding siblings ...)
2020-08-12 13:01 ` [v2,3/3] mmc: mediatek: add optional module reset property Wenbin Mei
@ 2020-08-12 13:25 ` Greg KH
3 siblings, 0 replies; 9+ messages in thread
From: Greg KH @ 2020-08-12 13:25 UTC (permalink / raw)
To: Wenbin Mei
Cc: devicetree, Ulf Hansson, srv_heupstream, linux-mmc, linux-kernel,
stable, Rob Herring, linux-mediatek, linux-arm-kernel,
Philipp Zabel, Matthias Brugger, Chaotian Jing
On Wed, Aug 12, 2020 at 09:01:26PM +0800, Wenbin Mei wrote:
> --
> 2.18.0
I think something is wrong with your subject line :(
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
^ permalink raw reply [flat|nested] 9+ messages in thread