From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-4.0 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 1AFF1C433DF for ; Wed, 12 Aug 2020 14:39:49 +0000 (UTC) Received: from merlin.infradead.org (merlin.infradead.org [205.233.59.134]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id CDF0D20756 for ; Wed, 12 Aug 2020 14:39:48 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="P1doYHnp"; dkim=fail reason="signature verification failed" (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="nLRq/tZm" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org CDF0D20756 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=linaro.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=merlin.20170209; h=Sender:Content-Transfer-Encoding: Content-Type:Cc:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References:Message-ID: Subject:To:From:Date:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=Je+ikIkfKVkC82endt0U/cQadFOx8b3WPdp8pfSdZ3s=; b=P1doYHnpqppX5XpgoCRagzH0p zveZ4RgYUFCnRmH1C8s2PJGVHqpkFQ3Qd1uFZPe9LKmM24AfODU6YX8Gyrys1OXdVfm1TPbMvgL16 UABEvpNqe/opn7YZft5vJqs/1G92t7YShWT3rzkMPbjpuzYumLu9nuDtuweTTtq7U9DWW8ykEvw9s 48xz/wnxRDOfJwUawdLY7yLAXm4t27rSD0nLojdlqV+8mg3O4kjBVDmb2CI+Cww6seYu8/nAtyM26 nM1CIDA0qBZAcehymtUG4kHFU9V/6L7CGqFCTm4T8cL216EVQTI9JbYH/PtxK/JKCJUr72OeELLqI ggqu/dWog==; Received: from localhost ([::1] helo=merlin.infradead.org) by merlin.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1k5rtI-0004tF-Et; Wed, 12 Aug 2020 14:38:08 +0000 Received: from mail-ed1-x542.google.com ([2a00:1450:4864:20::542]) by merlin.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1k5rtE-0004sm-E4 for linux-arm-kernel@lists.infradead.org; Wed, 12 Aug 2020 14:38:05 +0000 Received: by mail-ed1-x542.google.com with SMTP id df16so1698667edb.9 for ; Wed, 12 Aug 2020 07:38:03 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to; bh=qdMjHh1PyQqOPAqC3XbTF/dXACb3TQgezEnJTlb9Y58=; b=nLRq/tZmo/mY7x4rSHyFvW0OKefz+OPcHo42WNAhv5ZgFq6ka+yaNNWVkwtkjpfx4N zqIwQit2oe+Y1AP3nWKYxfXH44pxHcGXfPqLNCGa9UGqzlQSMvC/lB4QTI50n1mdzR5N avJD9CPWq3B/AiPXmGlFwS9cIFofadmMpaZeVQ1llATBdhvnTMyJgVfaOcm8KG9rG93O gv/061FDDnxPUdOM7EZScAfzdvUg4ufvlKJeUv1OfJxsxZ0bg+1RXnLfJaYaBkRcMIgH BQ4eIh1k5KH1kBdoDouJHPu4dbM6tEwHKnp07eBO4NsbaE9iYIyTS5WOu/CKKL6aij/n V6Zg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=qdMjHh1PyQqOPAqC3XbTF/dXACb3TQgezEnJTlb9Y58=; b=BPdMHBL8dxsEERfXjEshV75w5Ah+pSltq4T+WSF1U8f4PuA2HhbvUVKPfXG3ONzf9Q UB/vgwYGvdXt41Vjctsskzvu98LM9n6DdoPrqMrpaCHvVtGisi/i6T866cb7j4+mPCnz PVfAwh6vBAfqdP+sC+mqJY8Af5QDsyTiVUeGDmBOudTqRCYfp3PQGdElGdfeinZaSjfi tTwfERajdfKzBa5/hI0lohoE6xY8QurRt2lJ71wQlmNWlQSQptSMIu8GTmv8LpadB+dQ NIoR43+ekVFb+IFhuYIYf4tm55yp0qxfPnY2eEYnmCZ+UQiEfq+VIA0tQYuSIdCPZ1uL 0dCQ== X-Gm-Message-State: AOAM531V4xZY1gfXhJFx+FjAN7OV7BxKK6AXfo34+0cPDiyqR9QYgZYa 4vMz4wB+RBLZK5pJfB9Cg+9MiQ== X-Google-Smtp-Source: ABdhPJwOjrPP80qNmG5FivbmMvcRnHg1AIqortuC4SHeap+6p6b5gZY/oAf9xGCntxkf+h8TLn6goA== X-Received: by 2002:aa7:d58b:: with SMTP id r11mr215000edq.302.1597243082914; Wed, 12 Aug 2020 07:38:02 -0700 (PDT) Received: from myrica ([2001:1715:4e26:a7e0:116c:c27a:3e7f:5eaf]) by smtp.gmail.com with ESMTPSA id b16sm1542753edy.73.2020.08.12.07.38.01 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 12 Aug 2020 07:38:02 -0700 (PDT) Date: Wed, 12 Aug 2020 16:37:46 +0200 From: Jean-Philippe Brucker To: Andrii Nakryiko Subject: Re: [PATCH bpf] libbpf: Handle GCC built-in types for Arm NEON Message-ID: <20200812143746.GB3112830@myrica> References: <20200810122835.2309026-1-jean-philippe@linaro.org> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20200812_103804_786471_9D9D9CB3 X-CRM114-Status: GOOD ( 17.37 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Song Liu , Daniel Borkmann , Jakov Petrina , john fastabend , Alexei Starovoitov , KP Singh , Yonghong Song , bpf , Andrii Nakryiko , Martin Lau , linux-arm-kernel Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Tue, Aug 11, 2020 at 08:30:06PM -0700, Andrii Nakryiko wrote: [...] > > + /* > > + * GCC emits typedefs to its internal __PolyXX_t types when compiling > > + * Arm SIMD intrinsics. Alias them to the same standard types as Clang. > > + */ > > + { "__Poly8_t", "unsigned char" }, > > + { "__Poly16_t", "unsigned short" }, > > + { "__Poly64_t", "unsigned long" }, > > In the diff ([0]) that Daniel referenced, seems like they are adding > poly64_t to ARM32. What prevents GCC from doing that (or maybe they've > already done that). So instead of making unreliable assumptions, let's > define it as "unsigned long long" instead? Agreed. When writing this I had an older version of the ACLE doc referenced in [0] and wanted to be consistent with the older clang typedefs. Thanks, Jean > > [0] https://reviews.llvm.org/D79711 > > > + { "__Poly128_t", "unsigned __int128" }, > > +}; > > + > > +static void btf_dump_emit_int_def(struct btf_dump *d, __u32 id, > > + const struct btf_type *t) > > +{ > > + const char *name = btf_dump_type_name(d, id); > > + int i; > > + > > + for (i = 0; i < ARRAY_SIZE(builtin_types); i++) { > > + if (strcmp(name, builtin_types[i][0]) == 0) { > > + btf_dump_printf(d, "typedef %s %s;\n\n", > > + builtin_types[i][1], name); > > + break; > > + } > > + } > > +} > > + > > static void btf_dump_emit_enum_fwd(struct btf_dump *d, __u32 id, > > const struct btf_type *t) > > { > > -- > > 2.27.0 > > _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel