From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.5 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE, SPF_PASS,USER_AGENT_SANE_2 autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 2761AC433DF for ; Wed, 12 Aug 2020 18:49:32 +0000 (UTC) Received: from merlin.infradead.org (merlin.infradead.org [205.233.59.134]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id EDE3E20774 for ; Wed, 12 Aug 2020 18:49:31 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="XRHDphnA"; dkim=fail reason="signature verification failed" (1024-bit key) header.d=kernel.org header.i=@kernel.org header.b="2Zp4sO+x" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org EDE3E20774 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=kernel.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=merlin.20170209; h=Sender:Content-Transfer-Encoding: Content-Type:Cc:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To:Message-ID: Subject:To:From:Date:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=zBa5nzH0SI8ig7m0/rB8k2c1FVB5x/GhSr1tf8pjRNE=; b=XRHDphnALryRdeGtjcqS+rcyf 4E83G0vJ7rz5I9pZp1IY8iQwZKNo5qiJzKRbw1pFz+cr0ZBa68KHgxQUsYT34nA1Q8spRST674lmO L9/RvDNGwWeNekMqRmXVJuhFOtrxTnOpVQBZN5J/17zqf/jZT5fcJo4pTz/ap4YhZqiNB39wXyMsP oCBRw7igxUDxUgN8mwYYi6pH1PRO9tbCsc06KnlabPiWE1Ps8f9TOAV4PdTV6paPvCh3dJssno1ul TVG9iSF74p5T0ltcHKfTSwsQtfmTt4lhO9mtF1/D3ch0Zi97Q/UpS/+b3+2Jt3e0HvaAnVnUGqZuI fNGs1qyhA==; Received: from localhost ([::1] helo=merlin.infradead.org) by merlin.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1k5vn6-0006i8-UM; Wed, 12 Aug 2020 18:48:00 +0000 Received: from mail.kernel.org ([198.145.29.99]) by merlin.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1k5vn4-0006hj-SX for linux-arm-kernel@lists.infradead.org; Wed, 12 Aug 2020 18:47:59 +0000 Received: from onda.lan (ip5f5ad5c5.dynamic.kabel-deutschland.de [95.90.213.197]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 6DCF52087C; Wed, 12 Aug 2020 18:47:54 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1597258077; bh=v/XlzfHL4Q72/njOg1/Q9GwW5syrcPhwcxwKUuKnTYo=; h=Date:From:To:Cc:Subject:In-Reply-To:References:From; b=2Zp4sO+xad3AfisPsiq3F/tr7slWvRTc07BpTBjN4wft0fhXyo/2SFHBjHG5Jg0eb xtzwHRcaFT3Jryk2XC7/2GdmmvIkziY3pT6L6613ow2VbIoDF2Hgd8GmAEsydhgCYZ OJo+5Z+LPt7fWv6JGlDkjt5PCgmRU+IT4XMlR9r0= Date: Wed, 12 Aug 2020 15:47:52 -0300 From: Mauro Carvalho Chehab To: Joe Perches Subject: Re: [PATCH 00/44] SPMI patches needed by Hikey 970 Message-ID: <20200812154752.3223b9d8@onda.lan> In-Reply-To: <305f0df155e89e0c626b8f7366c4ab5f6741aedd.camel@perches.com> References: <305f0df155e89e0c626b8f7366c4ab5f6741aedd.camel@perches.com> X-Mailer: Claws Mail 3.17.5 (GTK+ 2.24.32; x86_64-redhat-linux-gnu) MIME-Version: 1.0 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20200812_144759_052711_559DCADF X-CRM114-Status: GOOD ( 22.74 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: devel@driverdev.osuosl.org, devicetree@vger.kernel.org, Rob Herring , Stephen Boyd , Greg Kroah-Hartman , Mark Brown , Jonathan Cameron , linuxarm@huawei.com, Wei Xu , linux-kernel@vger.kernel.org, Rob Herring , linux-arm-msm@vger.kernel.org, mauro.chehab@huawei.com, Lee Jones , "David S. Miller" , linux-arm-kernel@lists.infradead.org Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org Em Wed, 12 Aug 2020 10:13:51 -0700 Joe Perches escreveu: > Perhaps these trivial bits on top: Sounds fine for me. Feel free to send it with your SOB, adding my reviewed by: Reviewed-by: Mauro Carvalho Chehab > --- > drivers/staging/hikey9xx/hi6421-spmi-pmic.c | 5 +++-- > drivers/staging/hikey9xx/hi6421v600-regulator.c | 6 +++--- > drivers/staging/hikey9xx/hisi-spmi-controller.c | 21 +++++++++++++-------- > 3 files changed, 19 insertions(+), 13 deletions(-) > > diff --git a/drivers/staging/hikey9xx/hi6421-spmi-pmic.c b/drivers/staging/hikey9xx/hi6421-spmi-pmic.c > index 76766e7b8bf9..9d73458ca65a 100644 > --- a/drivers/staging/hikey9xx/hi6421-spmi-pmic.c > +++ b/drivers/staging/hikey9xx/hi6421-spmi-pmic.c > @@ -99,7 +99,7 @@ int hi6421_spmi_pmic_write(struct hi6421_spmi_pmic *pmic, int reg, u32 val) > EXPORT_SYMBOL(hi6421_spmi_pmic_write); > > int hi6421_spmi_pmic_rmw(struct hi6421_spmi_pmic *pmic, int reg, > - u32 mask, u32 bits) > + u32 mask, u32 bits) > { > unsigned long flags; > u32 data; > @@ -130,7 +130,8 @@ static irqreturn_t hi6421_spmi_irq_handler(int irq, void *data) > hi6421_spmi_pmic_write(pmic, (i + pmic->irq_addr), pending); > > /* solve powerkey order */ > - if ((i == HISI_IRQ_KEY_NUM) && ((pending & HISI_IRQ_KEY_VALUE) == HISI_IRQ_KEY_VALUE)) { > + if ((i == HISI_IRQ_KEY_NUM) && > + ((pending & HISI_IRQ_KEY_VALUE) == HISI_IRQ_KEY_VALUE)) { > generic_handle_irq(pmic->irqs[HISI_IRQ_KEY_DOWN]); > generic_handle_irq(pmic->irqs[HISI_IRQ_KEY_UP]); > pending &= (~HISI_IRQ_KEY_VALUE); > diff --git a/drivers/staging/hikey9xx/hi6421v600-regulator.c b/drivers/staging/hikey9xx/hi6421v600-regulator.c > index 29ef6bcadd84..82635ff54a74 100644 > --- a/drivers/staging/hikey9xx/hi6421v600-regulator.c > +++ b/drivers/staging/hikey9xx/hi6421v600-regulator.c > @@ -227,7 +227,7 @@ static int hi6421_spmi_dt_parse(struct platform_device *pdev, > > ret = of_property_read_u32(np, "reg", &rdesc->enable_reg); > if (ret) { > - dev_err(dev, "missing reg property\nn"); > + dev_err(dev, "missing reg property\n"); > return ret; > } > > @@ -303,13 +303,13 @@ static int hi6421_spmi_dt_parse(struct platform_device *pdev, > */ > rdesc->vsel_mask = (1 << (fls(rdesc->n_voltages) - 1)) - 1; > > - dev_dbg(dev, "voltage selector settings: reg: 0x%x, mask: 0x%x", > + dev_dbg(dev, "voltage selector settings: reg: 0x%x, mask: 0x%x\n", > rdesc->vsel_reg, rdesc->vsel_mask); > > return 0; > } > > -static struct regulator_ops hi6421_spmi_ldo_rops = { > +static const struct regulator_ops hi6421_spmi_ldo_rops = { > .is_enabled = hi6421_spmi_regulator_is_enabled, > .enable = hi6421_spmi_regulator_enable, > .disable = hi6421_spmi_regulator_disable, > diff --git a/drivers/staging/hikey9xx/hisi-spmi-controller.c b/drivers/staging/hikey9xx/hisi-spmi-controller.c > index 583df10cbf1a..513d962b8bce 100644 > --- a/drivers/staging/hikey9xx/hisi-spmi-controller.c > +++ b/drivers/staging/hikey9xx/hisi-spmi-controller.c > @@ -102,7 +102,7 @@ static int spmi_controller_wait_for_done(struct device *dev, > return 0; > } > udelay(1); > - } while(timeout--); > + } while (timeout--); > > dev_err(dev, "%s: timeout, status 0x%x\n", __func__, status); > return -ETIMEDOUT; > @@ -121,7 +121,7 @@ static int spmi_read_cmd(struct spmi_controller *ctrl, > > if (bc > SPMI_CONTROLLER_MAX_TRANS_BYTES) { > dev_err(&ctrl->dev, > - "spmi_controller supports 1..%d bytes per trans, but:%ld requested", > + "spmi_controller supports 1..%d bytes per trans, but:%ld requested\n", > SPMI_CONTROLLER_MAX_TRANS_BYTES, bc); > return -EINVAL; > } > @@ -137,7 +137,7 @@ static int spmi_read_cmd(struct spmi_controller *ctrl, > op_code = SPMI_CMD_EXT_REG_READ_L; > break; > default: > - dev_err(&ctrl->dev, "invalid read cmd 0x%x", opc); > + dev_err(&ctrl->dev, "invalid read cmd 0x%x\n", opc); > return -EINVAL; > } > > @@ -157,7 +157,10 @@ static int spmi_read_cmd(struct spmi_controller *ctrl, > goto done; > > for (i = 0; bc > i * SPMI_PER_DATAREG_BYTE; i++) { > - data = readl(spmi_controller->base + chnl_ofst + SPMI_SLAVE_OFFSET * slave_id + SPMI_APB_SPMI_RDATA0_BASE_ADDR + i * SPMI_PER_DATAREG_BYTE); > + data = readl(spmi_controller->base + chnl_ofst + > + SPMI_SLAVE_OFFSET * slave_id + > + SPMI_APB_SPMI_RDATA0_BASE_ADDR + > + i * SPMI_PER_DATAREG_BYTE); > data = be32_to_cpu((__be32)data); > if ((bc - i * SPMI_PER_DATAREG_BYTE) >> 2) { > memcpy(buf, &data, sizeof(data)); > @@ -194,7 +197,7 @@ static int spmi_write_cmd(struct spmi_controller *ctrl, > > if (bc > SPMI_CONTROLLER_MAX_TRANS_BYTES) { > dev_err(&ctrl->dev, > - "spmi_controller supports 1..%d bytes per trans, but:%ld requested", > + "spmi_controller supports 1..%d bytes per trans, but:%ld requested\n", > SPMI_CONTROLLER_MAX_TRANS_BYTES, bc); > return -EINVAL; > } > @@ -210,7 +213,7 @@ static int spmi_write_cmd(struct spmi_controller *ctrl, > op_code = SPMI_CMD_EXT_REG_WRITE_L; > break; > default: > - dev_err(&ctrl->dev, "invalid write cmd 0x%x", opc); > + dev_err(&ctrl->dev, "invalid write cmd 0x%x\n", opc); > return -EINVAL; > } > > @@ -234,8 +237,10 @@ static int spmi_write_cmd(struct spmi_controller *ctrl, > } > > writel((u32)cpu_to_be32(data), > - spmi_controller->base + chnl_ofst + SPMI_APB_SPMI_WDATA0_BASE_ADDR + SPMI_PER_DATAREG_BYTE * i); > - }; > + spmi_controller->base + chnl_ofst + > + SPMI_APB_SPMI_WDATA0_BASE_ADDR + > + SPMI_PER_DATAREG_BYTE * i); > + } > > /* Start the transaction */ > writel(cmd, spmi_controller->base + chnl_ofst + SPMI_APB_SPMI_CMD_BASE_ADDR); > > _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel