From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-10.0 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH, MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 12A3EC433DF for ; Wed, 12 Aug 2020 18:00:04 +0000 (UTC) Received: from merlin.infradead.org (merlin.infradead.org [205.233.59.134]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id D7AC22078B for ; Wed, 12 Aug 2020 18:00:03 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="m3IPgyE/"; dkim=fail reason="signature verification failed" (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="CALUrwzG" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org D7AC22078B Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=linaro.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=merlin.20170209; h=Sender:Content-Transfer-Encoding: Content-Type:Cc:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References:Message-ID: Subject:To:From:Date:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=hwCqydHA/SXJn1SnAfHNHrzB8UiAgLyFRTu5bf40luQ=; b=m3IPgyE/rxgCtJcSSckEWWmiV Y4dfcGxtARtNg5FrF9ZFQk64uftzCfTBkQGOsg0HQplvGKhU0Suds+a4+NYSENNOr0fj00zSBDNg3 1XEXZCaMc2uibQqpl9RCkysbU/hxw/HgKiZeJw55OMNgjz3d1RtScLUunPGRyrZNGKBo68fdJKmog NA3ykcUrNkVAoPfNS4pbI8itMum+rjVQOOALjchFu9NaWzft+RUwj7S6IiQ47AEjawMKrNWC3FWhW LaIm+bOdlvUbR23ap+/zeFhSmiVgr3lmkCTIFb7h3EMTf8FR1y7taMSAIkMuMl7Sh28yI9QH2+Xuz 6X8w+CbBQ==; Received: from localhost ([::1] helo=merlin.infradead.org) by merlin.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1k5v1L-0002ox-Aa; Wed, 12 Aug 2020 17:58:39 +0000 Received: from mail-pf1-x443.google.com ([2607:f8b0:4864:20::443]) by merlin.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1k5v1I-0002oL-HZ for linux-arm-kernel@lists.infradead.org; Wed, 12 Aug 2020 17:58:37 +0000 Received: by mail-pf1-x443.google.com with SMTP id r11so1389180pfl.11 for ; Wed, 12 Aug 2020 10:58:36 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to; bh=B0H6JrpFZKHrSe4/CaFbeHqOKF81/jqJIJDBh7f3iSM=; b=CALUrwzGL1LbHJR3Li514OCQQLn9cfggMGSvzxRn1pOAg3iMWoN0BEIQlOeWJ65HMK QMJagl1cVNtbEj0Xvttru75/IrTBqfCLTVpPD8ud3RI846/Onu93HfIQ1bzqnMlFj3m1 tQGIPDWaDAQnWaewgc80vWZHk/HxD8+IMABuacAPjb97Z8NBz0m/QzTt7Km6mpgJCX7o 0tyBvleQvnR2ekK4k0d6AgA1l6cJUUxeB4QOD3uLM64gD3UDk6pBVoP4bEVovBikeNjY jfmZd+4dDzvI79KtMD+RM2saO5IcRXeM8++f6XT+ZN3kw5QCSbce0GoNmJQuXUe7lOUX xr/g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=B0H6JrpFZKHrSe4/CaFbeHqOKF81/jqJIJDBh7f3iSM=; b=SgL3BVWp0MBNrixw/Iyd+3TCwVYyThfqGpzImRfNTxKVhJ7BXOTmbxMOj4tQ8uGGte unFR1FlWs824lR6zx6dQW2Ag/CrOAnCvaK+6ETIZDQMaZ5PssVK5ix9ES883uBlv9YIm 6sSh2l2yZuRwtwFEaBDoCVQzpVW9vdJUE9oX33Ir3v3UOP3gVNdmjSFQxOxDYpx77VFr wSbw9E0ZnqcyBMze0pIf9CXXGFsbQ6ZVK9/ChpPkdEXwuPlV0il6ItDfZW9JYHM4YHtF lLbi2yNxOKGwVBTjkbnH7ury2WMSNFBjKu+XZI7Xf0DzR1NSb35bAgS/Fy8iXw64WfZY i30w== X-Gm-Message-State: AOAM531XyVLddJCu00Ij4mU9DjgJWk3zfh2z3bF00WdKRa2n5JiBq8D6 EuYKdLggxJfxg6/rmTzoFIQd7Q== X-Google-Smtp-Source: ABdhPJxq5PsMZrJL0dDBe1BIU9vP28oRzm7ary1N1tGR+wmE8YveazC6C+adKrJHDD58AoY03NrESA== X-Received: by 2002:a63:af01:: with SMTP id w1mr283769pge.23.1597255114544; Wed, 12 Aug 2020 10:58:34 -0700 (PDT) Received: from xps15 (S0106002369de4dac.cg.shawcable.net. [68.147.8.254]) by smtp.gmail.com with ESMTPSA id bt10sm2810539pjb.39.2020.08.12.10.58.33 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 12 Aug 2020 10:58:34 -0700 (PDT) Date: Wed, 12 Aug 2020 11:58:31 -0600 From: Mathieu Poirier To: Tingwei Zhang Subject: Re: [PATCH v8 04/24] coresight: add coresight prefix to barrier_pkt Message-ID: <20200812175831.GD3393195@xps15> References: <20200807111153.7784-1-tingwei@codeaurora.org> <20200807111153.7784-5-tingwei@codeaurora.org> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20200807111153.7784-5-tingwei@codeaurora.org> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20200812_135836_715025_5150ACA3 X-CRM114-Status: GOOD ( 23.72 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: tsoni@codeaurora.org, Sai Prakash Ranjan , Kim Phillips , Mao Jinlong , Suzuki K Poulose , Alexander Shishkin , Greg Kroah-Hartman , coresight@lists.linaro.org, Randy Dunlap , Mian Yousaf Kaukab , Russell King , Leo Yan , linux-arm-kernel@lists.infradead.org, Mike Leach Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Fri, Aug 07, 2020 at 07:11:33PM +0800, Tingwei Zhang wrote: > Add coresight prefix to make it specific. It will be a export symbol. > > Signed-off-by: Mian Yousaf Kaukab > Signed-off-by: Tingwei Zhang > Reviewed-by: Suzuki K Poulose > --- > drivers/hwtracing/coresight/coresight-etb10.c | 2 +- > drivers/hwtracing/coresight/coresight-priv.h | 8 ++++---- > drivers/hwtracing/coresight/coresight-tmc-etf.c | 2 +- > drivers/hwtracing/coresight/coresight.c | 3 ++- > 4 files changed, 8 insertions(+), 7 deletions(-) > > diff --git a/drivers/hwtracing/coresight/coresight-etb10.c b/drivers/hwtracing/coresight/coresight-etb10.c > index 03e3f2590191..04ee9cda988d 100644 > --- a/drivers/hwtracing/coresight/coresight-etb10.c > +++ b/drivers/hwtracing/coresight/coresight-etb10.c > @@ -525,7 +525,7 @@ static unsigned long etb_update_buffer(struct coresight_device *csdev, > > cur = buf->cur; > offset = buf->offset; > - barrier = barrier_pkt; > + barrier = coresight_barrier_pkt; > > for (i = 0; i < to_read; i += 4) { > buf_ptr = buf->data_pages[cur] + offset; > diff --git a/drivers/hwtracing/coresight/coresight-priv.h b/drivers/hwtracing/coresight/coresight-priv.h > index d801a2755432..dcb8aeb6af62 100644 > --- a/drivers/hwtracing/coresight/coresight-priv.h > +++ b/drivers/hwtracing/coresight/coresight-priv.h > @@ -66,8 +66,8 @@ static DEVICE_ATTR_RO(name) > #define coresight_simple_reg64(type, name, lo_off, hi_off) \ > __coresight_simple_func(type, NULL, name, lo_off, hi_off) > > -extern const u32 barrier_pkt[4]; > -#define CORESIGHT_BARRIER_PKT_SIZE (sizeof(barrier_pkt)) > +extern const u32 coresight_barrier_pkt[4]; > +#define CORESIGHT_BARRIER_PKT_SIZE (sizeof(coresight_barrier_pkt)) > > enum etm_addr_type { > ETM_ADDR_TYPE_NONE, > @@ -104,10 +104,10 @@ struct cs_buffers { > static inline void coresight_insert_barrier_packet(void *buf) > { > if (buf) > - memcpy(buf, barrier_pkt, CORESIGHT_BARRIER_PKT_SIZE); > + memcpy(buf, coresight_barrier_pkt, > + CORESIGHT_BARRIER_PKT_SIZE); Indentation problem. > } > > - > static inline void CS_LOCK(void __iomem *addr) > { > do { > diff --git a/drivers/hwtracing/coresight/coresight-tmc-etf.c b/drivers/hwtracing/coresight/coresight-tmc-etf.c > index 6375504ba8b0..44402d413ebb 100644 > --- a/drivers/hwtracing/coresight/coresight-tmc-etf.c > +++ b/drivers/hwtracing/coresight/coresight-tmc-etf.c > @@ -519,7 +519,7 @@ static unsigned long tmc_update_etf_buffer(struct coresight_device *csdev, > > cur = buf->cur; > offset = buf->offset; > - barrier = barrier_pkt; > + barrier = coresight_barrier_pkt; > > /* for every byte to read */ > for (i = 0; i < to_read; i += 4) { > diff --git a/drivers/hwtracing/coresight/coresight.c b/drivers/hwtracing/coresight/coresight.c > index e9c90f2de34a..310b1b825dd1 100644 > --- a/drivers/hwtracing/coresight/coresight.c > +++ b/drivers/hwtracing/coresight/coresight.c > @@ -53,7 +53,8 @@ static struct list_head *stm_path; > * beginning of the data collected in a buffer. That way the decoder knows that > * it needs to look for another sync sequence. > */ > -const u32 barrier_pkt[4] = {0x7fffffff, 0x7fffffff, 0x7fffffff, 0x7fffffff}; > +const u32 coresight_barrier_pkt[4] = { > + 0x7fffffff, 0x7fffffff, 0x7fffffff, 0x7fffffff}; As of kernel 5.8 lines up to 100 characters are allowed. No need to break this line. With that: Reviewed-by: Mathieu Poirier > > static int coresight_id_match(struct device *dev, void *data) > { > -- > The Qualcomm Innovation Center, Inc. is a member of the Code Aurora Forum, > a Linux Foundation Collaborative Project > _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel