From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-11.5 required=3.0 tests=BAYES_00, DKIM_ADSP_CUSTOM_MED,DKIM_SIGNED,DKIM_VALID,FREEMAIL_FORGED_FROMDOMAIN, FREEMAIL_FROM,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI, SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_2 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 19E62C433DF for ; Thu, 13 Aug 2020 07:44:14 +0000 (UTC) Received: from merlin.infradead.org (merlin.infradead.org [205.233.59.134]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id C30CA20771 for ; Thu, 13 Aug 2020 07:44:13 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="dMVu8yfd"; dkim=fail reason="signature verification failed" (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="oJLPTTsG" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org C30CA20771 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=gmail.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=merlin.20170209; h=Sender:Content-Type:Cc: List-Subscribe:List-Help:List-Post:List-Archive:List-Unsubscribe:List-Id: MIME-Version:References:In-Reply-To:Message-ID:Subject:To:From:Date:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=vyiY0oJyS8JbSVSeLVKEW7xjDXT/S6G9p3unA4WubcM=; b=dMVu8yfdw2K94ekt+uUW8bjPZ 4RG0h9vcTYH8TJCSz5WaSWm6JLE05F3+2KTJypnXi89y0FKkl94Eq2VAIoFduv/w0B3bYzFhbOJMm ZG67bBpuNZLrTbxI5XB1WNV6C3Djqf6as7wx7VjmjjueqtOnZBmdmXpuMC4yF9f06uo92hyaZC9CQ Op6kJ4p3qApIpJuco4B3h2/fZ+DQugywtpzCxk8JG2ZqY/lgfPHS6Q/yxeFnSsjLH8DVDHdLZA6hk Kqg927NR5Jo3aBhtWGuJTzfNtwi92LjjkRDJlId1ili/KB2zjrAiW6jt+laTQ42l9yXs0beW2MH9+ sZMGf8zzg==; Received: from localhost ([::1] helo=merlin.infradead.org) by merlin.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1k67st-00037T-7C; Thu, 13 Aug 2020 07:42:47 +0000 Received: from mail-lf1-x143.google.com ([2a00:1450:4864:20::143]) by merlin.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1k67sp-00035s-9R; Thu, 13 Aug 2020 07:42:44 +0000 Received: by mail-lf1-x143.google.com with SMTP id m15so2540132lfp.7; Thu, 13 Aug 2020 00:42:41 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=date:from:to:cc:subject:message-id:in-reply-to:references :mime-version; bh=P04R74Xbuv3cjdfHATnoRpjk3qHslmzAs9Kz3QNkQfc=; b=oJLPTTsGxz6PnYmSrTJva2uVysQlnxV9bp3OQUJKGqPQ1gMXfxSew4bgkYa1Drn+2x SfvkM9bonbTUWPkibOQVvSlbcpC2WlV8XlUeZ3vcqPGcIPPtIn1nueL2T6P18F9tKsMn g0gGu4+ykbU4iUs3u6LXFo95K3g3erlC77e8KGyze7XXEoIwDKWagbsXVHjvWB0CpVhz HLlzU+n8PW7cbV1cSU4hTUNUNfvaymmYLy0E9Y8Mmekqg2cUkOKzg4vYOpS/BtRCyTtT 5Ynen2DYuRpFVieJN3FIT8jNy7xHNYcv5n7gFIghbDkHpwc+V9N8jQmqoU4zDy93eyjD u0Hg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:in-reply-to :references:mime-version; bh=P04R74Xbuv3cjdfHATnoRpjk3qHslmzAs9Kz3QNkQfc=; b=D5kXsKLOYVKkgqMLmv4FMiM9+6N2ogfvJ9cZCLv+84yHa/A4W9WqndJ8oPuNyEUkPo kx5YEpEhI5iFqvfNfl/OifNiS+wlaNa5GdscVODynpWB3UCyeHVIjRz4fsb6TWJI237w E9I3vnZr/7W5Q8WgAnSyMbOJlgINGdxW1YykxPjwKyLOkcZgdgihge5MFcHznCazsEvA 27wPm2vjjT7O6gM8ZBwiuAnWPy/JTKAnkdPge6Jst/VIFgjT5Xe2aad04lzUAjIEPzFs f8uUtxy0rPC7qvmfp7WegKGPwAoqL7mSkTWs8Vum/Gx5hZ2YssRQw+q8bWgnhcKaZmqo iW5g== X-Gm-Message-State: AOAM533W6eaOKsUa/SmhxibhRrSHrGYMuolGjX0HpYHMR8fT4UpQZg2G tXkNx1cMORjgXo61/tA0SIA= X-Google-Smtp-Source: ABdhPJzkuy63Zsi7uwX6mtGwERx8H1BUWVdZaS3r4t8+xoqlBet6sAex+uApJPa7nzeYe/6nmRK5+Q== X-Received: by 2002:a05:6512:3317:: with SMTP id k23mr1577737lfe.111.1597304559520; Thu, 13 Aug 2020 00:42:39 -0700 (PDT) Received: from eldfell ([194.136.85.206]) by smtp.gmail.com with ESMTPSA id h13sm801102lji.134.2020.08.13.00.42.38 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 13 Aug 2020 00:42:38 -0700 (PDT) Date: Thu, 13 Aug 2020 10:42:28 +0300 From: Pekka Paalanen To: crj Subject: Re: [PATCH 4/6] drm/rockchip: dw_hdmi: Add vendor hdmi properties Message-ID: <20200813104228.096179e7@eldfell> In-Reply-To: <20200812133017.GJ6057@pendragon.ideasonboard.com> References: <20200812083120.743-1-algea.cao@rock-chips.com> <20200812083543.4231-1-algea.cao@rock-chips.com> <20200812093315.GE6057@pendragon.ideasonboard.com> <52cca26d-b2b3-22b2-f371-a8086f2e6336@rock-chips.com> <20200812133017.GJ6057@pendragon.ideasonboard.com> X-Mailer: Claws Mail 3.17.3 (GTK+ 2.24.32; x86_64-pc-linux-gnu) MIME-Version: 1.0 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20200813_034243_341445_A8E834D6 X-CRM114-Status: GOOD ( 30.45 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: jernej.skrabec@siol.net, laurent.pinchart+renesas@ideasonboard.com, jonas@kwiboo.se, airlied@linux.ie, sam@ravnborg.org, narmstrong@baylibre.com, hjc@rock-chips.com, dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org, a.hajda@samsung.com, Laurent Pinchart , tzimmermann@suse.de, cychiang@chromium.org, linux-rockchip@lists.infradead.org, darekm@google.com, kuankuan.y@gmail.com, linux-arm-kernel@lists.infradead.org, jbrunet@baylibre.com Content-Type: multipart/mixed; boundary="===============6650171460878315367==" Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org --===============6650171460878315367== Content-Type: multipart/signed; micalg=pgp-sha256; boundary="Sig_/=OONQgpVWkCqhFkncTg66Ye"; protocol="application/pgp-signature" --Sig_/=OONQgpVWkCqhFkncTg66Ye Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable On Wed, 12 Aug 2020 16:30:17 +0300 Laurent Pinchart wrote: > Hi Algea, >=20 > On Wed, Aug 12, 2020 at 07:08:10PM +0800, crj wrote: > > =E5=9C=A8 2020/8/12 17:33, Laurent Pinchart =E5=86=99=E9=81=93: =20 > > > On Wed, Aug 12, 2020 at 04:35:43PM +0800, Algea Cao wrote: =20 > > >> Introduce struct dw_hdmi_property_ops in plat_data to support > > >> vendor hdmi property. > > >> > > >> Implement hdmi vendor properties color_depth_property and > > >> hdmi_output_property to config hdmi output color depth and > > >> color format. > > >> > > >> The property "hdmi_output_format", the possible value > > >> could be: > > >> - RGB > > >> - YCBCR 444 > > >> - YCBCR 422 > > >> - YCBCR 420 > > >> > > >> Default value of the property is set to 0 =3D RGB, so no changes if = you > > >> don't set the property. > > >> > > >> The property "hdmi_output_depth" possible value could be > > >> - Automatic > > >> This indicates prefer highest color depth, it is > > >> 30bit on rockcip platform. > > >> - 24bit > > >> - 30bit > > >> The default value of property is 24bit. > > >> > > >> Signed-off-by: Algea Cao > > >> --- > > >> > > >> drivers/gpu/drm/rockchip/dw_hdmi-rockchip.c | 174 ++++++++++++++++= ++++ > > >> include/drm/bridge/dw_hdmi.h | 22 +++ > > >> 2 files changed, 196 insertions(+) > > >> > > >> diff --git a/drivers/gpu/drm/rockchip/dw_hdmi-rockchip.c b/drivers/g= pu/drm/rockchip/dw_hdmi-rockchip.c > > >> index 23de359a1dec..8f22d9a566db 100644 > > >> --- a/drivers/gpu/drm/rockchip/dw_hdmi-rockchip.c > > >> +++ b/drivers/gpu/drm/rockchip/dw_hdmi-rockchip.c > > >> @@ -52,6 +52,27 @@ > > >> =20 > > >> #define HIWORD_UPDATE(val, mask) (val | (mask) << 16) > > >> =20 > > >> +/* HDMI output pixel format */ > > >> +enum drm_hdmi_output_type { > > >> + DRM_HDMI_OUTPUT_DEFAULT_RGB, /* default RGB */ > > >> + DRM_HDMI_OUTPUT_YCBCR444, /* YCBCR 444 */ > > >> + DRM_HDMI_OUTPUT_YCBCR422, /* YCBCR 422 */ > > >> + DRM_HDMI_OUTPUT_YCBCR420, /* YCBCR 420 */ > > >> + DRM_HDMI_OUTPUT_YCBCR_HQ, /* Highest subsampled YUV */ > > >> + DRM_HDMI_OUTPUT_YCBCR_LQ, /* Lowest subsampled YUV */ > > >> + DRM_HDMI_OUTPUT_INVALID, /* Guess what ? */ > > >> +}; =20 > > > > > > Vendor-specific properties shouldn't use names starting with drm_ or > > > DRM_, that's for the DRM core. But this doesn't seem specific to > > > Rockchip at all, it should be a standard property. Additionally, new > > > properties need to come with a userspace implementation showing their > > > usage, in X.org, Weston, the Android DRM/KMS HW composer, or another > > > relevant upstream project (a test tool is usually not enough). =20 > >=20 > > We use these properties only in Android HW composer, But we can't upstr= eam > >=20 > > our HW composer code right now.=C2=A0 Can we use this properties as pri= vate=20 > > property > >=20 > > and do not upstream HW composer for the time being? =20 >=20 > It's not my decision, it's a policy of the DRM subsystem to require an > open implementation in userspace to validate all API additions. Also read https://www.kernel.org/doc/html/latest/gpu/drm-uapi.html#open-source-usersp= ace-requirements very carefully: it calls for a FOSS userspace project's proper upstream to have reviewed and accepted the patches to use the new UAPI, but those patches must NOT be MERGED at that time yet. Thanks, pq --Sig_/=OONQgpVWkCqhFkncTg66Ye Content-Type: application/pgp-signature Content-Description: OpenPGP digital signature -----BEGIN PGP SIGNATURE----- iQIzBAEBCAAdFiEEJQjwWQChkWOYOIONI1/ltBGqqqcFAl807uQACgkQI1/ltBGq qqd/Qg/5AYqVDsoWf/fmcGp7z7OgfKXZM7+iILaEYS5vRXwgTYMG5BWpKlR+fOAn Umgvjqhnc6GGFaB5S3vZALd7cCMYBoLdaNJ4oR566IjDpXbFl8bagZW3fD8Aaqix 9PzC80muZLPEEKy9zTqLSq2zfiZX41J7lMGTNMSQBpnGfB3YWxKqnKKlVMYtG8sL mpMq4KfdNLh443IMiu+s4ZkVAPQxj++Bu1BeJnz5Puy1iKY4Wup76tipgNXNHNiG eHj2hkHrzcXMjPF4JCrPra9OBHhiiv6IxP3fyF0dvfaou+mGzIOeJF5fV3Msna9J 4mYVcEE516sDuUZ8xmUOzwMMPPxqhOqZ/0DQSpU0NP3uevMVJQmcmitNFZMzDFtO 6jXTz7k554GJxrJo9XfSx/QKZPNtCIbQsxW6TKU2ShOCJFs55fO+seOCojaHnr5R Z0zUzapzyYbmiG1UHjjnyzOVIrQb2Bj2+6NxkQdAdXltKQym1GhdWHE3D/LzhS4R PZnFJxSU+MMrienr6daNiMfdfSl2vHgfd83qOCeQRXfYlJdzkKktsZfD2YUH0SY3 rq1pHw+5srdW0rKjct15/euFyiH3SUHF88rHYa4MzEC/3z+VASRUwWZ/ThWrRhjb fajX3c1qqlldIcxv+TknqkFrVuOUV8O9mxP18N4EL4uYCmTlDIc= =7IHY -----END PGP SIGNATURE----- --Sig_/=OONQgpVWkCqhFkncTg66Ye-- --===============6650171460878315367== Content-Type: text/plain; charset="us-ascii" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Content-Disposition: inline _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel --===============6650171460878315367==--