From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-10.0 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH, MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 4011DC433E1 for ; Thu, 13 Aug 2020 20:36:52 +0000 (UTC) Received: from merlin.infradead.org (merlin.infradead.org [205.233.59.134]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id EF21420716 for ; Thu, 13 Aug 2020 20:36:51 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="VHe6ZeIa"; dkim=fail reason="signature verification failed" (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="esVfOWzC" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org EF21420716 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=linaro.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=merlin.20170209; h=Sender:Content-Transfer-Encoding: Content-Type:Cc:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References:Message-ID: Subject:To:From:Date:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=fO2SoNHhTJDng2dteAbADvWqpEb9OmODeVmxIdHOL2I=; b=VHe6ZeIa1Tw+Zy8qjga/PoEgX 7eB4b9Wz7EZkr+jD0aDka0DdC8VdZoErBV8jeTvzaX/BtKrB1sPR6dM/cJC28cWR/LMtMbSm2h0U2 KewWeHW0ntTJDFgAHRUprGSyDnhxfw60W4oAmO3D1B8AjcpDfR9YrYaOGLEL6TFxcgy3EWd9vEaWf UKeAJ6bpAU2Gr0xBgmbS3LgPXe1d0IweXNbaOFCMVGKlDX72JRN9r0GA7k1S5aLfK+pgQUihukHio cU8IxeI1GgfK0Ns/pnEqXsdzRFsUM0dIfaSJosiDzDRiNUxSBEL4sNntEiT1jmMrH/JKTTcAxfQfV E8ATPMYVw==; Received: from localhost ([::1] helo=merlin.infradead.org) by merlin.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1k6JwX-00041M-1K; Thu, 13 Aug 2020 20:35:21 +0000 Received: from mail-pg1-x544.google.com ([2607:f8b0:4864:20::544]) by merlin.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1k6JwT-00040N-8x for linux-arm-kernel@lists.infradead.org; Thu, 13 Aug 2020 20:35:18 +0000 Received: by mail-pg1-x544.google.com with SMTP id 189so2764313pgg.13 for ; Thu, 13 Aug 2020 13:35:16 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to; bh=nZ5G6rmtk+TU64Mcr7Mg/V/r+XgvSBiaGtZJsjL2e68=; b=esVfOWzCaHk1px7Bb3AwxJyYZ/sqf1f8RjDFcNgCcWPKXMPFAXhn2Sved0B70mpDGZ 2tmzM6JI9Df0rUx88NKtjeSsGixaFEihN6KCTTSrnj+O3DQdA3gfJjvV+Xs0BLUhifpE HbPUcYlMUDEqjSWhjcl1YQ1T0uigLcAMviqvNYkg+bjuG3eSFSCxr4zC+z39/+EjbKKz fJuN1zsQ7w392FablUOl7/dJz3pibULcb74c/Z4piA0EuQqL6hqBMGnz6x8UJ9ZunZ5j qxFStTA9zO46tsQdSgPd8/w7cpp5MxARP7zwWDx9SZjQskYqa4HREXLOBfX0jPOqDm4k knAg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=nZ5G6rmtk+TU64Mcr7Mg/V/r+XgvSBiaGtZJsjL2e68=; b=M/2CW4Xf2vNTTn7fjheFK+NpeHRv8staEn74SfmB3D/8cgx/DQCzc7Knh6kzWMsuSg Bk67GJKFBQWfYiMmgp4NTvnK3i/a2BVe6TU8YBN4VHW/0T/mHlGsvv5UIOoz95pqEaFG mBO5KN586dbRvEz6GYJLM7BLG4YGE8c/t33EvkAaeD9xvB3mhRlbLvowpz8MjfZa6D2L gXiqtX42130sdb6Vwh5ub8Y3Rq4acIbAR4zMADEw1GQ2tMF/cVOgL6CoQ0JWTsub0sLk 6xgFGDTkCroSl5u4g4ryxBeoY0HZjRW6EL5CcFme4xDwfKHqdIA75tBrbNCKVv1jGVac BNzQ== X-Gm-Message-State: AOAM530zQa1kOWa0Z/ImfjVp8VzVFNdScZnSIzU4cuDWSp83Zbb5qXQq S2C1LWw09Ks5I9m8OXEC5iuJBQ== X-Google-Smtp-Source: ABdhPJyeFdAimeQhWejMo5SE4Ho2jUnKZ9FtUTSpQfRuwyLAD6i2UQ7SOKiF16htMitjOjpkpX/+qQ== X-Received: by 2002:a62:79d7:: with SMTP id u206mr5818223pfc.97.1597350914560; Thu, 13 Aug 2020 13:35:14 -0700 (PDT) Received: from xps15 (S0106002369de4dac.cg.shawcable.net. [68.147.8.254]) by smtp.gmail.com with ESMTPSA id y79sm6678851pfb.65.2020.08.13.13.35.13 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 13 Aug 2020 13:35:14 -0700 (PDT) Date: Thu, 13 Aug 2020 14:35:11 -0600 From: Mathieu Poirier To: Tingwei Zhang Subject: Re: [PATCH v8 15/24] coresight: allow replicator driver to be built as module Message-ID: <20200813203511.GL3393195@xps15> References: <20200807111153.7784-1-tingwei@codeaurora.org> <20200807111153.7784-16-tingwei@codeaurora.org> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20200807111153.7784-16-tingwei@codeaurora.org> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20200813_163517_465440_86493201 X-CRM114-Status: GOOD ( 32.51 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: tsoni@codeaurora.org, Sai Prakash Ranjan , Kim Phillips , Mao Jinlong , Suzuki K Poulose , Alexander Shishkin , Greg Kroah-Hartman , coresight@lists.linaro.org, Randy Dunlap , Mian Yousaf Kaukab , Russell King , Leo Yan , linux-arm-kernel@lists.infradead.org, Mike Leach Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Fri, Aug 07, 2020 at 07:11:44PM +0800, Tingwei Zhang wrote: > From: Kim Phillips > > Allow to build coresight-replicator as modules, for ease of development. > > - Kconfig becomes a tristate, to allow =m > - combine static and dynamic replicator init into single > module_init/exit call > - add replicator_remove functions, for module unload > - add a MODULE_DEVICE_TABLE for autoloading on boot > > Cc: Mathieu Poirier > Cc: Leo Yan > Cc: Alexander Shishkin > Cc: Randy Dunlap > Cc: Suzuki K Poulose > Cc: Greg Kroah-Hartman > Cc: Russell King > Co-developed-by: Mian Yousaf Kaukab > Signed-off-by: Mian Yousaf Kaukab > Signed-off-by: Kim Phillips > Signed-off-by: Tingwei Zhang > Tested-by: Mike Leach > --- > drivers/hwtracing/coresight/Kconfig | 5 +- > .../coresight/coresight-replicator.c | 63 ++++++++++++++++++- > 2 files changed, 65 insertions(+), 3 deletions(-) > > diff --git a/drivers/hwtracing/coresight/Kconfig b/drivers/hwtracing/coresight/Kconfig > index fc48ae086746..f31778dd0b5d 100644 > --- a/drivers/hwtracing/coresight/Kconfig > +++ b/drivers/hwtracing/coresight/Kconfig > @@ -17,13 +17,16 @@ menuconfig CORESIGHT > > if CORESIGHT > config CORESIGHT_LINKS_AND_SINKS > - bool "CoreSight Link and Sink drivers" > + tristate "CoreSight Link and Sink drivers" > help > This enables support for CoreSight link and sink drivers that are > responsible for transporting and collecting the trace data > respectively. Link and sinks are dynamically aggregated with a trace > entity at run time to form a complete trace path. With the passage of time and the refinement of the supported components, the CONFIG_ and description are no longer valid. I'll leave it up to you to decide if you want to fix it as part of this set, the choice is entirely up to you. > > + To compile these drivers as modules, choose M here: the > + modules will be called coresight-funnel and coresight-replicator. > + > config CORESIGHT_LINK_AND_SINK_TMC > tristate "Coresight generic TMC driver" > > diff --git a/drivers/hwtracing/coresight/coresight-replicator.c b/drivers/hwtracing/coresight/coresight-replicator.c > index 78acf29c49ca..05db434c79d0 100644 > --- a/drivers/hwtracing/coresight/coresight-replicator.c > +++ b/drivers/hwtracing/coresight/coresight-replicator.c > @@ -291,6 +291,14 @@ static int replicator_probe(struct device *dev, struct resource *res) > return ret; > } > > +static int __exit replicator_remove(struct device *dev) > +{ > + struct replicator_drvdata *drvdata = dev_get_drvdata(dev); > + > + coresight_unregister(drvdata->csdev); > + return 0; > +} > + > static int static_replicator_probe(struct platform_device *pdev) > { > int ret; > @@ -310,6 +318,13 @@ static int static_replicator_probe(struct platform_device *pdev) > return ret; > } > > +static int __exit static_replicator_remove(struct platform_device *pdev) > +{ > + replicator_remove(&pdev->dev); > + pm_runtime_disable(&pdev->dev); > + return 0; > +} > + > #ifdef CONFIG_PM > static int replicator_runtime_suspend(struct device *dev) > { > @@ -342,25 +357,28 @@ static const struct of_device_id static_replicator_match[] = { > {.compatible = "arm,coresight-static-replicator"}, > {} > }; > +MODULE_DEVICE_TABLE(of, static_replicator_match); Pick a way to do this, a newline or not, but stick with it for _all_ the drivers in this set. > > #ifdef CONFIG_ACPI > static const struct acpi_device_id static_replicator_acpi_ids[] = { > {"ARMHC985", 0}, /* ARM CoreSight Static Replicator */ > {} > }; > +MODULE_DEVICE_TABLE(acpi, static_replicator_acpi_ids); Same as above > #endif > > static struct platform_driver static_replicator_driver = { > .probe = static_replicator_probe, > + .remove = static_replicator_remove, > .driver = { > .name = "coresight-static-replicator", > + .owner = THIS_MODULE, > .of_match_table = of_match_ptr(static_replicator_match), > .acpi_match_table = ACPI_PTR(static_replicator_acpi_ids), > .pm = &replicator_dev_pm_ops, > .suppress_bind_attrs = true, > }, > }; > -builtin_platform_driver(static_replicator_driver); > > static int dynamic_replicator_probe(struct amba_device *adev, > const struct amba_id *id) > @@ -368,19 +386,60 @@ static int dynamic_replicator_probe(struct amba_device *adev, > return replicator_probe(&adev->dev, &adev->res); > } > > +static int __exit dynamic_replicator_remove(struct amba_device *adev) > +{ > + return replicator_remove(&adev->dev); > +} > + > static const struct amba_id dynamic_replicator_ids[] = { > CS_AMBA_ID(0x000bb909), > CS_AMBA_ID(0x000bb9ec), /* Coresight SoC-600 */ > {}, > }; > > +MODULE_DEVICE_TABLE(amba, dynamic_replicator_ids); > + > static struct amba_driver dynamic_replicator_driver = { > .drv = { > .name = "coresight-dynamic-replicator", > .pm = &replicator_dev_pm_ops, > + .owner = THIS_MODULE, > .suppress_bind_attrs = true, > }, > .probe = dynamic_replicator_probe, > + .remove = dynamic_replicator_remove, > .id_table = dynamic_replicator_ids, > }; > -builtin_amba_driver(dynamic_replicator_driver); > + > +static int __init replicator_init(void) > +{ > + int ret; > + > + ret = platform_driver_register(&static_replicator_driver); > + if (ret) { > + pr_info("Error registering platform driver\n"); > + return ret; > + } > + > + ret = amba_driver_register(&dynamic_replicator_driver); > + if (ret) { > + pr_info("Error registering amba driver\n"); > + platform_driver_unregister(&static_replicator_driver); > + } > + > + return ret; > +} > + > +static void __exit replicator_exit(void) > +{ > + platform_driver_unregister(&static_replicator_driver); > + amba_driver_unregister(&dynamic_replicator_driver); > +} > + Same here, choose to add a newline or not but stay consistent for all the drives. > +module_init(replicator_init); > +module_exit(replicator_exit); > + > +MODULE_AUTHOR("Pratik Patel "); Pratik should also be mentioned in the funnel driver. > +MODULE_AUTHOR("Mathieu Poirier "); > +MODULE_DESCRIPTION("Arm CoreSight Replicator Driver"); > +MODULE_LICENSE("GPL v2"); > -- > The Qualcomm Innovation Center, Inc. is a member of the Code Aurora Forum, > a Linux Foundation Collaborative Project > _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel