From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-11.5 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH, MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED, USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 41008C433E1 for ; Fri, 14 Aug 2020 00:09:54 +0000 (UTC) Received: from merlin.infradead.org (merlin.infradead.org [205.233.59.134]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 0396D2078B for ; Fri, 14 Aug 2020 00:09:53 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="j8IaTZPW"; dkim=fail reason="signature verification failed" (1024-bit key) header.d=mg.codeaurora.org header.i=@mg.codeaurora.org header.b="lzZ3hN/M" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 0396D2078B Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=codeaurora.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=merlin.20170209; h=Sender:Content-Transfer-Encoding: Content-Type:Cc:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References:Message-ID: Subject:To:From:Date:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=WKNjIsgo34qgmUvJv8i/H6otZoH2vyHoAcVT9wByObw=; b=j8IaTZPWRrteH/v1mha6gk0ZH 7lAd0NPC2ztdQDR3YQ7d7029xfMUxSICiFV/DmuN9kkwU11IShZTWr7WIakx8klFhiixt9v8DyAma ryUF8svQIK/Iq/E4QMapUG0um+X8QYnwtZw1WJy6M/Fuu/2+0HzpetzgSmdd33ri2PxbJCVyHyF/5 B7zxSSJ+MSRLJBswZeF5lLGyJuuczaU50gJBQnnG1WV1/9yg0G7cbo3KQanbo9kAGVZUbHBC0W0Mb M1DbX13kXSbvxbfmBeQejuTApvXp1YewRDfMUhaV7pmzLIDFPIjUNPBpLEFgj0izXklBKEagdeNTg JNnjs5EPg==; Received: from localhost ([::1] helo=merlin.infradead.org) by merlin.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1k6NGi-0006JP-V2; Fri, 14 Aug 2020 00:08:24 +0000 Received: from mail29.static.mailgun.info ([104.130.122.29]) by merlin.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1k6NGf-0006IP-Sn for linux-arm-kernel@lists.infradead.org; Fri, 14 Aug 2020 00:08:22 +0000 DKIM-Signature: a=rsa-sha256; v=1; c=relaxed/relaxed; d=mg.codeaurora.org; q=dns/txt; s=smtp; t=1597363701; h=In-Reply-To: Content-Type: MIME-Version: References: Message-ID: Subject: Cc: To: From: Date: Sender; bh=rfWtDsiY26lvnYHJS8VPvhZ75w2xciWBAxefs9LLSq4=; b=lzZ3hN/MLfbx8HBT8kTXfy2G2pLn9/YbDbMvwcJtB7Kqaq3TLRUuhEVLxxNjB+OE0f+9VkzI qe24TyRSyAy/VjEWrZsSazfXQy/K8v0b00vl9X7J3PaY+yrFLFI8pO2NiY0pdx5cZM05wq+q lRyxLA/iys3X1STWRpiZFuRzqqU= X-Mailgun-Sending-Ip: 104.130.122.29 X-Mailgun-Sid: WyJiYzAxZiIsICJsaW51eC1hcm0ta2VybmVsQGxpc3RzLmluZnJhZGVhZC5vcmciLCAiYmU5ZTRhIl0= Received: from smtp.codeaurora.org (ec2-35-166-182-171.us-west-2.compute.amazonaws.com [35.166.182.171]) by smtp-out-n01.prod.us-west-2.postgun.com with SMTP id 5f35d5f546ed996674986136 (version=TLS1.2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256); Fri, 14 Aug 2020 00:08:21 GMT Received: by smtp.codeaurora.org (Postfix, from userid 1001) id 622B2C4344A; Fri, 14 Aug 2020 00:08:20 +0000 (UTC) Received: from codeaurora.org (unknown [180.166.53.21]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) (Authenticated sender: tingwei) by smtp.codeaurora.org (Postfix) with ESMTPSA id E0987C433B2; Fri, 14 Aug 2020 00:08:12 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 smtp.codeaurora.org E0987C433B2 Authentication-Results: aws-us-west-2-caf-mail-1.web.codeaurora.org; dmarc=none (p=none dis=none) header.from=codeaurora.org Authentication-Results: aws-us-west-2-caf-mail-1.web.codeaurora.org; spf=none smtp.mailfrom=tingweiz@codeaurora.org Date: Fri, 14 Aug 2020 08:08:06 +0800 From: Tingwei Zhang To: Mathieu Poirier Subject: Re: [PATCH v8 15/24] coresight: allow replicator driver to be built as module Message-ID: <20200814000806.GC23288@codeaurora.org> References: <20200807111153.7784-1-tingwei@codeaurora.org> <20200807111153.7784-16-tingwei@codeaurora.org> <20200813203511.GL3393195@xps15> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20200813203511.GL3393195@xps15> User-Agent: Mutt/1.5.24 (2015-08-30) X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20200813_200821_996531_A77A00BF X-CRM114-Status: GOOD ( 39.18 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: tsoni@codeaurora.org, Sai Prakash Ranjan , Kim Phillips , Mao Jinlong , Suzuki K Poulose , Alexander Shishkin , Greg Kroah-Hartman , coresight@lists.linaro.org, Randy Dunlap , Mian Yousaf Kaukab , Russell King , Tingwei Zhang , Leo Yan , linux-arm-kernel@lists.infradead.org, Mike Leach Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Fri, Aug 14, 2020 at 04:35:11AM +0800, Mathieu Poirier wrote: > On Fri, Aug 07, 2020 at 07:11:44PM +0800, Tingwei Zhang wrote: > > From: Kim Phillips > > > > Allow to build coresight-replicator as modules, for ease of development. > > > > - Kconfig becomes a tristate, to allow =m > > - combine static and dynamic replicator init into single > > module_init/exit call > > - add replicator_remove functions, for module unload > > - add a MODULE_DEVICE_TABLE for autoloading on boot > > > > Cc: Mathieu Poirier > > Cc: Leo Yan > > Cc: Alexander Shishkin > > Cc: Randy Dunlap > > Cc: Suzuki K Poulose > > Cc: Greg Kroah-Hartman > > Cc: Russell King > > Co-developed-by: Mian Yousaf Kaukab > > Signed-off-by: Mian Yousaf Kaukab > > Signed-off-by: Kim Phillips > > Signed-off-by: Tingwei Zhang > > Tested-by: Mike Leach > > --- > > drivers/hwtracing/coresight/Kconfig | 5 +- > > .../coresight/coresight-replicator.c | 63 ++++++++++++++++++- > > 2 files changed, 65 insertions(+), 3 deletions(-) > > > > diff --git a/drivers/hwtracing/coresight/Kconfig > b/drivers/hwtracing/coresight/Kconfig > > index fc48ae086746..f31778dd0b5d 100644 > > --- a/drivers/hwtracing/coresight/Kconfig > > +++ b/drivers/hwtracing/coresight/Kconfig > > @@ -17,13 +17,16 @@ menuconfig CORESIGHT > > > > if CORESIGHT > > config CORESIGHT_LINKS_AND_SINKS > > - bool "CoreSight Link and Sink drivers" > > + tristate "CoreSight Link and Sink drivers" > > help > > This enables support for CoreSight link and sink drivers that > are > > responsible for transporting and collecting the trace data > > respectively. Link and sinks are dynamically aggregated with a > trace > > entity at run time to form a complete trace path. > > With the passage of time and the refinement of the supported components, > the > CONFIG_ and description are no longer valid. I'll leave it up to you to > decide > if you want to fix it as part of this set, the choice is entirely up to > you. > I'll leave that to another patch and focus this patch set to make driver as module. > > > > + To compile these drivers as modules, choose M here: the > > + modules will be called coresight-funnel and > coresight-replicator. > > + > > config CORESIGHT_LINK_AND_SINK_TMC > > tristate "Coresight generic TMC driver" > > > > diff --git a/drivers/hwtracing/coresight/coresight-replicator.c > b/drivers/hwtracing/coresight/coresight-replicator.c > > index 78acf29c49ca..05db434c79d0 100644 > > --- a/drivers/hwtracing/coresight/coresight-replicator.c > > +++ b/drivers/hwtracing/coresight/coresight-replicator.c > > @@ -291,6 +291,14 @@ static int replicator_probe(struct device *dev, > struct resource *res) > > return ret; > > } > > > > +static int __exit replicator_remove(struct device *dev) > > +{ > > + struct replicator_drvdata *drvdata = dev_get_drvdata(dev); > > + > > + coresight_unregister(drvdata->csdev); > > + return 0; > > +} > > + > > static int static_replicator_probe(struct platform_device *pdev) > > { > > int ret; > > @@ -310,6 +318,13 @@ static int static_replicator_probe(struct > platform_device *pdev) > > return ret; > > } > > > > +static int __exit static_replicator_remove(struct platform_device > *pdev) > > +{ > > + replicator_remove(&pdev->dev); > > + pm_runtime_disable(&pdev->dev); > > + return 0; > > +} > > + > > #ifdef CONFIG_PM > > static int replicator_runtime_suspend(struct device *dev) > > { > > @@ -342,25 +357,28 @@ static const struct of_device_id > static_replicator_match[] = { > > {.compatible = "arm,coresight-static-replicator"}, > > {} > > }; > > +MODULE_DEVICE_TABLE(of, static_replicator_match); > > Pick a way to do this, a newline or not, but stick with it for _all_ the > drivers > in this set. > I will add a new line and check all the coresight drivers. > > > > #ifdef CONFIG_ACPI > > static const struct acpi_device_id static_replicator_acpi_ids[] = { > > {"ARMHC985", 0}, /* ARM CoreSight Static Replicator */ > > {} > > }; > > +MODULE_DEVICE_TABLE(acpi, static_replicator_acpi_ids); > > Same as above > I will add a new line. > > #endif > > > > static struct platform_driver static_replicator_driver = { > > .probe = static_replicator_probe, > > + .remove = static_replicator_remove, > > .driver = { > > .name = "coresight-static-replicator", > > + .owner = THIS_MODULE, > > .of_match_table = of_match_ptr(static_replicator_match), > > .acpi_match_table = ACPI_PTR(static_replicator_acpi_ids), > > .pm = &replicator_dev_pm_ops, > > .suppress_bind_attrs = true, > > }, > > }; > > -builtin_platform_driver(static_replicator_driver); > > > > static int dynamic_replicator_probe(struct amba_device *adev, > > const struct amba_id *id) > > @@ -368,19 +386,60 @@ static int dynamic_replicator_probe(struct > amba_device *adev, > > return replicator_probe(&adev->dev, &adev->res); > > } > > > > +static int __exit dynamic_replicator_remove(struct amba_device *adev) > > +{ > > + return replicator_remove(&adev->dev); > > +} > > + > > static const struct amba_id dynamic_replicator_ids[] = { > > CS_AMBA_ID(0x000bb909), > > CS_AMBA_ID(0x000bb9ec), /* Coresight SoC-600 */ > > {}, > > }; > > > > +MODULE_DEVICE_TABLE(amba, dynamic_replicator_ids); > > + > > static struct amba_driver dynamic_replicator_driver = { > > .drv = { > > .name = "coresight-dynamic-replicator", > > .pm = &replicator_dev_pm_ops, > > + .owner = THIS_MODULE, > > .suppress_bind_attrs = true, > > }, > > .probe = dynamic_replicator_probe, > > + .remove = dynamic_replicator_remove, > > .id_table = dynamic_replicator_ids, > > }; > > -builtin_amba_driver(dynamic_replicator_driver); > > + > > +static int __init replicator_init(void) > > +{ > > + int ret; > > + > > + ret = platform_driver_register(&static_replicator_driver); > > + if (ret) { > > + pr_info("Error registering platform driver\n"); > > + return ret; > > + } > > + > > + ret = amba_driver_register(&dynamic_replicator_driver); > > + if (ret) { > > + pr_info("Error registering amba driver\n"); > > + platform_driver_unregister(&static_replicator_driver); > > + } > > + > > + return ret; > > +} > > + > > +static void __exit replicator_exit(void) > > +{ > > + platform_driver_unregister(&static_replicator_driver); > > + amba_driver_unregister(&dynamic_replicator_driver); > > +} > > + > > Same here, choose to add a newline or not but stay consistent for all the > drives. > Sure. > > +module_init(replicator_init); > > +module_exit(replicator_exit); > > + > > +MODULE_AUTHOR("Pratik Patel "); > > Pratik should also be mentioned in the funnel driver. > I'll add Pratik in v9. > > +MODULE_AUTHOR("Mathieu Poirier "); > > +MODULE_DESCRIPTION("Arm CoreSight Replicator Driver"); > > +MODULE_LICENSE("GPL v2"); > > -- > > The Qualcomm Innovation Center, Inc. is a member of the Code Aurora > Forum, > > a Linux Foundation Collaborative Project > > _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel