From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-4.0 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 44BEFC433DF for ; Fri, 14 Aug 2020 17:25:13 +0000 (UTC) Received: from merlin.infradead.org (merlin.infradead.org [205.233.59.134]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 0839C20708 for ; Fri, 14 Aug 2020 17:25:13 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="xCeWX2Th" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 0839C20708 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=sigxcpu.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=merlin.20170209; h=Sender:Content-Transfer-Encoding: Content-Type:Cc:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References:Message-ID: Subject:To:From:Date:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=2DC/ZSErrVTaT1qzJC6fVQODB1KarZGfsDnmtK12CYs=; b=xCeWX2Th7gJcTWTgGhzid1b/E gHWnyD7HYsA046pIIn9UMZkWkOjLzypVlp93HXyfHeXZyQPOTKpNfSb2j1luLRNKZ1mv2IwkxNPzy UyrsgUfQ00Nmcvey7ikNHrQfEFdslqmW4KO76/adl5neNF6PxrkRp30gNEs0XYCJn50RAfnUxqC64 hrj3Jkt7dcWEZ6Gy3ydU7Yc11kjFBc9HU0ckQ/YYFgwUJot5OPZ46+paawxU/skpqeWxMKDK6ftY2 hSZ9GaW+pdJxwmF2WkVAx48D6yk3v4YxNGzvE14wyxtrKFxDueSIBifdHc163+fnFukqn1shF95WG 7qPAgtwVA==; Received: from localhost ([::1] helo=merlin.infradead.org) by merlin.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1k6dQO-0002hL-Nj; Fri, 14 Aug 2020 17:23:28 +0000 Received: from honk.sigxcpu.org ([24.134.29.49]) by merlin.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1k6dQL-0002g9-Vm for linux-arm-kernel@lists.infradead.org; Fri, 14 Aug 2020 17:23:27 +0000 Received: from localhost (localhost [127.0.0.1]) by honk.sigxcpu.org (Postfix) with ESMTP id 0B015FB03; Fri, 14 Aug 2020 19:23:22 +0200 (CEST) X-Virus-Scanned: Debian amavisd-new at honk.sigxcpu.org Received: from honk.sigxcpu.org ([127.0.0.1]) by localhost (honk.sigxcpu.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id Cirbr_6XKokd; Fri, 14 Aug 2020 19:23:20 +0200 (CEST) Received: by bogon.sigxcpu.org (Postfix, from userid 1000) id 3D040457CC; Fri, 14 Aug 2020 19:23:20 +0200 (CEST) Date: Fri, 14 Aug 2020 19:23:20 +0200 From: Guido =?iso-8859-1?Q?G=FCnther?= To: Pavel Machek Subject: Re: Camera LED on Librem 5 was Re: [PATCH] backlight: add led-backlight driver Message-ID: <20200814172320.GA740513@bogon.m.sigxcpu.org> References: <20200219191412.GA15905@amd> <20200220082956.GA3383@bogon.m.sigxcpu.org> <20200220234151.GB1544@amd> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20200220234151.GB1544@amd> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20200814_132326_173522_809154DB X-CRM114-Status: GOOD ( 17.31 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: kernel list , linux-arm-kernel Content-Type: text/plain; charset="iso-8859-1" Content-Transfer-Encoding: quoted-printable Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org Hi Pavel, On Fri, Feb 21, 2020 at 12:41:51AM +0100, Pavel Machek wrote: > Hi! > = > > > This patch adds a led-backlight driver (led_bl), which is similar to > > > pwm_bl except the driver uses a LED class driver to adjust the > > > brightness in the HW. Multiple LEDs can be used for a single backligh= t. > > = > > Tested-by: Guido G=FCnther > = > Thanks for testing! > = > I noticed blog post about using Librem 5 torch. Unfortunately, it used > very strange/non-standard interface, first using LED as a GPIO to > enable LED controller, then direct i2c access. That is not acceptable > interface for mainline, and it would be better not to advertise such > code, as it will likely become broken in future. I agree, there's a driver for the lm3560 in media/ but how would one expose the torch part as a LED? It seems you hit something similar in https://lkml.org/lkml/2018/5/6/30 I also couldn't find an in tree driver that registers a flashlight as a v4l subdev. Did i miss that? Cheers, -- Guido _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel