From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-3.8 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 6ABFCC433E3 for ; Sun, 16 Aug 2020 11:23:48 +0000 (UTC) Received: from merlin.infradead.org (merlin.infradead.org [205.233.59.134]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 3B9AE20716 for ; Sun, 16 Aug 2020 11:23:48 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="ca3YSUdu"; dkim=fail reason="signature verification failed" (1024-bit key) header.d=alien8.de header.i=@alien8.de header.b="Krl/v7U3" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 3B9AE20716 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=alien8.de Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=merlin.20170209; h=Sender:Content-Transfer-Encoding: Content-Type:Cc:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References:Message-ID: Subject:To:From:Date:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=Xz/UmOAp2vZgQO9MaUEdoAKQ9mXpFV+uahTXTwiGzVw=; b=ca3YSUduzO9l2ttEdLXRE8hQh doZrKTTOgFYlo825wfeRY+3RnPkcyM6MlrFaFhunBUQZBF4ceV1dyzgpIRg3YPp8BmXgsFzBPgX8H u9y0iAMf0I1uJ/MLnSDBjCHGEqo7vP9UW5gac8azVnBHa2BGrhVqCcrBgMkEasdP4IQG5Gz/v8FYQ EiHmfAT4IfvBVlxex7juFMtIVB4uWlVothK0TQCVmBNw5jbtL9mGscz1QbbwlXI0psy1UqW+IlufX zXMw1lzIMrJ2HEfGVebcdqgLZRlTrCPWdT5H4tKz+lENXhDH63DQPGEuqmBb7blg6oOm5ze2RLQyS cN+l5umiw==; Received: from localhost ([::1] helo=merlin.infradead.org) by merlin.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1k7Gjg-00056I-0Y; Sun, 16 Aug 2020 11:22:00 +0000 Received: from mail.skyhub.de ([2a01:4f8:190:11c2::b:1457]) by merlin.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1k7GjZ-00055c-JN for linux-arm-kernel@lists.infradead.org; Sun, 16 Aug 2020 11:21:54 +0000 Received: from zn.tnic (p200300ec2f26be005d37f199a58e243d.dip0.t-ipconnect.de [IPv6:2003:ec:2f26:be00:5d37:f199:a58e:243d]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.skyhub.de (SuperMail on ZX Spectrum 128k) with ESMTPSA id 3CC941EC027B; Sun, 16 Aug 2020 13:21:50 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=alien8.de; s=dkim; t=1597576910; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:in-reply-to:in-reply-to: references:references; bh=cMXvEXkyTsrY8sFsp1lnP4ixT5jJSQ6YbHxQfH0FNg4=; b=Krl/v7U3lVDL8glqCYGHcilbKhYp7xlwSoeGOYfIWisRhmgp569YSVCqhzsCaIfn8zjoc0 mC+uzv36mSVuWb++7yBXMOS+hyDvHpjaWPjVrT4ymB62HU4Xv+pfqAn+Eb9BtkifX2ovaW 60JxbV021VbIljRwwcb0rQgiuI1C5Ug= Date: Sun, 16 Aug 2020 13:22:44 +0200 From: Borislav Petkov To: "Shenhar, Talel" Subject: Re: [PATCH v9 2/2] EDAC: al-mc-edac: Introduce Amazon's Annapurna Labs Memory Controller EDAC Message-ID: <20200816112244.GG21914@zn.tnic> References: <20200728095155.18506-1-talel@amazon.com> <20200728095155.18506-3-talel@amazon.com> <20200815183358.GE25814@zn.tnic> <5d516c64-ecd8-6f36-5f95-6708fe0f3fd5@amazon.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <5d516c64-ecd8-6f36-5f95-6708fe0f3fd5@amazon.com> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20200816_072153_841968_57FDCF5B X-CRM114-Status: GOOD ( 10.85 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: mark.rutland@arm.com, devicetree@vger.kernel.org, hhhawa@amazon.com, gregkh@linuxfoundation.org, eitan@amazon.com, jonnyc@amazon.com, hanochu@amazon.com, linux-kernel@vger.kernel.org, robh+dt@kernel.org, james.morse@arm.com, catalin.marinas@arm.com, ronenk@amazon.com, mchehab@kernel.org, will@kernel.org, davem@davemloft.net, linux-arm-kernel@lists.infradead.org, linux-edac@vger.kernel.org Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Sun, Aug 16, 2020 at 12:17:31PM +0300, Shenhar, Talel wrote: > Let me know what you think. Well, devm_al_mc_edac_free() devm_al_mc_edac_del() look like useless wrappers to me and can be removed and you can use edac_mc_del_mc() and edac_mc_free() directly. But then you need to cast them in an ugly way so that it builds: ret = devm_add_action(&pdev->dev, (void (*)(void *data))edac_mc_free, mci); I guess we can leave them as is and then lift them into the EDAC core if someone else wants to do the same devm_* thing. al_mc_edac_get_scrub_mode() doesn't need a prefix because it is used only once and the compiler is simply inlining it so you can forget the stack trace visibility: $ readelf -s drivers/edac/al_mc_edac.ko | grep scrub $ The others are fine, I guess, since they're function pointers and cannot be inlined as such so you want them prefixed: $ readelf -s drivers/edac/al_mc_edac.ko | grep al_mc_edac 23: 00000000 0 FILE LOCAL DEFAULT ABS al_mc_edac.c 25: 00000000 4 FUNC LOCAL DEFAULT 1 devm_al_mc_edac_free 27: 00000004 4 FUNC LOCAL DEFAULT 1 devm_al_mc_edac_del 31: 00000124 24 FUNC LOCAL DEFAULT 1 al_mc_edac_irq_handler_ce 35: 00000260 24 FUNC LOCAL DEFAULT 1 al_mc_edac_irq_handler_ue 36: 00000278 56 FUNC LOCAL DEFAULT 1 al_mc_edac_check 37: 000002b0 680 FUNC LOCAL DEFAULT 1 al_mc_edac_probe 47: 00000000 20 FUNC LOCAL DEFAULT 3 al_mc_edac_driver_init 51: 00000000 12 FUNC LOCAL DEFAULT 5 al_mc_edac_driver_exit 53: 00000000 392 OBJECT LOCAL DEFAULT 16 al_mc_edac_of_match 59: 00000000 104 OBJECT LOCAL DEFAULT 20 al_mc_edac_driver 61: 00000000 0 FILE LOCAL DEFAULT ABS al_mc_edac.mod.c 88: 00000000 392 OBJECT GLOBAL DEFAULT 16 __mod_of__al_mc_edac_of_m Thx. -- Regards/Gruss, Boris. https://people.kernel.org/tglx/notes-about-netiquette _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel