From: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
To: "Guido Günther" <agx@sigxcpu.org>
Cc: Marek Vasut <marex@denx.de>,
devicetree@vger.kernel.org, Stefan Agner <stefan@agner.ch>,
Rob Herring <robh+dt@kernel.org>,
dri-devel@lists.freedesktop.org,
Pengutronix Kernel Team <kernel@pengutronix.de>,
linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH 3/8] dt-bindings: display: mxsfb: Add a bus-width endpoint property
Date: Mon, 17 Aug 2020 03:09:08 +0300 [thread overview]
Message-ID: <20200817000908.GD7729@pendragon.ideasonboard.com> (raw)
In-Reply-To: <20200815212838.GC134339@bogon.m.sigxcpu.org>
Hi Guido,
On Sat, Aug 15, 2020 at 11:28:38PM +0200, Guido Günther wrote:
> On Thu, Aug 13, 2020 at 04:29:05AM +0300, Laurent Pinchart wrote:
> > When the PCB routes the display data signals in an unconventional way,
> > the output bus width may differ from the bus width of the connected
> > panel or encoder. For instance, when a 18-bit RGB panel has its R[5:0],
> > G[5:0] and B[5:0] signals connected to LCD_DATA[7:2], LCD_DATA[15:10]
> > and LCD_DATA[23:18], the output bus width is 24 instead of 18 when the
> > signals are routed to LCD_DATA[5:0], LCD_DATA[11:6] and LCD_DATA[17:12].
> >
> > Add a bus-width property to describe this data routing.
> >
> > Signed-off-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
> > ---
> > Documentation/devicetree/bindings/display/mxsfb.yaml | 12 ++++++++++++
> > 1 file changed, 12 insertions(+)
> >
> > diff --git a/Documentation/devicetree/bindings/display/mxsfb.yaml b/Documentation/devicetree/bindings/display/mxsfb.yaml
> > index ec6533b1d4a3..d15bb8edc29f 100644
> > --- a/Documentation/devicetree/bindings/display/mxsfb.yaml
> > +++ b/Documentation/devicetree/bindings/display/mxsfb.yaml
> > @@ -58,6 +58,18 @@ properties:
> > type: object
> >
> > properties:
> > + data-shift:
>
> Shouldn't that be bus-width ?
Absolutely. I'll fix that.
> > + enum: [16, 18, 24]
> > + description: |
> > + The output bus width. This value overrides the configuration
> > + derived from the connected device (encoder or panel). It should
> > + only be specified when PCB routing of the data signals require a
> > + different bus width on the LCDIF and the connected device. For
> > + instance, when a 18-bit RGB panel has its R[5:0], G[5:0] and
> > + B[5:0] signals connected to LCD_DATA[7:2], LCD_DATA[15:10] and
> > + LCD_DATA[23:18] instead of LCD_DATA[5:0], LCD_DATA[11:6] and
> > + LCD_DATA[17:12], bus-width should be set to 24.
> > +
> > remote-endpoint:
> > $ref: /schemas/types.yaml#/definitions/phandle
> >
--
Regards,
Laurent Pinchart
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
next prev parent reply other threads:[~2020-08-17 0:10 UTC|newest]
Thread overview: 31+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-08-13 1:29 [PATCH 0/8] drm: mxsfb: Allow overriding bus width Laurent Pinchart
2020-08-13 1:29 ` [PATCH 1/8] dt-bindings: display: mxsfb: Convert binding to YAML Laurent Pinchart
2020-08-16 6:22 ` Sam Ravnborg
2020-08-17 0:00 ` Laurent Pinchart
2020-08-24 23:59 ` Rob Herring
2020-08-13 1:29 ` [PATCH 2/8] dt-bindings: display: mxsfb: Add and fix compatible strings Laurent Pinchart
2020-08-16 6:39 ` Sam Ravnborg
2020-08-17 0:04 ` Laurent Pinchart
2020-08-24 23:57 ` Rob Herring
2020-08-21 14:53 ` Stefan Agner
2020-08-23 23:26 ` Laurent Pinchart
2020-08-24 14:19 ` Stefan Agner
2020-10-07 1:12 ` Laurent Pinchart
2020-08-13 1:29 ` [PATCH 3/8] dt-bindings: display: mxsfb: Add a bus-width endpoint property Laurent Pinchart
2020-08-15 21:28 ` Guido Günther
2020-08-17 0:09 ` Laurent Pinchart [this message]
2020-08-16 7:25 ` Sam Ravnborg
2020-08-17 0:17 ` Laurent Pinchart
2020-08-13 1:29 ` [PATCH 4/8] dt-bindings: display: mxsfb: Rename to fsl,lcdif.yaml Laurent Pinchart
2020-08-16 7:27 ` [PATCH 4/8] dt-bindings: display: mxsfb: Rename to fsl, lcdif.yaml Sam Ravnborg
2020-08-21 14:55 ` Stefan Agner
2020-08-23 23:27 ` Laurent Pinchart
2020-08-13 1:29 ` [PATCH 5/8] ARM: dts: imx: Fix LCDIF compatible strings Laurent Pinchart
2020-08-16 7:28 ` Sam Ravnborg
2020-08-13 1:29 ` [PATCH 6/8] arm64: dts: imx8mq: " Laurent Pinchart
2020-08-16 7:28 ` Sam Ravnborg
2020-08-13 1:29 ` [PATCH 7/8] ARM: dts: imx: Remove unneeded LCDIF disp_axi clock Laurent Pinchart
2020-08-16 7:28 ` Sam Ravnborg
2020-08-13 1:29 ` [PATCH 8/8] drm: mxsfb: Add support for the bus-width DT property Laurent Pinchart
2020-08-16 7:46 ` Sam Ravnborg
2020-08-17 0:29 ` Laurent Pinchart
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200817000908.GD7729@pendragon.ideasonboard.com \
--to=laurent.pinchart@ideasonboard.com \
--cc=agx@sigxcpu.org \
--cc=devicetree@vger.kernel.org \
--cc=dri-devel@lists.freedesktop.org \
--cc=kernel@pengutronix.de \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=marex@denx.de \
--cc=robh+dt@kernel.org \
--cc=stefan@agner.ch \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).