From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-4.0 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 86F14C433DF for ; Mon, 17 Aug 2020 05:17:34 +0000 (UTC) Received: from merlin.infradead.org (merlin.infradead.org [205.233.59.134]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 54F0620758 for ; Mon, 17 Aug 2020 05:17:34 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="g+Jdafhf"; dkim=fail reason="signature verification failed" (1024-bit key) header.d=kernel.org header.i=@kernel.org header.b="zqll9qTk" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 54F0620758 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=kernel.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=merlin.20170209; h=Sender:Content-Transfer-Encoding: Content-Type:Cc:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References:Message-ID: Subject:To:From:Date:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=gRtqbURKVZhnOW3webm6Gh2woEPAG44R5fSWGfeL4CU=; b=g+Jdafhfl8/OKU7XOnOAviupN b3QBWGCtPruWqDwpexReJmadGZ/k33CpnsSHrh/bkfIC8jo31DVdf4Mv10JnxcHd7adXwlh1IwUsD jNcjl8774WOjupWdPv+OZIKmofzatxqWG8IuMSL82TLTvlDiZyBM5+oF3frJrpZuoE/mmzEUFbO/O m7iKIHU8WXQoJcUBXQ9xRbvZ8wFxP7LGQ8wMg7/iWb+HMrWUoLy8dmcIO6Ix0P3oCXThfniqtT2pt w316zvAzd9IHwWOgB/DTMD3Qtu+V6Ov5xh5rnmASqEt/4OjkYDRVOsheF3AGWAQGcKZG15fO+Noid S0tLbJuNg==; Received: from localhost ([::1] helo=merlin.infradead.org) by merlin.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1k7XVI-0003Oh-Bt; Mon, 17 Aug 2020 05:16:16 +0000 Received: from mail.kernel.org ([198.145.29.99]) by merlin.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1k7XVF-0003OD-9l for linux-arm-kernel@lists.infradead.org; Mon, 17 Aug 2020 05:16:14 +0000 Received: from localhost (unknown [122.171.38.130]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id C3C1520758; Mon, 17 Aug 2020 05:16:10 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1597641371; bh=7eos3FUEtXEfjD7Mgm5b/JLUuuvN1wr3ZQd5jd4Eiz4=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=zqll9qTkqnL+BCtIekZsy576BRHmSkI9wDaTXk2VmJ/faosKRX5rPHoyomfxOA9qe o5HE0AHNmhStQVcl1VyRvum0RAABUszl1v1kmqizUj9V9Ig6LNKmGoO2K2m3pFLZX5 EyohQnSeHw+Q5OTVAzsUZJF9VWjuXkTBWmCkQ70w= Date: Mon, 17 Aug 2020 10:46:07 +0530 From: Vinod Koul To: Yu Kuai Subject: Re: [PATCH] dmaengine: at_hdmac: do exception handling appropriately in at_dma_xlate() Message-ID: <20200817051607.GF2639@vkoul-mobl> References: <20200729122903.2473297-1-yukuai3@huawei.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20200729122903.2473297-1-yukuai3@huawei.com> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20200817_011613_426500_554E10F8 X-CRM114-Status: UNSURE ( 9.53 ) X-CRM114-Notice: Please train this message. X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: arnd@arndb.de, tudor.ambarus@microchip.com, yi.zhang@huawei.com, linux-kernel@vger.kernel.org, ludovic.desroches@microchip.com, dmaengine@vger.kernel.org, dan.j.williams@intel.com, plagnioj@jcrosoft.com, linux-arm-kernel@lists.infradead.org Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On 29-07-20, 20:29, Yu Kuai wrote: > Do several things for exception handing: > > a. check return value of of_find_device_by_node(). > b. call put_device() if memory allocation for 'atslave' failed. > c. if dma_request_channel() failed, call put_device() and kfree(). One patch per change please -- ~Vinod _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel