From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-9.8 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH, MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id E4A58C433DF for ; Mon, 17 Aug 2020 05:39:39 +0000 (UTC) Received: from merlin.infradead.org (merlin.infradead.org [205.233.59.134]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id B1BAB2078A for ; Mon, 17 Aug 2020 05:39:39 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="oYh2JVx8"; dkim=fail reason="signature verification failed" (2048-bit key) header.d=skidata.com header.i=@skidata.com header.b="EcbgkHnt" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org B1BAB2078A Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=skidata.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=merlin.20170209; h=Sender:Content-Transfer-Encoding: Content-Type:Cc:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References:Message-ID: Subject:To:From:Date:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=1hBMAryUwIP+7pJsFmOCypwnYNOyxTJMsRp0aUfp+fE=; b=oYh2JVx85o9zdLV4mE4F2d1Uo 1Na8WvZwL8E5OonO/XkyjP+0AeIeSdfKXQB7yZbwFBU5TLZ9EuoivuVl6XI0FMr7SGBHoNEZVxCLP 9q2/BVD43/uWEfR7/f++Fojqn93SwkM9XOKTREa/PiADy0Klq7ere6fYr00NryzDZulBI50EPt1zl BWFisSF+EV/SOlWErP4Dp/9zDQ2msynd4lWCN4XJlG0wd8TDCHm+MTyDklXMcGz0fsa7CP5QM2pHE SjDpbKeBz3zc3vDMXg6V/utQIbAVU63G2NTKvEEE1r4q1wu6Q+pgG7Wce7QBeNyXmpVVO9hAbW73y pOqDl15TQ==; Received: from localhost ([::1] helo=merlin.infradead.org) by merlin.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1k7Xqe-0005tD-Rr; Mon, 17 Aug 2020 05:38:20 +0000 Received: from mail1.skidata.com ([91.230.2.99]) by merlin.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1k7Xqb-0005st-Uz for linux-arm-kernel@lists.infradead.org; Mon, 17 Aug 2020 05:38:19 +0000 DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=skidata.com; i=@skidata.com; q=dns/txt; s=selector1; t=1597642697; x=1629178697; h=date:from:to:cc:subject:message-id:references: mime-version:content-transfer-encoding:in-reply-to; bh=VYLBjYz9lx/nrXI3opLlz8j0PHFlXG1/ZEX5YI80V6Y=; b=EcbgkHntg3hguQuZkhpIwhDRJCTqn2tAg0NecCGXER2sn/3j8vgq0AZC nvV3w69gZYUg7Ur1CIZdYWsRb57Cl9Np7CAgHuria4KXRRR4js0SoVI/P /tAkojo5g404VBxSCYODRVCbp/b5pqcJk96KN7jiTlOozIALLc+so6ZMF yZB/htj+bDgiV568DKojtV5Ei/VK2IhN4a4Mu4J7OJ3aD7qJa4JyfW4lV 0tgLnS8jxy6GnWZt2RdSlpDUiYkB6dNPyvDrD8Y0RztDDHWJCYAxw+Mbs 3EIeA7MVnIQn9Ed6ekDRAa5ZNVzkBFyknJZD5G8hR483S2bEI3fngzoCy Q==; IronPort-SDR: svI9QV3IU5oopAVv5yamxDgdlocA1iJY3YSUF4EoHghv0pgx7rr8qYaXkKz5Omkxq2uybaSfdj 1dD7IDxYChlmXsW52gUikLfeYy0fDPtToSUvTzOiSLEDrAr1H5ycWGdiqrHMmlVmzVGFcjGjCn vyiYzbUfXj4k21HYamaZ92VvdFf1lutJUyxZ0kD6RwOaFA6yq59RZ3P9gLdmKUd6AbU7Ummw4D Y2lkzlC6cjdyZtDG5ddHSKZVBFRj2gbaypEpl+VvtyBmVS+EJKOQQZ0r5NVceKThI+XQuyf8Qn 3/U= X-IronPort-AV: E=Sophos;i="5.76,322,1592863200"; d="scan'208";a="26161391" Date: Mon, 17 Aug 2020 07:38:13 +0200 From: Richard Leitner To: Robin Gong Subject: Re: [PATCH v12 03/12] Revert "dmaengine: imx-sdma: refine to load context only once" Message-ID: <20200817053813.GA551027@pcleri> References: <1597161231-32303-1-git-send-email-yibin.gong@nxp.com> <1597161231-32303-4-git-send-email-yibin.gong@nxp.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <1597161231-32303-4-git-send-email-yibin.gong@nxp.com> X-Originating-IP: [192.168.111.252] X-ClientProxiedBy: sdex6srv.skidata.net (192.168.111.84) To sdex5srv.skidata.net (192.168.111.83) X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20200817_013818_344819_0258DFEF X-CRM114-Status: GOOD ( 17.77 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: mark.rutland@arm.com, catalin.marinas@arm.com, r.schwebel@pengutronix.de, will.deacon@arm.com, festevam@gmail.com, matthias.schiffer@ew.tq-group.com, frieder.schrempf@kontron.de, linux-imx@nxp.com, martin.fuzzey@flowbird.group, u.kleine-koenig@pengutronix.de, devicetree@vger.kernel.org, s.hauer@pengutronix.de, robh+dt@kernel.org, dan.j.williams@intel.com, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, linux-spi@vger.kernel.org, vkoul@kernel.org, broonie@kernel.org, kernel@pengutronix.de, dmaengine@vger.kernel.org, shawnguo@kernel.org Content-Type: text/plain; charset="iso-8859-1" Content-Transfer-Encoding: quoted-printable Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Tue, Aug 11, 2020 at 11:53:42PM +0800, Robin Gong wrote: > This reverts commit ad0d92d7ba6aecbe2705907c38ff8d8be4da1e9c, because > in spi-imx case, burst length may be changed dynamically. > = > Signed-off-by: Robin Gong > Acked-by: Sascha Hauer Hi Robin, thanks for the pointer to this patch. As you suggested I've tested the two patches on my custom i.MX6DL board. Therefore please feel free to add: Tested-by: Richard Leitner regards;rl > --- > drivers/dma/imx-sdma.c | 8 -------- > 1 file changed, 8 deletions(-) > = > diff --git a/drivers/dma/imx-sdma.c b/drivers/dma/imx-sdma.c > index 270992c..d305b80 100644 > --- a/drivers/dma/imx-sdma.c > +++ b/drivers/dma/imx-sdma.c > @@ -377,7 +377,6 @@ struct sdma_channel { > unsigned long watermark_level; > u32 shp_addr, per_addr; > enum dma_status status; > - bool context_loaded; > struct imx_dma_data data; > struct work_struct terminate_worker; > }; > @@ -984,9 +983,6 @@ static int sdma_load_context(struct sdma_channel *sdm= ac) > int ret; > unsigned long flags; > = > - if (sdmac->context_loaded) > - return 0; > - > if (sdmac->direction =3D=3D DMA_DEV_TO_MEM) > load_address =3D sdmac->pc_from_device; > else if (sdmac->direction =3D=3D DMA_DEV_TO_DEV) > @@ -1029,8 +1025,6 @@ static int sdma_load_context(struct sdma_channel *s= dmac) > = > spin_unlock_irqrestore(&sdma->channel_0_lock, flags); > = > - sdmac->context_loaded =3D true; > - > return ret; > } > = > @@ -1069,7 +1063,6 @@ static void sdma_channel_terminate_work(struct work= _struct *work) > vchan_get_all_descriptors(&sdmac->vc, &head); > spin_unlock_irqrestore(&sdmac->vc.lock, flags); > vchan_dma_desc_free_list(&sdmac->vc, &head); > - sdmac->context_loaded =3D false; > } > = > static int sdma_terminate_all(struct dma_chan *chan) > @@ -1337,7 +1330,6 @@ static void sdma_free_chan_resources(struct dma_cha= n *chan) > = > sdmac->event_id0 =3D 0; > sdmac->event_id1 =3D 0; > - sdmac->context_loaded =3D false; > = > sdma_set_channel_priority(sdmac, 0); > = > -- = > 2.7.4 > = > = -- = Richard Leitner Hardware R&D / Senior Embedded Linux Engineer SKIDATA | Driving Your Digital Future SKIDATA GmbH Untersbergstra=DFe 40 | 5083 Gr=F6dig/Salzburg | Austria [t] +43-6246-888-4245 | [m] +43-664-88616370 [w] www.skidata.com _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel