From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-9.8 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH, MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id DBED2C433E1 for ; Mon, 17 Aug 2020 05:39:43 +0000 (UTC) Received: from merlin.infradead.org (merlin.infradead.org [205.233.59.134]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id ABD34206FA for ; Mon, 17 Aug 2020 05:39:43 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="tuWciLRL"; dkim=fail reason="signature verification failed" (2048-bit key) header.d=skidata.com header.i=@skidata.com header.b="mYYHOIi6" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org ABD34206FA Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=skidata.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=merlin.20170209; h=Sender:Content-Transfer-Encoding: Content-Type:Cc:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References:Message-ID: Subject:To:From:Date:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=G1v8lo9RLonMPQ4ZZaqA5nEhhV7uTup7b1ECLzVJmb8=; b=tuWciLRLe+6yJxGchojeLnBlf U+Y7ymjHdtt4Gd3tuF4DyUD3upoZFUcZ0T2OC9BY2jpJbwK56aCES67ab9P29i1qAzvIsBZY3QWF+ PakLYZ6cYDHsnnGdOSM5/QcNP3i0FrBA1UKbX61ZPQAGKCQQDLTXdNluI0SGLiZlXz5HZF4FNOX5H 0vNCAcnuRQPuYAfsRVItdap+bPJKBal96eVi83PwL11kIYqC4Ys9vhOixv7RdwGVR11XOQoYsjkfU TkprCRdGH2tIQ8xBbqej5N7QAfnqas0HiWsWmzoZSfqhejF+kRj3unfH2WqMYPCfNsZh2Nh6dAkDR JGnCasscw==; Received: from localhost ([::1] helo=merlin.infradead.org) by merlin.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1k7Xqk-0005tm-LP; Mon, 17 Aug 2020 05:38:26 +0000 Received: from mail2.skidata.com ([91.230.2.91]) by merlin.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1k7Xqi-0005tP-Cv for linux-arm-kernel@lists.infradead.org; Mon, 17 Aug 2020 05:38:25 +0000 DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=skidata.com; i=@skidata.com; q=dns/txt; s=selector1; t=1597642703; x=1629178703; h=date:from:to:cc:subject:message-id:references: mime-version:content-transfer-encoding:in-reply-to; bh=iq6E0tROTvyWLYPqPO1Jep0gNCBrkGzldGCPeMg+7YQ=; b=mYYHOIi6g3tBL7p3UrxPONFryDlUOb31mn5Dh51WSQx/mg6h6+5bMeyH hFDKr5Xc89YIxbFE+yDIeNPnkfVMVbbNgHHinSKTgV1Pc4AKzX1DJFXtj uzVO1oKDNqWGuQ/xRXBuLKrL/7owT+Bv7MQPz/qPXhhdY0s491G+Bkn2F jpRM2aT39Kd6l2fdK41McsZcQD4XH0Q9t05sW40StToZPusKVyeUOAEYj B4rMYKfnOlOWlasG2A7/+h+ETUOZ/oMk2C8j5x+jO1P05KnIiidAdX/hx krsFMZ4U+BDkxXB6VKHbq2AnA1tbSKKb9+up20vrJ31oZ5mrEjcAuzJln A==; IronPort-SDR: rZkcM47agA66V7rz7feaMdOluzUqk0bpZwPNFBS4nRIuINpiwtoyuu5PvhKvd7GxTCNDYB6kXY q+8aPl4488YU/sH1xOfKWdB3CMlyy7Wmb9WhpewAqI8mDDklAMKIou3zPjCur2Svcz1ng1Oj8Z Zy7WxGnwP3YJWucu6wpo6YHFvYGa5JHGgsVwTkK/rDs/Q9q8+zXUyPiuiSF72FTDQ+I8JVsk45 na+58Ifn3fOwiZaehwKqTEjAYKrWjacs9o1T8V1VGA9ce2sOYhvzzUx0Gd/5S3O54kP7NGQAU7 SbE= X-IronPort-AV: E=Sophos;i="5.76,322,1592863200"; d="scan'208";a="2642498" Date: Mon, 17 Aug 2020 07:38:20 +0200 From: Richard Leitner To: Robin Gong Subject: Re: [PATCH v12 04/12] dmaengine: imx-sdma: remove duplicated sdma_load_context Message-ID: <20200817053820.GB551027@pcleri> References: <1597161231-32303-1-git-send-email-yibin.gong@nxp.com> <1597161231-32303-5-git-send-email-yibin.gong@nxp.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <1597161231-32303-5-git-send-email-yibin.gong@nxp.com> X-Originating-IP: [192.168.111.252] X-ClientProxiedBy: sdex6srv.skidata.net (192.168.111.84) To sdex5srv.skidata.net (192.168.111.83) X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20200817_013824_718044_0D1F2491 X-CRM114-Status: GOOD ( 17.02 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: mark.rutland@arm.com, catalin.marinas@arm.com, r.schwebel@pengutronix.de, will.deacon@arm.com, festevam@gmail.com, matthias.schiffer@ew.tq-group.com, frieder.schrempf@kontron.de, linux-imx@nxp.com, martin.fuzzey@flowbird.group, u.kleine-koenig@pengutronix.de, devicetree@vger.kernel.org, s.hauer@pengutronix.de, robh+dt@kernel.org, dan.j.williams@intel.com, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, linux-spi@vger.kernel.org, vkoul@kernel.org, broonie@kernel.org, kernel@pengutronix.de, dmaengine@vger.kernel.org, shawnguo@kernel.org Content-Type: text/plain; charset="iso-8859-1" Content-Transfer-Encoding: quoted-printable Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Tue, Aug 11, 2020 at 11:53:43PM +0800, Robin Gong wrote: > Since sdma_transfer_init() will do sdma_load_context before any > sdma transfer, no need once more in sdma_config_channel(). > = > Signed-off-by: Robin Gong > Acked-by: Vinod Koul Hi Robin, thanks for the pointer to this patch. As you suggested I've tested the two patches on my custom i.MX6DL board. Therefore please feel free to add: Tested-by: Richard Leitner regards;rl > --- > drivers/dma/imx-sdma.c | 5 +---- > 1 file changed, 1 insertion(+), 4 deletions(-) > = > diff --git a/drivers/dma/imx-sdma.c b/drivers/dma/imx-sdma.c > index d305b80..5411e01e 100644 > --- a/drivers/dma/imx-sdma.c > +++ b/drivers/dma/imx-sdma.c > @@ -1137,7 +1137,6 @@ static void sdma_set_watermarklevel_for_p2p(struct = sdma_channel *sdmac) > static int sdma_config_channel(struct dma_chan *chan) > { > struct sdma_channel *sdmac =3D to_sdma_chan(chan); > - int ret; > = > sdma_disable_channel(chan); > = > @@ -1177,9 +1176,7 @@ static int sdma_config_channel(struct dma_chan *cha= n) > sdmac->watermark_level =3D 0; /* FIXME: M3_BASE_ADDRESS */ > } > = > - ret =3D sdma_load_context(sdmac); > - > - return ret; > + return 0; > } > = > static int sdma_set_channel_priority(struct sdma_channel *sdmac, > -- = > 2.7.4 > = > = -- = Richard Leitner Hardware R&D / Senior Embedded Linux Engineer SKIDATA | Driving Your Digital Future SKIDATA GmbH Untersbergstra=DFe 40 | 5083 Gr=F6dig/Salzburg | Austria [t] +43-6246-888-4245 | [m] +43-664-88616370 [w] www.skidata.com _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel