From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-11.5 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 51D68C433E1 for ; Mon, 17 Aug 2020 07:26:01 +0000 (UTC) Received: from merlin.infradead.org (merlin.infradead.org [205.233.59.134]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 14B792078A for ; Mon, 17 Aug 2020 07:26:01 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="AP2e3c/a"; dkim=fail reason="signature verification failed" (1024-bit key) header.d=kernel.org header.i=@kernel.org header.b="1O/c3EyD" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 14B792078A Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=kernel.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=merlin.20170209; h=Sender:Content-Transfer-Encoding: Content-Type:Cc:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References:Message-ID: Subject:To:From:Date:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=d2eGDAFbbiA0pQPs7UwDyC6hx44xrAQarZGbto6Uk58=; b=AP2e3c/aUl9zyHtu3M0qXaXbU n5+mAHP9TuK/wHMKIkN4S+u6UtYIabYt2vQiRPXu76tA1uVdeBFnT1YYRTm/Bc0r1eTG6eTADEGBq dC1Y6Qq8gJBC2hRhu6hLZLuE2WIPQQ60RRdfBPrzAzHVHKUDoBugSuRmRmRAe197XKSzA9RdP2XaW iDpb0LbNm2xaxGQ5xvYwTU9os/bWL9LYB+okBg5hpzULokXSPLDe42Q1fX+BmNK5SuIu3mXTvc46T uJMfvn68CUfZ7K+CCSQd9A4BYF1rMpNgG/WygYRolohc5glRPqf5gPSrBIp7HxWSDN5n2cgZKGfGH /3Eb3FrmQ==; Received: from localhost ([::1] helo=merlin.infradead.org) by merlin.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1k7ZVe-00025b-Mt; Mon, 17 Aug 2020 07:24:46 +0000 Received: from mail.kernel.org ([198.145.29.99]) by merlin.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1k7ZVc-000252-V8 for linux-arm-kernel@lists.infradead.org; Mon, 17 Aug 2020 07:24:45 +0000 Received: from dragon (unknown [80.251.214.228]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 5569B2078A; Mon, 17 Aug 2020 07:24:39 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1597649084; bh=GYW9XIgt96UFVvyINCSvQk8LTwxUWcbA2TkHRjIuXWA=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=1O/c3EyDjPHx4v+iuWxPvIbAJtgCpMXH7RFareBCCDmdSm/RD1CyGIdfBI5Hhi8Dd KVJx1GgcUKZ85t9WYgrXNX/7j6GM5NnH5BfVK1EHc3ZY9WTn4Jjys1YCRAQHpfUi1S SiCKhU8B2y5DR5gapVtUhml4r6OjFBlvdTY2V8N0= Date: Mon, 17 Aug 2020 15:24:24 +0800 From: Shawn Guo To: Steffen Trumtrar , Fugang Duan Subject: Re: [PATCH v2 1/4] ARM: imx7d: add enet2 clk sel Message-ID: <20200817072423.GB16951@dragon> References: <20200714051140.8090-1-s.trumtrar@pengutronix.de> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20200714051140.8090-1-s.trumtrar@pengutronix.de> User-Agent: Mutt/1.9.4 (2018-02-28) X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20200817_032445_192067_C440ED42 X-CRM114-Status: GOOD ( 19.15 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: linux-arm-kernel@lists.infradead.org, Rob Herring , Fabio Estevam , NXP Linux Team , Pengutronix Kernel Team Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Tue, Jul 14, 2020 at 07:11:37AM +0200, Steffen Trumtrar wrote: > Add clock source init for the second ethernet port. > This changes the clock direction and clock selection in a way that the > ethernet phy reference clock is routed as an output. > > Signed-off-by: Steffen Trumtrar > --- > arch/arm/mach-imx/mach-imx7d.c | 3 +++ > 1 file changed, 3 insertions(+) > > diff --git a/arch/arm/mach-imx/mach-imx7d.c b/arch/arm/mach-imx/mach-imx7d.c > index 879c35929a13..7a203f660721 100644 > --- a/arch/arm/mach-imx/mach-imx7d.c > +++ b/arch/arm/mach-imx/mach-imx7d.c > @@ -65,6 +65,9 @@ static void __init imx7d_enet_clk_sel(void) > if (!IS_ERR(gpr)) { > regmap_update_bits(gpr, IOMUXC_GPR1, IMX7D_GPR1_ENET_TX_CLK_SEL_MASK, 0); > regmap_update_bits(gpr, IOMUXC_GPR1, IMX7D_GPR1_ENET_CLK_DIR_MASK, 0); > + regmap_update_bits(gpr, IOMUXC_GPR1, IMX7D_GPR1_ENET2_TX_CLK_SEL_MASK, 0); > + regmap_update_bits(gpr, IOMUXC_GPR1, IMX7D_GPR1_ENET2_CLK_DIR_MASK, > + IMX7D_GPR1_ENET2_CLK_DIR_MASK); I would like to see such code get removed from machine code rather than added. Can we deal with these IOMUXC_GPR bits in some driver code? Shawn > } else { > pr_err("failed to find fsl,imx7d-iomux-gpr regmap\n"); > } > -- > 2.27.0 > _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel