From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-11.3 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH, MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id CFABBC433E1 for ; Mon, 17 Aug 2020 14:17:02 +0000 (UTC) Received: from merlin.infradead.org (merlin.infradead.org [205.233.59.134]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 80E1720674 for ; Mon, 17 Aug 2020 14:17:02 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="rFJp/R38"; dkim=fail reason="signature verification failed" (2048-bit key) header.d=netronome-com.20150623.gappssmtp.com header.i=@netronome-com.20150623.gappssmtp.com header.b="El20VIDg" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 80E1720674 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=netronome.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=merlin.20170209; h=Sender:Content-Transfer-Encoding: Content-Type:Cc:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References:Message-ID: Subject:To:From:Date:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=UWkc/9MGO5a/0piHUZ8Q5oUH7BFdYFT+2Q3UlcT7lOQ=; b=rFJp/R38S3fHmflHz25/Le3Vt rBsg/OF7PCTiUHG/cDSH8w2nMYrqMmT+6txsXKILTNgyl/qvGAMMWbSqipyLqfIrPE9gwv8Ap/2l7 QjcfZWeEkiL08ZoHvkzXKEf+HZxBSKHtmXhdJiBZTEOyVWvBIofqDx7gMRwuYTUz+YCf8ialVD+OU AlNxSsRFVRkuNibjQ5ZRXhXsa8xMpCsOXWgIs3r22WaPSETfgQzUYNTCIyptM+D4AfsSll5IENTSc +cxvVgloJAH8lHalhxCe52w3A9G9F6TudnakzsLBGDDoqUsHGn7WcLDPXhx9lwOaTk0U4AeMb+2Tu ZezOV4zoA==; Received: from localhost ([::1] helo=merlin.infradead.org) by merlin.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1k7fvJ-000582-PT; Mon, 17 Aug 2020 14:15:41 +0000 Received: from mail-ed1-x541.google.com ([2a00:1450:4864:20::541]) by merlin.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1k7fvG-00057Q-En for linux-arm-kernel@lists.infradead.org; Mon, 17 Aug 2020 14:15:39 +0000 Received: by mail-ed1-x541.google.com with SMTP id ba10so12397974edb.3 for ; Mon, 17 Aug 2020 07:15:35 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=netronome-com.20150623.gappssmtp.com; s=20150623; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to:user-agent; bh=5GU+hvhFq5FTqZEE9oONoXIkAiVxgc+Oe9aNa54OoQw=; b=El20VIDg2NdzHYr8IDobZ35xvin+mYvK5IfVN6E9Mz2vqJozybe5i/2Wlxsfn/Sw/y f0k6vhoiwuZpjkzNSH7o+/kxhGMI3IyIdKA4L1csfLFdCS6VvpM1KpyCMatdms38ockb vn6Q6r/gun8WRAuHZEgnHoD53UF7AoIaf1iQ4RKKUOFzHezYOMIPu4FjKKdkid1QrTsN XYkEGMgZuM9FY7pC3oZAX3Vg3vp1JBtMrz/WWZifbhpZStXw/b3vMHLDcnShb+UIMLC4 o9oDwufDPJMlMN5ma80n0X1ZjkPVvlDsh9iTTR2Y6qpP13GK5L2sWymrfnPwd48VcEor G8Jg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to:user-agent; bh=5GU+hvhFq5FTqZEE9oONoXIkAiVxgc+Oe9aNa54OoQw=; b=SIG6rdfHRiRuu8CdVqQIMvkgaaEC/nHRAdp6p0ph6v/NMTmw8Z251HwMT5k4eGrnEL KlcaGTrALpKQqkpvkoa1tY929U25iUlinVAPImpecApnVc8W6zSb8oyI37DIsroT2tUP tFbR1nK67J89hDxYrFjafz2IwJoQI1rOzZZBAB2MO67BRJrv2ZcA7ArhTz0xsCLv3ar6 vM8Uw5fZffGureE78rDuOhqqzgjpCu13yLkaQqUHDap8w2szQ1uJHdzGDjYub/12gKeX OrQwJ2X3AWDjXGdEfD9EycawRQv89dVsn8Ywz37ceJKJ0LJRaHP1VIN+Tft7CFLGffIs vduw== X-Gm-Message-State: AOAM530POmALN6S/SrhbM5eQ0BGLu+UOKbZrRQbHPnO2WbaAGInR03p6 Z3TJHtkJCf/6t4eDqwxz/HsdRQ== X-Google-Smtp-Source: ABdhPJzjr9ZxRXnAgQ3pOgNu0n1L4UO5JB4hdIav5PocnLg1VrC/U2k8Jix0avX3cyR6efPTsghljQ== X-Received: by 2002:a05:6402:3121:: with SMTP id dd1mr15268241edb.72.1597673735048; Mon, 17 Aug 2020 07:15:35 -0700 (PDT) Received: from netronome.com ([2001:982:7ed1:403:9eeb:e8ff:fe0d:5b6a]) by smtp.gmail.com with ESMTPSA id g19sm14563399ejz.5.2020.08.17.07.15.33 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 17 Aug 2020 07:15:34 -0700 (PDT) Date: Mon, 17 Aug 2020 16:15:33 +0200 From: Simon Horman To: Allen Pais Subject: Re: [oss-drivers] [PATCH 16/20] ethernet: netronome: convert tasklets to use new tasklet_setup() API Message-ID: <20200817141532.GA4130@netronome.com> References: <20200817082434.21176-1-allen.lkml@gmail.com> <20200817082434.21176-18-allen.lkml@gmail.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20200817082434.21176-18-allen.lkml@gmail.com> User-Agent: Mutt/1.10.1 (2018-07-13) X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20200817_101538_627897_E7E2AAED X-CRM114-Status: GOOD ( 19.60 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: jes@trained-monkey.org, borisp@mellanox.com, keescook@chromium.org, linux-rdma@vger.kernel.org, netdev@vger.kernel.org, kda@linux-powerpc.org, cooldavid@cooldavid.org, dougmill@linux.ibm.com, linux-kernel@vger.kernel.org, linux-acenic@sunsite.dk, oss-drivers@netronome.com, kuba@kernel.org, Romain Perier , linuxppc-dev@lists.ozlabs.org, davem@davemloft.net, linux-arm-kernel@lists.infradead.org, mlindner@marvell.com Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Mon, Aug 17, 2020 at 01:54:30PM +0530, Allen Pais wrote: > In preparation for unconditionally passing the > struct tasklet_struct pointer to all tasklet > callbacks, switch to using the new tasklet_setup() > and from_tasklet() to pass the tasklet pointer explicitly. > > Signed-off-by: Romain Perier > Signed-off-by: Allen Pais Reviewed-by: Simon Horman But: This series should be targeted at net-next, and thus have net-next in its subject [PATCH net-next x/y] ... And it should be posted when net-next is open: it is currently closed. http://vger.kernel.org/~davem/net-next.html > --- > drivers/net/ethernet/netronome/nfp/nfp_net_common.c | 7 +++---- > 1 file changed, 3 insertions(+), 4 deletions(-) > > diff --git a/drivers/net/ethernet/netronome/nfp/nfp_net_common.c b/drivers/net/ethernet/netronome/nfp/nfp_net_common.c > index 39ee23e8c0bf..1dcd24d899f5 100644 > --- a/drivers/net/ethernet/netronome/nfp/nfp_net_common.c > +++ b/drivers/net/ethernet/netronome/nfp/nfp_net_common.c > @@ -2287,9 +2287,9 @@ static bool nfp_ctrl_rx(struct nfp_net_r_vector *r_vec) > return budget; > } > > -static void nfp_ctrl_poll(unsigned long arg) > +static void nfp_ctrl_poll(struct tasklet_struct *t) > { > - struct nfp_net_r_vector *r_vec = (void *)arg; > + struct nfp_net_r_vector *r_vec = from_tasklet(r_vec, t, tasklet); > > spin_lock(&r_vec->lock); > nfp_net_tx_complete(r_vec->tx_ring, 0); > @@ -2337,8 +2337,7 @@ static void nfp_net_vecs_init(struct nfp_net *nn) > > __skb_queue_head_init(&r_vec->queue); > spin_lock_init(&r_vec->lock); > - tasklet_init(&r_vec->tasklet, nfp_ctrl_poll, > - (unsigned long)r_vec); > + tasklet_setup(&r_vec->tasklet, nfp_ctrl_poll); > tasklet_disable(&r_vec->tasklet); > } > > -- > 2.17.1 > _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel