From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.8 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS,USER_AGENT_GIT autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 78CD5C433E1 for ; Mon, 17 Aug 2020 17:07:03 +0000 (UTC) Received: from merlin.infradead.org (merlin.infradead.org [205.233.59.134]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 44AFB2067C for ; Mon, 17 Aug 2020 17:07:03 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="v53KlTAf"; dkim=fail reason="signature verification failed" (2048-bit key) header.d=bgdev-pl.20150623.gappssmtp.com header.i=@bgdev-pl.20150623.gappssmtp.com header.b="ITRrUO21" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 44AFB2067C Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=bgdev.pl Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=merlin.20170209; h=Sender:Content-Transfer-Encoding: Content-Type:Cc:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:MIME-Version:Message-Id:Date:Subject:To:From: Reply-To:Content-ID:Content-Description:Resent-Date:Resent-From:Resent-Sender :Resent-To:Resent-Cc:Resent-Message-ID:In-Reply-To:References:List-Owner; bh=SFKmSnIXp+CRkwn3YvayzHLGEycmM5xbGE0bs0XP+aU=; b=v53KlTAfo0g0ql2TlCkGM+MkL2 RppDmcLcikhOmsFhqZoAiSxqKVmHCjKUhjdhvIfWFY8qTZj+fC+4CCb3cnmsaxZLMPH28U8RepqKZ PMzvXnYvcA1A/yKHp1WvN8grS5H9WbiB1atB+TYg7NL9HswuiA9ZQXOVdJHs+etnqq3EtMdkjMRXd AKwHDBIfUUKp9TaEjVSJGZs8k7sjssP3VwUWsayWg/RVBwJv3nBkTZ33hQzIP6m2d5bqKSvVSZIsl DIh2TUsZCD4LcLzvfYciz0QDDdN9MQaxWADPw2zoxwXmLYv4bDf1w0Mk3YHs2tthG8rahY0JbvE7Z dE8UkXpA==; Received: from localhost ([::1] helo=merlin.infradead.org) by merlin.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1k7iZt-0007jo-Ev; Mon, 17 Aug 2020 17:05:45 +0000 Received: from mail-wm1-x342.google.com ([2a00:1450:4864:20::342]) by merlin.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1k7iZp-0007iH-Jc for linux-arm-kernel@lists.infradead.org; Mon, 17 Aug 2020 17:05:42 +0000 Received: by mail-wm1-x342.google.com with SMTP id g8so13847823wmk.3 for ; Mon, 17 Aug 2020 10:05:40 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=bgdev-pl.20150623.gappssmtp.com; s=20150623; h=from:to:cc:subject:date:message-id:mime-version :content-transfer-encoding; bh=Ch+bM0/nUYIOT7cRcwubqqUU36WUEhTLPi7zotN6dio=; b=ITRrUO21ngebvWm9j+03QV3n0tPRcS57uZLesFg4Fh73jpL38IRqaUiFq1ht2His/g kwv8RvVgsdoEOzEV0e3sf6Fon8eelIScjRJWN6ShAhQcqGU1azZ9eiAZQNtOB9BxIswP o9PsFIooXcNuqKqc110bJg8pddoTCQT+iUOu2nJOA54wkClOHHdURoLj6FPntf0ZR4X/ OB4lxJCMFv15zZ4MLzOc5jbQqqxU0XoHhO7mJLyiJBwTOu4zjU1JJHVBhK9qvV7sX1NY w6jDFZq0L8f5Xwwev6/20uZQT9/OJZsERAmwn9ehlKmuWVBNvDYgXdVoZLToQw7TbpLy D4iw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:mime-version :content-transfer-encoding; bh=Ch+bM0/nUYIOT7cRcwubqqUU36WUEhTLPi7zotN6dio=; b=CrZzxZqpGykbQOEtlapr/WV3Igzd0I/XSjE4pLkr+Pkwnh0Ln+pJP18+SRILWIzJca qZHBSMKUerLTkZdA4LBfIzkKJj12jACo+FWxE5m67EAGMd5Pxvn9jrlr7cx7ki+ZnLWi fCsPUs7cR+A5zZChBGWF3B0umeFzDExjXuD/ALVsuB7CirJYZ/vL1q1a3piAuXwADx1A NHJabKOLC6S4A1QvFy0D7BoAB9kC6o2t0+gaUUbtDwkuIxhq//hhJtgjWbSTuYMTI2eS Q02qhImClWm9NlhoxWKXLL8sDYMVPoaDldxXtAe6n6Y/Pq/1pM3Fqx3Mn+Bi9fwCZu/u 2EOA== X-Gm-Message-State: AOAM533s6NyqQx6hgPO2ZSCO5NFDp24f3d2fwqVkkk/8XRzHBfrdpcOv 0tqxygKX3gt5SiC41qaWX17mrw== X-Google-Smtp-Source: ABdhPJy54z0Stss+3IUESXNQ+OZuPidLgQs6L/EOj7nJxU8HbSFzXIkZDadL+9l32ahhBkJk1YCBsw== X-Received: by 2002:a7b:c242:: with SMTP id b2mr16109424wmj.90.1597683939473; Mon, 17 Aug 2020 10:05:39 -0700 (PDT) Received: from debian-brgl.home (lfbn-nic-1-68-20.w2-15.abo.wanadoo.fr. [2.15.159.20]) by smtp.gmail.com with ESMTPSA id k184sm29747177wme.1.2020.08.17.10.05.38 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 17 Aug 2020 10:05:38 -0700 (PDT) From: Bartosz Golaszewski To: Jonathan Cameron , Hartmut Knaack , Lars-Peter Clausen , Peter Meerwald-Stadler , Michal Simek , Greg Kroah-Hartman , Guenter Roeck , Andy Shevchenko Subject: [PATCH v7 0/3] devres: provide and use devm_krealloc() Date: Mon, 17 Aug 2020 19:05:32 +0200 Message-Id: <20200817170535.17041-1-brgl@bgdev.pl> X-Mailer: git-send-email 2.26.1 MIME-Version: 1.0 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20200817_130541_774542_0608AFF8 X-CRM114-Status: GOOD ( 16.25 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: linux-iio@vger.kernel.org, Bartosz Golaszewski , linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org From: Bartosz Golaszewski Hi Greg, Andy, this is another reworked version of devm_krealloc(). This time without the risk of sleeping with spinlock taken but still with enough protection for the devres list. We're using slab's ksize() to determine whether the new size is larger than the current real size of the chunk and then either return the same pointer or manually alloc a new, larger chunk outside of the spinlock. === Regular krealloc() obviously can't work with managed memory. This series implements devm_krealloc() and adds two first users with hope that this helper will be adopted by other drivers currently using non-managed krealloc(). v1 -> v2: - remove leftover call to hwmon_device_unregister() from pmbus_core.c - add a patch extending devm_kmalloc() to handle zero size case - use WARN_ON() instead of WARN_ONCE() in devm_krealloc() when passed a pointer to non-managed memory - correctly handle the case when devm_krealloc() is passed a pointer to memory in .rodata (potentially returned by devm_kstrdup_const()) - correctly handle ZERO_SIZE_PTR passed as the ptr argument in devm_krealloc() v2 -> v3: - drop already applied patches - collect Acks - add an additional user in iio v3 -> v4: - add the kerneldoc for devm_krealloc() - WARN() outside of spinlock - rename local variable v4 -> v5: - tweak the kerneldoc v5 -> v6: - tweak the devres_lock handling in devm_krealloc() v6 -> v7: - rework devm_krealloc() to avoid calling krealloc() with spinlock taken Bartosz Golaszewski (3): devres: provide devm_krealloc() hwmon: pmbus: use more devres helpers iio: adc: xilinx-xadc: use devm_krealloc() .../driver-api/driver-model/devres.rst | 1 + drivers/base/devres.c | 93 +++++++++++++++++++ drivers/hwmon/pmbus/pmbus_core.c | 28 ++---- drivers/iio/adc/xilinx-xadc-core.c | 16 ++-- include/linux/device.h | 2 + 5 files changed, 113 insertions(+), 27 deletions(-) -- 2.26.1 _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel